xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 1/3] x86/idle: re-arrange dead-idle handling
Date: Mon, 20 May 2019 15:25:49 +0100	[thread overview]
Message-ID: <84f00023-400a-fda9-2b47-ab7041a0d35c@citrix.com> (raw)
Message-ID: <20190520142549.IOL26bEhWQONDve14CnI5NSW0A_kY0HCYQQINRsOWPE@z> (raw)
In-Reply-To: <5CDE88EA0200007800230031@prv1-mh.provo.novell.com>

On 17/05/2019 11:11, Jan Beulich wrote:
> In order to be able to wake parked CPUs from default_dead_idle() (for
> them to then enter a different dead-idle routine), the function should
> not itself loop. Move the loop into play_dead(), and use play_dead() as
> well on the AP boot error path.
>
> Furthermore, not the least considering the comment in play_dead(),
> make sure NMI raised (for now this would be a bug elsewhere, but that's
> about to change) against a parked or fully offline CPU won't invoke the
> actual, full-blown NMI handler.
>
> Note however that this doesn't make #MC any safer for fully offline
> CPUs.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-20 14:26 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 14:22 [PATCH 0/5] x86: more power-efficient CPU parking Jan Beulich
2018-08-01 14:31 ` [PATCH 1/5] x86/cpuidle: replace a pointless NULL check Jan Beulich
2018-08-01 14:33   ` Andrew Cooper
2018-08-01 15:12     ` Jan Beulich
2018-08-01 14:31 ` [PATCH 2/5] x86/idle: re-arrange dead-idle handling Jan Beulich
2018-09-07 17:08   ` Andrew Cooper
2018-09-10 10:13     ` Jan Beulich
2018-10-26 10:55       ` Ping: " Jan Beulich
2018-12-05 20:33       ` Andrew Cooper
2018-12-06  8:16         ` Jan Beulich
2018-08-01 14:32 ` [PATCH 3/5] x86/cpuidle: push parked CPUs into deeper sleep states when possible Jan Beulich
2018-10-26 10:56   ` Ping: " Jan Beulich
2018-08-01 14:33 ` [PATCH 4/5] x86/cpuidle: clean up Cx dumping Jan Beulich
2018-08-01 14:40   ` Andrew Cooper
2018-08-01 14:33 ` [PATCH 5/5] x86: place non-parked CPUs into wait-for-SIPI state after offlining Jan Beulich
2018-08-29  7:08 ` Ping: [PATCH 0/5] x86: more power-efficient CPU parking Jan Beulich
2018-08-29 17:01   ` Andrew Cooper
2018-08-30  7:29     ` Jan Beulich
     [not found] ` <5B61C21202000000000FC1F1@prv1-mh.provo.novell.com>
     [not found]   ` <5B61C21202000078001F8805@prv1-mh.provo.novell.com>
     [not found]     ` <5B61C21202000000000FC6BD@prv1-mh.provo.novell.com>
     [not found]       ` <5B61C212020000780020B6D8@prv1-mh.provo.novell.com>
     [not found]         ` <5B61C21202000000000FF27E@prv1-mh.provo.novell.com>
     [not found]           ` <5B61C2120200007800224310@prv1-mh.provo.novell.com>
2019-04-03 10:12             ` Jan Beulich
2019-04-03 11:14               ` Andrew Cooper
2019-04-03 12:43                 ` Jan Beulich
2019-04-03 14:44                   ` Andrew Cooper
2019-04-03 15:20                     ` Jan Beulich
     [not found]             ` <5B61C2120200000000101EDC@prv1-mh.provo.novell.com>
     [not found]               ` <5B61C212020000780022FF0D@prv1-mh.provo.novell.com>
2019-05-17 10:10                 ` [PATCH v2 0/3] " Jan Beulich
2019-05-17 10:10                   ` [Xen-devel] " Jan Beulich
2019-05-17 10:11                   ` [PATCH v2 1/3] x86/idle: re-arrange dead-idle handling Jan Beulich
2019-05-17 10:11                     ` [Xen-devel] " Jan Beulich
2019-05-20 14:25                     ` Andrew Cooper [this message]
2019-05-20 14:25                       ` Andrew Cooper
2019-05-17 10:12                   ` [PATCH v2 2/3] x86/cpuidle: push parked CPUs into deeper sleep states when possible Jan Beulich
2019-05-17 10:12                     ` [Xen-devel] " Jan Beulich
2019-05-17 10:12                   ` [PATCH v2 3/3] x86/cpuidle: clean up Cx dumping Jan Beulich
2019-05-17 10:12                     ` [Xen-devel] " Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84f00023-400a-fda9-2b47-ab7041a0d35c@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).