From: "Jan Beulich" <JBeulich@suse.com> To: xen-devel <xen-devel@lists.xenproject.org> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Roger Pau Monne <roger.pau@citrix.com> Subject: [PATCH v2 3/3] x86/cpuidle: clean up Cx dumping Date: Fri, 17 May 2019 04:12:34 -0600 [thread overview] Message-ID: <5CDE89120200007800230037@prv1-mh.provo.novell.com> (raw) In-Reply-To: <5CDE88900200007800230027@prv1-mh.provo.novell.com> Don't log the same global information once per CPU. Don't log the same information (here: the currently active state) twice. Don't prefix decimal numbers with zeros (giving the impression they're octal). Use format specifiers matching the type of the corresponding expressions. Don't split printk()-s without intervening new-lines. Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -304,9 +304,6 @@ static void print_acpi_power(uint32_t cp printk("==cpu%d==\n", cpu); last_state_idx = power->last_state ? power->last_state->idx : -1; - printk("active state:\t\tC%d\n", last_state_idx); - printk("max_cstate:\t\tC%d\n", max_cstate); - printk("states:\n"); spin_lock_irq(&power->stat_lock); current_tick = cpuidle_get_tick(); @@ -331,16 +328,14 @@ static void print_acpi_power(uint32_t cp idle_usage += usage[i]; idle_res += tick_to_ns(res_tick[i]); - printk((last_state_idx == i) ? " *" : " "); - printk("C%d:\t", i); - printk("type[C%d] ", power->states[i].type); - printk("latency[%03d] ", power->states[i].latency); - printk("usage[%08"PRIu64"] ", usage[i]); - printk("method[%5s] ", acpi_cstate_method_name[power->states[i].entry_method]); - printk("duration[%"PRIu64"]\n", tick_to_ns(res_tick[i])); + printk(" %cC%u:\ttype[C%d] latency[%3u] usage[%8"PRIu64"] method[%5s] duration[%"PRIu64"]\n", + (last_state_idx == i) ? '*' : ' ', i, + power->states[i].type, power->states[i].latency, usage[i], + acpi_cstate_method_name[power->states[i].entry_method], + tick_to_ns(res_tick[i])); } - printk((last_state_idx == 0) ? " *" : " "); - printk("C0:\tusage[%08"PRIu64"] duration[%"PRIu64"]\n", + printk(" %cC0:\tusage[%8"PRIu64"] duration[%"PRIu64"]\n", + (last_state_idx == 0) ? '*' : ' ', usage[0] + idle_usage, current_stime - idle_res); print_hw_residencies(cpu); @@ -351,6 +346,7 @@ static void dump_cx(unsigned char key) unsigned int cpu; printk("'%c' pressed -> printing ACPI Cx structures\n", key); + printk("max cstate: C%u\n", max_cstate); for_each_present_cpu ( cpu ) { struct acpi_processor_power *power = processor_powers[cpu]; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com> To: "xen-devel" <xen-devel@lists.xenproject.org> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Roger Pau Monne <roger.pau@citrix.com> Subject: [Xen-devel] [PATCH v2 3/3] x86/cpuidle: clean up Cx dumping Date: Fri, 17 May 2019 04:12:34 -0600 [thread overview] Message-ID: <5CDE89120200007800230037@prv1-mh.provo.novell.com> (raw) Message-ID: <20190517101234.Dc9-piPAYnlB8MNpOsnVsLmQMRkX6OPwnhG81AP2lGE@z> (raw) In-Reply-To: <5CDE88900200007800230027@prv1-mh.provo.novell.com> Don't log the same global information once per CPU. Don't log the same information (here: the currently active state) twice. Don't prefix decimal numbers with zeros (giving the impression they're octal). Use format specifiers matching the type of the corresponding expressions. Don't split printk()-s without intervening new-lines. Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -304,9 +304,6 @@ static void print_acpi_power(uint32_t cp printk("==cpu%d==\n", cpu); last_state_idx = power->last_state ? power->last_state->idx : -1; - printk("active state:\t\tC%d\n", last_state_idx); - printk("max_cstate:\t\tC%d\n", max_cstate); - printk("states:\n"); spin_lock_irq(&power->stat_lock); current_tick = cpuidle_get_tick(); @@ -331,16 +328,14 @@ static void print_acpi_power(uint32_t cp idle_usage += usage[i]; idle_res += tick_to_ns(res_tick[i]); - printk((last_state_idx == i) ? " *" : " "); - printk("C%d:\t", i); - printk("type[C%d] ", power->states[i].type); - printk("latency[%03d] ", power->states[i].latency); - printk("usage[%08"PRIu64"] ", usage[i]); - printk("method[%5s] ", acpi_cstate_method_name[power->states[i].entry_method]); - printk("duration[%"PRIu64"]\n", tick_to_ns(res_tick[i])); + printk(" %cC%u:\ttype[C%d] latency[%3u] usage[%8"PRIu64"] method[%5s] duration[%"PRIu64"]\n", + (last_state_idx == i) ? '*' : ' ', i, + power->states[i].type, power->states[i].latency, usage[i], + acpi_cstate_method_name[power->states[i].entry_method], + tick_to_ns(res_tick[i])); } - printk((last_state_idx == 0) ? " *" : " "); - printk("C0:\tusage[%08"PRIu64"] duration[%"PRIu64"]\n", + printk(" %cC0:\tusage[%8"PRIu64"] duration[%"PRIu64"]\n", + (last_state_idx == 0) ? '*' : ' ', usage[0] + idle_usage, current_stime - idle_res); print_hw_residencies(cpu); @@ -351,6 +346,7 @@ static void dump_cx(unsigned char key) unsigned int cpu; printk("'%c' pressed -> printing ACPI Cx structures\n", key); + printk("max cstate: C%u\n", max_cstate); for_each_present_cpu ( cpu ) { struct acpi_processor_power *power = processor_powers[cpu]; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-17 10:12 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-01 14:22 [PATCH 0/5] x86: more power-efficient CPU parking Jan Beulich 2018-08-01 14:31 ` [PATCH 1/5] x86/cpuidle: replace a pointless NULL check Jan Beulich 2018-08-01 14:33 ` Andrew Cooper 2018-08-01 15:12 ` Jan Beulich 2018-08-01 14:31 ` [PATCH 2/5] x86/idle: re-arrange dead-idle handling Jan Beulich 2018-09-07 17:08 ` Andrew Cooper 2018-09-10 10:13 ` Jan Beulich 2018-10-26 10:55 ` Ping: " Jan Beulich 2018-12-05 20:33 ` Andrew Cooper 2018-12-06 8:16 ` Jan Beulich 2018-08-01 14:32 ` [PATCH 3/5] x86/cpuidle: push parked CPUs into deeper sleep states when possible Jan Beulich 2018-10-26 10:56 ` Ping: " Jan Beulich 2018-08-01 14:33 ` [PATCH 4/5] x86/cpuidle: clean up Cx dumping Jan Beulich 2018-08-01 14:40 ` Andrew Cooper 2018-08-01 14:33 ` [PATCH 5/5] x86: place non-parked CPUs into wait-for-SIPI state after offlining Jan Beulich 2018-08-29 7:08 ` Ping: [PATCH 0/5] x86: more power-efficient CPU parking Jan Beulich 2018-08-29 17:01 ` Andrew Cooper 2018-08-30 7:29 ` Jan Beulich [not found] ` <5B61C21202000000000FC1F1@prv1-mh.provo.novell.com> [not found] ` <5B61C21202000078001F8805@prv1-mh.provo.novell.com> [not found] ` <5B61C21202000000000FC6BD@prv1-mh.provo.novell.com> [not found] ` <5B61C212020000780020B6D8@prv1-mh.provo.novell.com> [not found] ` <5B61C21202000000000FF27E@prv1-mh.provo.novell.com> [not found] ` <5B61C2120200007800224310@prv1-mh.provo.novell.com> 2019-04-03 10:12 ` Jan Beulich 2019-04-03 11:14 ` Andrew Cooper 2019-04-03 12:43 ` Jan Beulich 2019-04-03 14:44 ` Andrew Cooper 2019-04-03 15:20 ` Jan Beulich [not found] ` <5B61C2120200000000101EDC@prv1-mh.provo.novell.com> [not found] ` <5B61C212020000780022FF0D@prv1-mh.provo.novell.com> 2019-05-17 10:10 ` [PATCH v2 0/3] " Jan Beulich 2019-05-17 10:10 ` [Xen-devel] " Jan Beulich 2019-05-17 10:11 ` [PATCH v2 1/3] x86/idle: re-arrange dead-idle handling Jan Beulich 2019-05-17 10:11 ` [Xen-devel] " Jan Beulich 2019-05-20 14:25 ` Andrew Cooper 2019-05-20 14:25 ` [Xen-devel] " Andrew Cooper 2019-05-17 10:12 ` [PATCH v2 2/3] x86/cpuidle: push parked CPUs into deeper sleep states when possible Jan Beulich 2019-05-17 10:12 ` [Xen-devel] " Jan Beulich 2019-05-17 10:12 ` Jan Beulich [this message] 2019-05-17 10:12 ` [Xen-devel] [PATCH v2 3/3] x86/cpuidle: clean up Cx dumping Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5CDE89120200007800230037@prv1-mh.provo.novell.com \ --to=jbeulich@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=roger.pau@citrix.com \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).