Re: [PATCH v5 09/10] tools/arm: tee: add "tee" option for xl.cfg

[Julien Grall <julien.grall@arm.com>]

Hi Volodymyr,

Some comment on the documentation, the rest looks good to me.


On 21/05/2019 22:26, Volodymyr Babchuk wrote:
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index c7d70e618b..73c64dc896 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1544,6 +1544,25 @@ Set maximum height for pointer device.
>   
>   =back
>   
> +=item B<tee=["none", "optee"]>

This will become quite difficult to read if we add more TEE. How about:

<tee="STRING">?

> +
> +Set TEE type for the guest. TEE is a Trusted Execution Environment -- separate
> +secuse OS found on some platforms.

s/secuse/secure/

I would also mention this is Arm only so far. Maybe:

B<Arm only> Set TEE...

> +
> +=over 4
> +
> +=item B<"none">
> +
> +Disable TEE support at all. This is the default value.
> +
> +=item B<"optee">
> +
> +Allow guest to access to OP-TEE enabled on the platform. Guest will not be created
> +if platform does not have OP-TEE with virtualization feature or if OP-TEE will
> +deny access.

I have some trouble to read this paragraph. How about:

"Allow a guest to use OP-TEE. Note that a virtualization-aware OP-TEE is 
required for this.".

> +
> +=back
> +
>   =back
>   
>   =head2 Paravirtualised (PV) Guest Specific Options

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel