From: Julien Grall <julien.grall@arm.com> To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, Stefano Stabellini <sstabellini@kernel.org> Subject: Re: [PATCH v5 07/10] xen/arm: optee: add support for arbitrary shared memory Date: Mon, 3 Jun 2019 13:29:01 +0100 [thread overview] Message-ID: <9526dbfc-ca51-9d39-0d67-ce1009dba3a5@arm.com> (raw) In-Reply-To: <20190521212530.12706-8-volodymyr_babchuk@epam.com> Hi Volodymyr, On 21/05/2019 22:26, Volodymyr Babchuk wrote: > + while ( pg_count ) > + { > + struct page_info *page; > + > + if ( idx == 0 ) > + { > + guest_pg = get_domain_ram_page(gfn); > + if ( !guest_pg ) > + return -EINVAL; > + > + guest_data = __map_domain_page(guest_pg); > + xen_data = __map_domain_page(xen_pgs); > + } > + > + /* > + * TODO: That function can pin up to 64MB of guest memory by > + * calling lookup_and_pin_guest_ram_addr() 16384 times. I can't find the BUILD_BUG_ON(PAGE_SIZE != 4096) as I requested before. > + * This is considered insecure and should be fixed in the future. Well, it is not "considered", it is insecure as the guest would be able to delay processing other guest for some times. So how about: "This should be addressed before declaring OP-TEE security supported". With that: Acked-by: Julien Grall <julien.grall@arm.com> > + */ Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, Stefano Stabellini <sstabellini@kernel.org> Subject: Re: [Xen-devel] [PATCH v5 07/10] xen/arm: optee: add support for arbitrary shared memory Date: Mon, 3 Jun 2019 13:29:01 +0100 [thread overview] Message-ID: <9526dbfc-ca51-9d39-0d67-ce1009dba3a5@arm.com> (raw) Message-ID: <20190603122901.QkRhozcWJpL1CMAb2FHE_O_Eho4C-LxOdYP4Q0rbk2o@z> (raw) In-Reply-To: <20190521212530.12706-8-volodymyr_babchuk@epam.com> Hi Volodymyr, On 21/05/2019 22:26, Volodymyr Babchuk wrote: > + while ( pg_count ) > + { > + struct page_info *page; > + > + if ( idx == 0 ) > + { > + guest_pg = get_domain_ram_page(gfn); > + if ( !guest_pg ) > + return -EINVAL; > + > + guest_data = __map_domain_page(guest_pg); > + xen_data = __map_domain_page(xen_pgs); > + } > + > + /* > + * TODO: That function can pin up to 64MB of guest memory by > + * calling lookup_and_pin_guest_ram_addr() 16384 times. I can't find the BUILD_BUG_ON(PAGE_SIZE != 4096) as I requested before. > + * This is considered insecure and should be fixed in the future. Well, it is not "considered", it is insecure as the guest would be able to delay processing other guest for some times. So how about: "This should be addressed before declaring OP-TEE security supported". With that: Acked-by: Julien Grall <julien.grall@arm.com> > + */ Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-03 12:29 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-21 21:25 [PATCH v5 00/10] TEE mediator (and OP-TEE) support in XEN Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-05-21 21:25 ` [PATCH v5 01/10] xen/arm: add generic TEE mediator framework Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-05-22 8:45 ` Jan Beulich 2019-05-22 8:45 ` [Xen-devel] " Jan Beulich 2019-05-22 9:27 ` Julien Grall 2019-05-22 9:27 ` [Xen-devel] " Julien Grall 2019-05-22 10:02 ` Jan Beulich 2019-05-22 10:02 ` [Xen-devel] " Jan Beulich 2019-05-22 12:04 ` Julien Grall 2019-05-22 12:04 ` [Xen-devel] " Julien Grall 2019-06-03 11:46 ` Julien Grall 2019-06-03 11:46 ` [Xen-devel] " Julien Grall 2019-06-03 11:48 ` Julien Grall 2019-06-03 11:48 ` [Xen-devel] " Julien Grall 2019-06-06 16:02 ` Julien Grall 2019-06-07 9:36 ` Julien Grall 2019-06-11 18:18 ` Volodymyr Babchuk 2019-06-11 18:26 ` Julien Grall 2019-05-21 21:25 ` [PATCH v5 02/10] xen/arm: optee: add OP-TEE header files Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 11:49 ` Julien Grall 2019-06-03 11:49 ` [Xen-devel] " Julien Grall 2019-06-10 18:20 ` Volodymyr Babchuk 2019-06-10 18:53 ` Julien Grall 2019-05-21 21:25 ` [PATCH v5 03/10] xen/arm: optee: add OP-TEE mediator skeleton Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:25 ` [PATCH v5 04/10] xen/arm: optee: add fast calls handling Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 05/10] xen/arm: optee: add std call handling Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 06/10] xen/arm: optee: add support for RPC SHM buffers Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:33 ` Julien Grall 2019-06-03 12:33 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 07/10] xen/arm: optee: add support for arbitrary shared memory Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:29 ` Julien Grall [this message] 2019-06-03 12:29 ` Julien Grall 2019-05-21 21:26 ` [PATCH v5 08/10] xen/arm: optee: add support for RPC commands Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:33 ` Julien Grall 2019-06-03 12:33 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 09/10] tools/arm: tee: add "tee" option for xl.cfg Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:44 ` Julien Grall 2019-06-03 12:44 ` [Xen-devel] " Julien Grall 2019-06-03 14:47 ` Ian Jackson 2019-06-03 14:47 ` [Xen-devel] " Ian Jackson 2019-05-21 21:26 ` [PATCH v5 10/10] tools/arm: optee: create optee firmware node in DT if tee=optee Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 14:50 ` Ian Jackson 2019-06-03 14:50 ` [Xen-devel] " Ian Jackson 2019-06-01 14:50 ` [PATCH v5 00/10] TEE mediator (and OP-TEE) support in XEN Julien Grall 2019-06-01 14:50 ` [Xen-devel] " Julien Grall 2019-06-01 16:07 ` Volodymyr Babchuk 2019-06-01 16:07 ` [Xen-devel] " Volodymyr Babchuk 2019-06-01 16:55 ` Julien Grall 2019-06-01 16:55 ` [Xen-devel] " Julien Grall 2019-06-04 13:31 ` Volodymyr Babchuk 2019-06-06 15:33 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9526dbfc-ca51-9d39-0d67-ce1009dba3a5@arm.com \ --to=julien.grall@arm.com \ --cc=Volodymyr_Babchuk@epam.com \ --cc=sstabellini@kernel.org \ --cc=tee-dev@lists.linaro.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).