From: Julien Grall <julien.grall@arm.com> To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, Jan Beulich <jbeulich@suse.com> Subject: Re: [PATCH v5 01/10] xen/arm: add generic TEE mediator framework Date: Mon, 3 Jun 2019 12:46:23 +0100 [thread overview] Message-ID: <e98e452a-b6b4-6296-5e9a-e00c8acc5951@arm.com> (raw) In-Reply-To: <20190521212530.12706-2-volodymyr_babchuk@epam.com> Hi Volodymyr, On 21/05/2019 22:25, Volodymyr Babchuk wrote: > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index ccb0f181ea..1a240d208b 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -49,6 +49,7 @@ > #include <asm/platform.h> > #include <asm/procinfo.h> > #include <asm/setup.h> > +#include <asm/tee/tee.h> > #include <xsm/xsm.h> > #include <asm/acpi.h> > > @@ -895,6 +896,7 @@ void __init start_xen(unsigned long boot_phys_offset, > dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; > if ( gic_number_lines() > 992 ) > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > + dom0_cfg.arch.tee_type = tee_get_type(); I was expecting some code to generate/dropped the OP-TEE node in Dom0 DTB. For instance, we want to promote the use of "hvc" and not "smc". > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > dom0 = domain_create(0, &dom0_cfg, true); > diff --git a/xen/arch/arm/tee/Makefile b/xen/arch/arm/tee/Makefile > new file mode 100644 > index 0000000000..c54d4796ff > --- /dev/null > +++ b/xen/arch/arm/tee/Makefile > @@ -0,0 +1 @@ > +obj-y += tee.o > diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c > new file mode 100644 > index 0000000000..6bda846953 > --- /dev/null > +++ b/xen/arch/arm/tee/tee.c > @@ -0,0 +1,93 @@ > +/* > + * xen/arch/arm/tee/tee.c > + * > + * Generic part of TEE mediator subsystem > + * > + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> > + * Copyright (c) 2018-2019 EPAM Systems. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <xen/errno.h> > +#include <xen/init.h> > +#include <xen/types.h> > + > +#include <asm/tee/tee.h> > + > +extern const struct tee_mediator_desc _steemediator[], _eteemediator[]; > +static const struct tee_mediator_desc *cur_mediator; NIT: You probably want a __read_mostly here. Both changes can be done in follow-up: Reviewed-by: Julien Grall <julien.grall@arm.com> Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, Jan Beulich <jbeulich@suse.com> Subject: Re: [Xen-devel] [PATCH v5 01/10] xen/arm: add generic TEE mediator framework Date: Mon, 3 Jun 2019 12:46:23 +0100 [thread overview] Message-ID: <e98e452a-b6b4-6296-5e9a-e00c8acc5951@arm.com> (raw) Message-ID: <20190603114623.E6c9p-9CuYEr-j_obzAjzd9OkSbHTNVhD1Le-ZQ_yYQ@z> (raw) In-Reply-To: <20190521212530.12706-2-volodymyr_babchuk@epam.com> Hi Volodymyr, On 21/05/2019 22:25, Volodymyr Babchuk wrote: > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index ccb0f181ea..1a240d208b 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -49,6 +49,7 @@ > #include <asm/platform.h> > #include <asm/procinfo.h> > #include <asm/setup.h> > +#include <asm/tee/tee.h> > #include <xsm/xsm.h> > #include <asm/acpi.h> > > @@ -895,6 +896,7 @@ void __init start_xen(unsigned long boot_phys_offset, > dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; > if ( gic_number_lines() > 992 ) > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > + dom0_cfg.arch.tee_type = tee_get_type(); I was expecting some code to generate/dropped the OP-TEE node in Dom0 DTB. For instance, we want to promote the use of "hvc" and not "smc". > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > dom0 = domain_create(0, &dom0_cfg, true); > diff --git a/xen/arch/arm/tee/Makefile b/xen/arch/arm/tee/Makefile > new file mode 100644 > index 0000000000..c54d4796ff > --- /dev/null > +++ b/xen/arch/arm/tee/Makefile > @@ -0,0 +1 @@ > +obj-y += tee.o > diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c > new file mode 100644 > index 0000000000..6bda846953 > --- /dev/null > +++ b/xen/arch/arm/tee/tee.c > @@ -0,0 +1,93 @@ > +/* > + * xen/arch/arm/tee/tee.c > + * > + * Generic part of TEE mediator subsystem > + * > + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> > + * Copyright (c) 2018-2019 EPAM Systems. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <xen/errno.h> > +#include <xen/init.h> > +#include <xen/types.h> > + > +#include <asm/tee/tee.h> > + > +extern const struct tee_mediator_desc _steemediator[], _eteemediator[]; > +static const struct tee_mediator_desc *cur_mediator; NIT: You probably want a __read_mostly here. Both changes can be done in follow-up: Reviewed-by: Julien Grall <julien.grall@arm.com> Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-03 11:46 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-21 21:25 [PATCH v5 00/10] TEE mediator (and OP-TEE) support in XEN Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-05-21 21:25 ` [PATCH v5 01/10] xen/arm: add generic TEE mediator framework Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-05-22 8:45 ` Jan Beulich 2019-05-22 8:45 ` [Xen-devel] " Jan Beulich 2019-05-22 9:27 ` Julien Grall 2019-05-22 9:27 ` [Xen-devel] " Julien Grall 2019-05-22 10:02 ` Jan Beulich 2019-05-22 10:02 ` [Xen-devel] " Jan Beulich 2019-05-22 12:04 ` Julien Grall 2019-05-22 12:04 ` [Xen-devel] " Julien Grall 2019-06-03 11:46 ` Julien Grall [this message] 2019-06-03 11:46 ` Julien Grall 2019-06-03 11:48 ` Julien Grall 2019-06-03 11:48 ` [Xen-devel] " Julien Grall 2019-06-06 16:02 ` Julien Grall 2019-06-07 9:36 ` Julien Grall 2019-06-11 18:18 ` Volodymyr Babchuk 2019-06-11 18:26 ` Julien Grall 2019-05-21 21:25 ` [PATCH v5 02/10] xen/arm: optee: add OP-TEE header files Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 11:49 ` Julien Grall 2019-06-03 11:49 ` [Xen-devel] " Julien Grall 2019-06-10 18:20 ` Volodymyr Babchuk 2019-06-10 18:53 ` Julien Grall 2019-05-21 21:25 ` [PATCH v5 03/10] xen/arm: optee: add OP-TEE mediator skeleton Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:25 ` [PATCH v5 04/10] xen/arm: optee: add fast calls handling Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 05/10] xen/arm: optee: add std call handling Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 06/10] xen/arm: optee: add support for RPC SHM buffers Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:33 ` Julien Grall 2019-06-03 12:33 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 07/10] xen/arm: optee: add support for arbitrary shared memory Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:29 ` Julien Grall 2019-06-03 12:29 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 08/10] xen/arm: optee: add support for RPC commands Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:33 ` Julien Grall 2019-06-03 12:33 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 09/10] tools/arm: tee: add "tee" option for xl.cfg Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:44 ` Julien Grall 2019-06-03 12:44 ` [Xen-devel] " Julien Grall 2019-06-03 14:47 ` Ian Jackson 2019-06-03 14:47 ` [Xen-devel] " Ian Jackson 2019-05-21 21:26 ` [PATCH v5 10/10] tools/arm: optee: create optee firmware node in DT if tee=optee Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 14:50 ` Ian Jackson 2019-06-03 14:50 ` [Xen-devel] " Ian Jackson 2019-06-01 14:50 ` [PATCH v5 00/10] TEE mediator (and OP-TEE) support in XEN Julien Grall 2019-06-01 14:50 ` [Xen-devel] " Julien Grall 2019-06-01 16:07 ` Volodymyr Babchuk 2019-06-01 16:07 ` [Xen-devel] " Volodymyr Babchuk 2019-06-01 16:55 ` Julien Grall 2019-06-01 16:55 ` [Xen-devel] " Julien Grall 2019-06-04 13:31 ` Volodymyr Babchuk 2019-06-06 15:33 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e98e452a-b6b4-6296-5e9a-e00c8acc5951@arm.com \ --to=julien.grall@arm.com \ --cc=George.Dunlap@eu.citrix.com \ --cc=Volodymyr_Babchuk@epam.com \ --cc=andrew.cooper3@citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=jbeulich@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=sstabellini@kernel.org \ --cc=tee-dev@lists.linaro.org \ --cc=tim@xen.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).