From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
andrew.cooper3@citrix.com, JBeulich@suse.com,
Stefano Stabellini <stefanos@xilinx.com>
Subject: Re: [Xen-devel] [PATCH v2 02/10] xen: rename un/map_mmio_regions to un/map_regions
Date: Tue, 18 Jun 2019 13:19:17 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1906181317550.2072@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <e1d8a184-284d-1af3-1732-25022ea6b348@arm.com>
On Tue, 18 Jun 2019, Julien Grall wrote:
> Hi Stefano,
>
> On 17/06/2019 22:24, Stefano Stabellini wrote:
> > On Wed, 1 May 2019, Julien Grall wrote:
> > > Hi,
> > >
> > > On 30/04/2019 22:02, Stefano Stabellini wrote:
> > > > Now that map_mmio_regions takes a p2mt parameter, there is no need to
> > > > keep "mmio" in the name. The p2mt parameter does a better job at
> > > > expressing what the mapping is about. Let's save the environment 5
> > > > characters at a time.
> > >
> > > At least on Arm, what's the difference with guest_physmap_add_entry and
> > > this
> > > function now? On x86, how does the user now which function to use?
> > >
> > > What actually tell the users it should not use this function for RAM?
> >
> > Also taking into account Jan's comments, I'll drop this patch in the
> > next version, keeping the original name map_mmio_regions. If you have an
> > alternative suggestion let me know and I'll try to follow it.
>
> As long as only p2m_mmio_* types can be used here, then I am fine with it.
Only the p2m_mmio_* types are used, but there are no checks. I'll add an
ASSERT.
> Compare to x86, the P2M interface on Arm is pretty much a wild west so far. I
> have a TODO to rethink and add more check in them on Arm.
Yes, thank you
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-18 20:19 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 21:02 [PATCH v2 0/10] iomem memory policy Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-04-30 21:02 ` [PATCH v2 01/10] xen: add a p2mt parameter to map_mmio_regions Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-02 14:59 ` Jan Beulich
2019-05-02 14:59 ` [Xen-devel] " Jan Beulich
2019-05-02 18:49 ` Stefano Stabellini
2019-05-02 18:49 ` [Xen-devel] " Stefano Stabellini
2019-05-15 13:39 ` Oleksandr
2019-05-15 13:39 ` [Xen-devel] " Oleksandr
2019-04-30 21:02 ` [PATCH v2 02/10] xen: rename un/map_mmio_regions to un/map_regions Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-01 9:22 ` Julien Grall
2019-05-01 9:22 ` [Xen-devel] " Julien Grall
2019-06-17 21:24 ` Stefano Stabellini
2019-06-18 11:05 ` Julien Grall
2019-06-18 20:19 ` Stefano Stabellini [this message]
2019-05-02 15:03 ` Jan Beulich
2019-05-02 15:03 ` [Xen-devel] " Jan Beulich
2019-05-02 18:55 ` Stefano Stabellini
2019-05-02 18:55 ` [Xen-devel] " Stefano Stabellini
2019-04-30 21:02 ` [PATCH v2 03/10] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-02 15:12 ` Jan Beulich
2019-05-02 15:12 ` [Xen-devel] " Jan Beulich
2019-06-17 21:28 ` Stefano Stabellini
2019-06-18 8:59 ` Jan Beulich
2019-06-18 20:32 ` Stefano Stabellini
2019-06-18 23:15 ` Stefano Stabellini
2019-06-19 6:53 ` Jan Beulich
2019-05-07 16:41 ` Julien Grall
2019-05-07 16:41 ` [Xen-devel] " Julien Grall
2019-06-17 22:43 ` Stefano Stabellini
2019-06-18 11:13 ` Julien Grall
2019-05-15 14:40 ` Oleksandr
2019-05-15 14:40 ` [Xen-devel] " Oleksandr
2019-04-30 21:02 ` [PATCH v2 04/10] libxc: introduce xc_domain_mem_map_policy Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-04-30 21:02 ` [PATCH v2 05/10] libxl/xl: add memory policy option to iomem Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-01 9:42 ` Julien Grall
2019-05-01 9:42 ` [Xen-devel] " Julien Grall
2019-06-17 22:32 ` Stefano Stabellini
2019-06-18 11:09 ` Julien Grall
2019-06-18 11:15 ` Julien Grall
2019-06-18 22:07 ` Stefano Stabellini
2019-06-18 22:20 ` Julien Grall
2019-06-18 22:46 ` Stefano Stabellini
2019-04-30 21:02 ` [PATCH v2 06/10] xen/arm: extend device_tree_for_each_node Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-07 17:12 ` Julien Grall
2019-05-07 17:12 ` [Xen-devel] " Julien Grall
2019-04-30 21:02 ` [PATCH v2 07/10] xen/arm: make process_memory_node a device_tree_node_func Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-01 9:47 ` Julien Grall
2019-05-01 9:47 ` [Xen-devel] " Julien Grall
2019-04-30 21:02 ` [PATCH v2 08/10] xen/arm: keep track of reserved-memory regions Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-01 10:03 ` Julien Grall
2019-05-01 10:03 ` [Xen-devel] " Julien Grall
2019-06-21 23:47 ` Stefano Stabellini
2019-05-07 17:21 ` Julien Grall
2019-05-07 17:21 ` [Xen-devel] " Julien Grall
2019-04-30 21:02 ` [PATCH v2 09/10] xen/arm: map reserved-memory regions as normal memory in dom0 Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-07 19:52 ` Julien Grall
2019-05-07 19:52 ` [Xen-devel] " Julien Grall
2019-04-30 21:02 ` [PATCH v2 10/10] xen/arm: add reserved-memory regions to the dom0 memory node Stefano Stabellini
2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini
2019-05-07 20:15 ` Julien Grall
2019-05-07 20:15 ` [Xen-devel] " Julien Grall
2019-05-10 20:51 ` Stefano Stabellini
2019-05-10 20:51 ` [Xen-devel] " Stefano Stabellini
2019-05-10 21:43 ` Julien Grall
2019-05-10 21:43 ` [Xen-devel] " Julien Grall
2019-05-11 12:40 ` Julien Grall
2019-05-11 12:40 ` [Xen-devel] " Julien Grall
2019-05-20 21:26 ` Stefano Stabellini
2019-05-20 21:26 ` [Xen-devel] " Stefano Stabellini
2019-05-20 22:38 ` Julien Grall
2019-05-20 22:38 ` [Xen-devel] " Julien Grall
2019-06-05 16:30 ` Julien Grall
2019-06-21 23:47 ` Stefano Stabellini
2019-05-16 16:52 ` [PATCH v2 0/10] iomem memory policy Oleksandr
2019-05-16 16:52 ` [Xen-devel] " Oleksandr
2019-06-21 23:48 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906181317550.2072@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).