From: "Jan Beulich" <JBeulich@suse.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien.grall@arm.com>, Stefano Stabellini <stefanos@xilinx.com>, xen-devel <xen-devel@lists.xenproject.org> Subject: Re: [PATCH v2 01/10] xen: add a p2mt parameter to map_mmio_regions Date: Thu, 02 May 2019 08:59:18 -0600 [thread overview] Message-ID: <5CCB05C6020000780022B567@prv1-mh.provo.novell.com> (raw) In-Reply-To: <1556658172-8824-1-git-send-email-sstabellini@kernel.org> >>> On 30.04.19 at 23:02, <sstabellini@kernel.org> wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -79,8 +79,11 @@ static int __init modify_identity_mmio(struct domain *d, unsigned long pfn, > > for ( ; ; ) > { > - rc = map ? map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn)) > - : unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn)); > + if ( map ) > + rc = map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn), > + p2m_mmio_direct); > + else > + rc = unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn)); May I ask that you leave alone the use of the conditional operator here, and _just_ add the new argument? > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -2264,12 +2264,16 @@ static unsigned int mmio_order(const struct domain *d, > int map_mmio_regions(struct domain *d, > gfn_t start_gfn, > unsigned long nr, > - mfn_t mfn) > + mfn_t mfn, > + p2m_type_t p2mt) > { > int ret = 0; > unsigned long i; > unsigned int iter, order; > > + if ( p2mt != p2m_mmio_direct ) > + return -EOPNOTSUPP; Considering this and ... > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -927,6 +927,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > unsigned long nr_mfns = op->u.memory_mapping.nr_mfns; > unsigned long mfn_end = mfn + nr_mfns - 1; > int add = op->u.memory_mapping.add_mapping; > + p2m_type_t p2mt; > > ret = -EINVAL; > if ( mfn_end < mfn || /* wrap? */ > @@ -939,6 +940,10 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > /* Must break hypercall up as this could take a while. */ > if ( nr_mfns > 64 ) > break; > + > + p2mt = p2m_mmio_direct_dev; > +#else > + p2mt = p2m_mmio_direct; > #endif ... this, is there really value in adding the new parameter for x86? A wrapper macro of the same name could be used to strip the new last argument at all call sites (current and future ones). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com> To: "Stefano Stabellini" <sstabellini@kernel.org> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien.grall@arm.com>, Stefano Stabellini <stefanos@xilinx.com>, xen-devel <xen-devel@lists.xenproject.org> Subject: Re: [Xen-devel] [PATCH v2 01/10] xen: add a p2mt parameter to map_mmio_regions Date: Thu, 02 May 2019 08:59:18 -0600 [thread overview] Message-ID: <5CCB05C6020000780022B567@prv1-mh.provo.novell.com> (raw) Message-ID: <20190502145918.jC1wLpm4mXvSF_zbr04ji7BEE7vpqnmDGgyFTZuhvQQ@z> (raw) In-Reply-To: <1556658172-8824-1-git-send-email-sstabellini@kernel.org> >>> On 30.04.19 at 23:02, <sstabellini@kernel.org> wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -79,8 +79,11 @@ static int __init modify_identity_mmio(struct domain *d, unsigned long pfn, > > for ( ; ; ) > { > - rc = map ? map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn)) > - : unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn)); > + if ( map ) > + rc = map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn), > + p2m_mmio_direct); > + else > + rc = unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn)); May I ask that you leave alone the use of the conditional operator here, and _just_ add the new argument? > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -2264,12 +2264,16 @@ static unsigned int mmio_order(const struct domain *d, > int map_mmio_regions(struct domain *d, > gfn_t start_gfn, > unsigned long nr, > - mfn_t mfn) > + mfn_t mfn, > + p2m_type_t p2mt) > { > int ret = 0; > unsigned long i; > unsigned int iter, order; > > + if ( p2mt != p2m_mmio_direct ) > + return -EOPNOTSUPP; Considering this and ... > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -927,6 +927,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > unsigned long nr_mfns = op->u.memory_mapping.nr_mfns; > unsigned long mfn_end = mfn + nr_mfns - 1; > int add = op->u.memory_mapping.add_mapping; > + p2m_type_t p2mt; > > ret = -EINVAL; > if ( mfn_end < mfn || /* wrap? */ > @@ -939,6 +940,10 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > /* Must break hypercall up as this could take a while. */ > if ( nr_mfns > 64 ) > break; > + > + p2mt = p2m_mmio_direct_dev; > +#else > + p2mt = p2m_mmio_direct; > #endif ... this, is there really value in adding the new parameter for x86? A wrapper macro of the same name could be used to strip the new last argument at all call sites (current and future ones). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-02 14:59 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-30 21:02 [PATCH v2 0/10] iomem memory policy Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-04-30 21:02 ` [PATCH v2 01/10] xen: add a p2mt parameter to map_mmio_regions Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-02 14:59 ` Jan Beulich [this message] 2019-05-02 14:59 ` Jan Beulich 2019-05-02 18:49 ` Stefano Stabellini 2019-05-02 18:49 ` [Xen-devel] " Stefano Stabellini 2019-05-15 13:39 ` Oleksandr 2019-05-15 13:39 ` [Xen-devel] " Oleksandr 2019-04-30 21:02 ` [PATCH v2 02/10] xen: rename un/map_mmio_regions to un/map_regions Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-01 9:22 ` Julien Grall 2019-05-01 9:22 ` [Xen-devel] " Julien Grall 2019-06-17 21:24 ` Stefano Stabellini 2019-06-18 11:05 ` Julien Grall 2019-06-18 20:19 ` Stefano Stabellini 2019-05-02 15:03 ` Jan Beulich 2019-05-02 15:03 ` [Xen-devel] " Jan Beulich 2019-05-02 18:55 ` Stefano Stabellini 2019-05-02 18:55 ` [Xen-devel] " Stefano Stabellini 2019-04-30 21:02 ` [PATCH v2 03/10] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-02 15:12 ` Jan Beulich 2019-05-02 15:12 ` [Xen-devel] " Jan Beulich 2019-06-17 21:28 ` Stefano Stabellini 2019-06-18 8:59 ` Jan Beulich 2019-06-18 20:32 ` Stefano Stabellini 2019-06-18 23:15 ` Stefano Stabellini 2019-06-19 6:53 ` Jan Beulich 2019-05-07 16:41 ` Julien Grall 2019-05-07 16:41 ` [Xen-devel] " Julien Grall 2019-06-17 22:43 ` Stefano Stabellini 2019-06-18 11:13 ` Julien Grall 2019-05-15 14:40 ` Oleksandr 2019-05-15 14:40 ` [Xen-devel] " Oleksandr 2019-04-30 21:02 ` [PATCH v2 04/10] libxc: introduce xc_domain_mem_map_policy Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-04-30 21:02 ` [PATCH v2 05/10] libxl/xl: add memory policy option to iomem Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-01 9:42 ` Julien Grall 2019-05-01 9:42 ` [Xen-devel] " Julien Grall 2019-06-17 22:32 ` Stefano Stabellini 2019-06-18 11:09 ` Julien Grall 2019-06-18 11:15 ` Julien Grall 2019-06-18 22:07 ` Stefano Stabellini 2019-06-18 22:20 ` Julien Grall 2019-06-18 22:46 ` Stefano Stabellini 2019-04-30 21:02 ` [PATCH v2 06/10] xen/arm: extend device_tree_for_each_node Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-07 17:12 ` Julien Grall 2019-05-07 17:12 ` [Xen-devel] " Julien Grall 2019-04-30 21:02 ` [PATCH v2 07/10] xen/arm: make process_memory_node a device_tree_node_func Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-01 9:47 ` Julien Grall 2019-05-01 9:47 ` [Xen-devel] " Julien Grall 2019-04-30 21:02 ` [PATCH v2 08/10] xen/arm: keep track of reserved-memory regions Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-01 10:03 ` Julien Grall 2019-05-01 10:03 ` [Xen-devel] " Julien Grall 2019-06-21 23:47 ` Stefano Stabellini 2019-05-07 17:21 ` Julien Grall 2019-05-07 17:21 ` [Xen-devel] " Julien Grall 2019-04-30 21:02 ` [PATCH v2 09/10] xen/arm: map reserved-memory regions as normal memory in dom0 Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-07 19:52 ` Julien Grall 2019-05-07 19:52 ` [Xen-devel] " Julien Grall 2019-04-30 21:02 ` [PATCH v2 10/10] xen/arm: add reserved-memory regions to the dom0 memory node Stefano Stabellini 2019-04-30 21:02 ` [Xen-devel] " Stefano Stabellini 2019-05-07 20:15 ` Julien Grall 2019-05-07 20:15 ` [Xen-devel] " Julien Grall 2019-05-10 20:51 ` Stefano Stabellini 2019-05-10 20:51 ` [Xen-devel] " Stefano Stabellini 2019-05-10 21:43 ` Julien Grall 2019-05-10 21:43 ` [Xen-devel] " Julien Grall 2019-05-11 12:40 ` Julien Grall 2019-05-11 12:40 ` [Xen-devel] " Julien Grall 2019-05-20 21:26 ` Stefano Stabellini 2019-05-20 21:26 ` [Xen-devel] " Stefano Stabellini 2019-05-20 22:38 ` Julien Grall 2019-05-20 22:38 ` [Xen-devel] " Julien Grall 2019-06-05 16:30 ` Julien Grall 2019-06-21 23:47 ` Stefano Stabellini 2019-05-16 16:52 ` [PATCH v2 0/10] iomem memory policy Oleksandr 2019-05-16 16:52 ` [Xen-devel] " Oleksandr 2019-06-21 23:48 ` Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5CCB05C6020000780022B567@prv1-mh.provo.novell.com \ --to=jbeulich@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=julien.grall@arm.com \ --cc=sstabellini@kernel.org \ --cc=stefanos@xilinx.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).