From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>, Frank Chang <frank.chang@sifive.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Alistair Francis <Alistair.Francis@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com>, Kito Cheng <kito.cheng@sifive.com> Subject: [RFC 10/15] target/riscv: rvb: rotate (left/right) Date: Wed, 18 Nov 2020 16:29:48 +0800 [thread overview] Message-ID: <20201118083044.13992-11-frank.chang@sifive.com> (raw) In-Reply-To: <20201118083044.13992-1-frank.chang@sifive.com> From: Kito Cheng <kito.cheng@sifive.com> Signed-off-by: Kito Cheng <kito.cheng@sifive.com> Signed-off-by: Frank Chang <frank.chang@sifive.com> --- target/riscv/insn32-64.decode | 3 ++ target/riscv/insn32.decode | 3 ++ target/riscv/insn_trans/trans_rvb.c.inc | 54 +++++++++++++++++++++++++ target/riscv/translate.c | 48 ++++++++++++++++++++++ 4 files changed, 108 insertions(+) diff --git a/target/riscv/insn32-64.decode b/target/riscv/insn32-64.decode index cc6b7d63774..a1a4b12f7ca 100644 --- a/target/riscv/insn32-64.decode +++ b/target/riscv/insn32-64.decode @@ -100,9 +100,12 @@ sbinvw 0110100 .......... 001 ..... 0111011 @r sbextw 0100100 .......... 101 ..... 0111011 @r slow 0010000 .......... 001 ..... 0111011 @r srow 0010000 .......... 101 ..... 0111011 @r +rorw 0110000 .......... 101 ..... 0111011 @r +rolw 0110000 .......... 001 ..... 0111011 @r sbsetiw 0010100 .......... 001 ..... 0011011 @sh5 sbclriw 0100100 .......... 001 ..... 0011011 @sh5 sbinviw 0110100 .......... 001 ..... 0011011 @sh5 sloiw 0010000 .......... 001 ..... 0011011 @sh5 sroiw 0010000 .......... 101 ..... 0011011 @sh5 +roriw 0110000 .......... 101 ..... 0011011 @sh5 diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 6e3eef84144..01b8ebc4bee 100644 --- a/target/riscv/insn32.decode +++ b/target/riscv/insn32.decode @@ -617,6 +617,8 @@ sbinv 0110100 .......... 001 ..... 0110011 @r sbext 0100100 .......... 101 ..... 0110011 @r slo 0010000 .......... 001 ..... 0110011 @r sro 0010000 .......... 101 ..... 0110011 @r +ror 0110000 .......... 101 ..... 0110011 @r +rol 0110000 .......... 001 ..... 0110011 @r sbseti 001010 ........... 001 ..... 0010011 @sh sbclri 010010 ........... 001 ..... 0010011 @sh @@ -624,3 +626,4 @@ sbinvi 011010 ........... 001 ..... 0010011 @sh sbexti 010010 ........... 101 ..... 0010011 @sh sloi 001000 ........... 001 ..... 0010011 @sh sroi 001000 ........... 101 ..... 0010011 @sh +rori 011000 ........... 101 ..... 0010011 @sh diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc index 4c93c5aab8b..ba8734203ac 100644 --- a/target/riscv/insn_trans/trans_rvb.c.inc +++ b/target/riscv/insn_trans/trans_rvb.c.inc @@ -189,7 +189,29 @@ static bool trans_sroi(DisasContext *ctx, arg_sroi *a) return gen_arith_shamt_tl(ctx, a, &gen_sro); } +static bool trans_ror(DisasContext *ctx, arg_ror *a) { + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &tcg_gen_rotr_tl); +} + +static bool trans_rori(DisasContext *ctx, arg_rori *a) +{ + REQUIRE_EXT(ctx, RVB); + + if (a->shamt >= TARGET_LONG_BITS) { + return false; + } + + return gen_arith_shamt_tl(ctx, a, &tcg_gen_rotr_tl); +} + +static bool trans_rol(DisasContext *ctx, arg_rol *a) +{ + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &tcg_gen_rotl_tl); +} + /* RV64-only instructions */ #ifdef TARGET_RISCV64 @@ -289,4 +311,36 @@ static bool trans_sroiw(DisasContext *ctx, arg_sroiw *a) return gen_arith_shamt_tl(ctx, a, &gen_srow); } +static bool trans_rorw(DisasContext *ctx, arg_rorw *a) +{ + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &gen_rorw); +} + +static bool trans_roriw(DisasContext *ctx, arg_roriw *a) +{ + REQUIRE_EXT(ctx, RVB); + + if (a->shamt >= 32) { + return false; + } + + if (a->shamt == 0) { + TCGv t = tcg_temp_new(); + gen_get_gpr(t, a->rs1); + tcg_gen_ext32s_tl(t, t); + gen_set_gpr(a->rd, t); + tcg_temp_free(t); + return true; + } + + return gen_arith_shamt_tl(ctx, a, &gen_rorw); +} + +static bool trans_rolw(DisasContext *ctx, arg_rolw *a) +{ + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &gen_rolw); +} + #endif diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 8972e247bd7..68870bd9202 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1092,6 +1092,54 @@ static void gen_srow(TCGv ret, TCGv arg1, TCGv arg2) tcg_temp_free(t); } +static void gen_rorw(TCGv ret, TCGv arg1, TCGv arg2) +{ + TCGv shamt; + TCGv_i32 t1, t2; + shamt = tcg_temp_new(); + t1 = tcg_temp_new_i32(); + t2 = tcg_temp_new_i32(); + + gen_sbopw_shamt(shamt, arg2); + + /* truncate to 32-bits */ + tcg_gen_trunc_tl_i32(t1, arg1); + tcg_gen_trunc_tl_i32(t2, shamt); + + tcg_gen_rotr_i32(t1, t1, t2); + + /* sign-extend 64-bits */ + tcg_gen_ext_i32_tl(ret, t1); + + tcg_temp_free(shamt); + tcg_temp_free_i32(t1); + tcg_temp_free_i32(t2); +} + +static void gen_rolw(TCGv ret, TCGv arg1, TCGv arg2) +{ + TCGv shamt; + TCGv_i32 t1, t2; + shamt = tcg_temp_new(); + t1 = tcg_temp_new_i32(); + t2 = tcg_temp_new_i32(); + + gen_sbopw_shamt(shamt, arg2); + + /* truncate to 32-bits */ + tcg_gen_trunc_tl_i32(t1, arg1); + tcg_gen_trunc_tl_i32(t2, shamt); + + tcg_gen_rotl_i32(t1, t1, t2); + + /* sign-extend 64-bits */ + tcg_gen_ext_i32_tl(ret, t1); + + tcg_temp_free(shamt); + tcg_temp_free_i32(t1); + tcg_temp_free_i32(t2); +} + #endif static bool gen_arith(DisasContext *ctx, arg_r *a, -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Kito Cheng <kito.cheng@sifive.com>, Frank Chang <frank.chang@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <Alistair.Francis@wdc.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Subject: [RFC 10/15] target/riscv: rvb: rotate (left/right) Date: Wed, 18 Nov 2020 16:29:48 +0800 [thread overview] Message-ID: <20201118083044.13992-11-frank.chang@sifive.com> (raw) In-Reply-To: <20201118083044.13992-1-frank.chang@sifive.com> From: Kito Cheng <kito.cheng@sifive.com> Signed-off-by: Kito Cheng <kito.cheng@sifive.com> Signed-off-by: Frank Chang <frank.chang@sifive.com> --- target/riscv/insn32-64.decode | 3 ++ target/riscv/insn32.decode | 3 ++ target/riscv/insn_trans/trans_rvb.c.inc | 54 +++++++++++++++++++++++++ target/riscv/translate.c | 48 ++++++++++++++++++++++ 4 files changed, 108 insertions(+) diff --git a/target/riscv/insn32-64.decode b/target/riscv/insn32-64.decode index cc6b7d63774..a1a4b12f7ca 100644 --- a/target/riscv/insn32-64.decode +++ b/target/riscv/insn32-64.decode @@ -100,9 +100,12 @@ sbinvw 0110100 .......... 001 ..... 0111011 @r sbextw 0100100 .......... 101 ..... 0111011 @r slow 0010000 .......... 001 ..... 0111011 @r srow 0010000 .......... 101 ..... 0111011 @r +rorw 0110000 .......... 101 ..... 0111011 @r +rolw 0110000 .......... 001 ..... 0111011 @r sbsetiw 0010100 .......... 001 ..... 0011011 @sh5 sbclriw 0100100 .......... 001 ..... 0011011 @sh5 sbinviw 0110100 .......... 001 ..... 0011011 @sh5 sloiw 0010000 .......... 001 ..... 0011011 @sh5 sroiw 0010000 .......... 101 ..... 0011011 @sh5 +roriw 0110000 .......... 101 ..... 0011011 @sh5 diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 6e3eef84144..01b8ebc4bee 100644 --- a/target/riscv/insn32.decode +++ b/target/riscv/insn32.decode @@ -617,6 +617,8 @@ sbinv 0110100 .......... 001 ..... 0110011 @r sbext 0100100 .......... 101 ..... 0110011 @r slo 0010000 .......... 001 ..... 0110011 @r sro 0010000 .......... 101 ..... 0110011 @r +ror 0110000 .......... 101 ..... 0110011 @r +rol 0110000 .......... 001 ..... 0110011 @r sbseti 001010 ........... 001 ..... 0010011 @sh sbclri 010010 ........... 001 ..... 0010011 @sh @@ -624,3 +626,4 @@ sbinvi 011010 ........... 001 ..... 0010011 @sh sbexti 010010 ........... 101 ..... 0010011 @sh sloi 001000 ........... 001 ..... 0010011 @sh sroi 001000 ........... 101 ..... 0010011 @sh +rori 011000 ........... 101 ..... 0010011 @sh diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc index 4c93c5aab8b..ba8734203ac 100644 --- a/target/riscv/insn_trans/trans_rvb.c.inc +++ b/target/riscv/insn_trans/trans_rvb.c.inc @@ -189,7 +189,29 @@ static bool trans_sroi(DisasContext *ctx, arg_sroi *a) return gen_arith_shamt_tl(ctx, a, &gen_sro); } +static bool trans_ror(DisasContext *ctx, arg_ror *a) { + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &tcg_gen_rotr_tl); +} + +static bool trans_rori(DisasContext *ctx, arg_rori *a) +{ + REQUIRE_EXT(ctx, RVB); + + if (a->shamt >= TARGET_LONG_BITS) { + return false; + } + + return gen_arith_shamt_tl(ctx, a, &tcg_gen_rotr_tl); +} + +static bool trans_rol(DisasContext *ctx, arg_rol *a) +{ + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &tcg_gen_rotl_tl); +} + /* RV64-only instructions */ #ifdef TARGET_RISCV64 @@ -289,4 +311,36 @@ static bool trans_sroiw(DisasContext *ctx, arg_sroiw *a) return gen_arith_shamt_tl(ctx, a, &gen_srow); } +static bool trans_rorw(DisasContext *ctx, arg_rorw *a) +{ + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &gen_rorw); +} + +static bool trans_roriw(DisasContext *ctx, arg_roriw *a) +{ + REQUIRE_EXT(ctx, RVB); + + if (a->shamt >= 32) { + return false; + } + + if (a->shamt == 0) { + TCGv t = tcg_temp_new(); + gen_get_gpr(t, a->rs1); + tcg_gen_ext32s_tl(t, t); + gen_set_gpr(a->rd, t); + tcg_temp_free(t); + return true; + } + + return gen_arith_shamt_tl(ctx, a, &gen_rorw); +} + +static bool trans_rolw(DisasContext *ctx, arg_rolw *a) +{ + REQUIRE_EXT(ctx, RVB); + return gen_arith(ctx, a, &gen_rolw); +} + #endif diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 8972e247bd7..68870bd9202 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1092,6 +1092,54 @@ static void gen_srow(TCGv ret, TCGv arg1, TCGv arg2) tcg_temp_free(t); } +static void gen_rorw(TCGv ret, TCGv arg1, TCGv arg2) +{ + TCGv shamt; + TCGv_i32 t1, t2; + shamt = tcg_temp_new(); + t1 = tcg_temp_new_i32(); + t2 = tcg_temp_new_i32(); + + gen_sbopw_shamt(shamt, arg2); + + /* truncate to 32-bits */ + tcg_gen_trunc_tl_i32(t1, arg1); + tcg_gen_trunc_tl_i32(t2, shamt); + + tcg_gen_rotr_i32(t1, t1, t2); + + /* sign-extend 64-bits */ + tcg_gen_ext_i32_tl(ret, t1); + + tcg_temp_free(shamt); + tcg_temp_free_i32(t1); + tcg_temp_free_i32(t2); +} + +static void gen_rolw(TCGv ret, TCGv arg1, TCGv arg2) +{ + TCGv shamt; + TCGv_i32 t1, t2; + shamt = tcg_temp_new(); + t1 = tcg_temp_new_i32(); + t2 = tcg_temp_new_i32(); + + gen_sbopw_shamt(shamt, arg2); + + /* truncate to 32-bits */ + tcg_gen_trunc_tl_i32(t1, arg1); + tcg_gen_trunc_tl_i32(t2, shamt); + + tcg_gen_rotl_i32(t1, t1, t2); + + /* sign-extend 64-bits */ + tcg_gen_ext_i32_tl(ret, t1); + + tcg_temp_free(shamt); + tcg_temp_free_i32(t1); + tcg_temp_free_i32(t2); +} + #endif static bool gen_arith(DisasContext *ctx, arg_r *a, -- 2.17.1
next prev parent reply other threads:[~2020-11-18 8:39 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 8:29 [RFC 00/15] support subsets of bitmanip extension frank.chang 2020-11-18 8:29 ` [RFC 01/15] target/riscv: reformat @sh format encoding for B-extension frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:03 ` Richard Henderson 2020-11-19 19:03 ` Richard Henderson 2020-11-18 8:29 ` [RFC 02/15] target/riscv: rvb: count leading/trailing zeros frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:24 ` Richard Henderson 2020-11-19 19:24 ` Richard Henderson 2020-11-19 19:48 ` Richard Henderson 2020-11-19 19:48 ` Richard Henderson 2020-11-18 8:29 ` [RFC 03/15] target/riscv: rvb: count bits set frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:27 ` Richard Henderson 2020-11-19 19:27 ` Richard Henderson 2020-11-18 8:29 ` [RFC 04/15] target/riscv: rvb: logic-with-negate frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:28 ` Richard Henderson 2020-11-19 19:28 ` Richard Henderson 2020-11-18 8:29 ` [RFC 05/15] target/riscv: rvb: pack two words into one register frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:43 ` Richard Henderson 2020-11-19 19:43 ` Richard Henderson 2020-11-18 8:29 ` [RFC 06/15] target/riscv: rvb: min/max instructions frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:46 ` Richard Henderson 2020-11-19 19:46 ` Richard Henderson 2020-11-18 8:29 ` [RFC 07/15] target/riscv: rvb: sign-extend instructions frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 19:48 ` Richard Henderson 2020-11-19 19:48 ` Richard Henderson 2020-11-18 8:29 ` [RFC 08/15] target/riscv: rvb: single-bit instructions frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 20:05 ` Richard Henderson 2020-11-19 20:05 ` Richard Henderson 2020-11-19 20:35 ` Richard Henderson 2020-11-19 20:35 ` Richard Henderson 2020-11-19 21:04 ` Richard Henderson 2020-11-19 21:04 ` Richard Henderson 2020-12-04 17:10 ` Frank Chang 2020-12-04 17:10 ` Frank Chang 2020-11-18 8:29 ` [RFC 09/15] target/riscv: rvb: shift ones frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 20:54 ` Richard Henderson 2020-11-19 20:54 ` Richard Henderson 2020-11-18 8:29 ` frank.chang [this message] 2020-11-18 8:29 ` [RFC 10/15] target/riscv: rvb: rotate (left/right) frank.chang 2020-11-19 21:06 ` Richard Henderson 2020-11-19 21:06 ` Richard Henderson 2020-11-18 8:29 ` [RFC 11/15] target/riscv: rvb: generalized reverse frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 21:24 ` Richard Henderson 2020-11-19 21:24 ` Richard Henderson 2020-11-18 8:29 ` [RFC 12/15] target/riscv: rvb: generalized or-combine frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 21:28 ` Richard Henderson 2020-11-19 21:28 ` Richard Henderson 2020-11-18 8:29 ` [RFC 13/15] target/riscv: rvb: address calculation frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 21:38 ` Richard Henderson 2020-11-19 21:38 ` Richard Henderson 2020-11-18 8:29 ` [RFC 14/15] target/riscv: rvb: add/sub with postfix zero-extend frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 22:15 ` Richard Henderson 2020-11-19 22:15 ` Richard Henderson 2020-11-18 8:29 ` [RFC 15/15] target/riscv: rvb: support and turn on B-extension from command line frank.chang 2020-11-18 8:29 ` frank.chang 2020-11-19 18:54 ` Alistair Francis 2020-11-19 18:54 ` Alistair Francis 2020-11-20 3:02 ` Kito Cheng 2020-11-20 3:02 ` Kito Cheng 2020-11-20 16:24 ` Alistair Francis 2020-11-20 16:24 ` Alistair Francis 2020-11-23 1:22 ` Frank Chang 2020-11-23 1:22 ` Frank Chang 2020-11-19 22:26 ` [RFC 00/15] support subsets of bitmanip extension Richard Henderson 2020-11-20 1:45 ` Frank Chang 2020-11-20 1:45 ` Frank Chang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201118083044.13992-11-frank.chang@sifive.com \ --to=frank.chang@sifive.com \ --cc=Alistair.Francis@wdc.com \ --cc=kbastian@mail.uni-paderborn.de \ --cc=kito.cheng@sifive.com \ --cc=palmer@dabbelt.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=sagark@eecs.berkeley.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.