From: Serge Semin <fancer.lancer@gmail.com> To: "Larson, Bradley" <Bradley.Larson@amd.com> Cc: Brad Larson <brad@pensando.io>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "alcooperx@gmail.com" <alcooperx@gmail.com>, "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>, "arnd@arndb.de" <arnd@arndb.de>, "brijeshkumar.singh@amd.com" <brijeshkumar.singh@amd.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "gsomlo@gmail.com" <gsomlo@gmail.com>, "gerg@linux-m68k.org" <gerg@linux-m68k.org>, "krzk@kernel.org" <krzk@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "broonie@kernel.org" <broonie@kernel.org>, "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "piotrs@cadence.com" <piotrs@cadence.com>, "p.yadav@ti.com" <p.yadav@ti.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "samuel@sholland.org" <samuel@sholland.org>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "will@kernel.org" <will@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 04/17] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Date: Sun, 11 Sep 2022 21:34:15 +0300 [thread overview] Message-ID: <20220911183415.ufeasmm3uev7wqx4@mobilestation> (raw) In-Reply-To: <0c2ac76e-45ff-b5a1-f33a-177eea04c17d@amd.com> On Wed, Aug 31, 2022 at 06:28:46PM +0000, Larson, Bradley wrote: > On 8/21/22 10:49 AM, Serge Semin wrote: > > On Sat, Aug 20, 2022 at 12:57:37PM -0700, Brad Larson wrote: > >> From: Brad Larson <blarson@amd.com> > >> > >> The AMD Pensando Elba SoC has integrated the DW APB SPI Controller > >> > >> Signed-off-by: Brad Larson <blarson@amd.com> > >> --- > >> .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > >> index 37c3c272407d..403d6416f7ac 100644 > >> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > >> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > >> @@ -37,6 +37,15 @@ allOf: > >> else: > >> required: > >> - interrupts > >> + - if: > >> + properties: > >> + compatible: > >> + contains: > >> + enum: > >> + - amd,pensando-elba-spi > >> + then: > >> + required: > >> + - amd,pensando-elba-syscon > > Please add the "amd,pensando-elba-syscon" property definition as I > > asked here: > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20220704131810.kabkuy6e4qmhfm3n%40mobilestation%2F&data=05%7C01%7Cbradley.larson%40amd.com%7C1c4f822c81424048873508da839d90fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637967010019245894%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xl9OU9P9QK3wLHc25hQZK393ylULd41qc4HB2Zt%2F0BQ%3D&reserved=0 > > Proposing this addition: > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -148,6 +148,15 @@ properties: > of the designware controller, and the upper limit is also subject to > controller configuration. > > + amd,pensando-elba-syscon: > + $ref: "/schemas/types.yaml#/definitions/phandle-array" > + maxItems: 1 > + description: > + A phandle to syscon used to access the spi chip-select override > register. > + items: > + - items: > + - description: phandle to the syscon node > + No. What Krzysztof and I asked was to add the property definition into the allOf: [ if ..., ] statement. Please read more carefully my last comment: https://lore.kernel.org/lkml/20220704131810.kabkuy6e4qmhfm3n@mobilestation/ The definition is supposed to look like this: > + - if: > + properties: > + compatible: > + contains: > + const: amd,pensando-elba-spi > + then: + properties: + amd,pensando-elba-syscon + $ref: /schemas/types.yaml#/definitions/phandle + description: AMD Pensando Elba SoC system controller > + required: > + - amd,pensando-elba-syscon * Please also note that I've replaced "enum:" with "const:" in the if statement above. The difference with what you suggested is that my version is applicable for the Pensando ELBA SPI controller only, while your update will cause applying the "amd,pensando-elba-syscon" property constraints for all DW SSI controllers which isn't what we would want. -Sergey > patternProperties: > "^.*@[0-9a-f]+$": > type: object > > Regards, > Brad
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <fancer.lancer@gmail.com> To: "Larson, Bradley" <Bradley.Larson@amd.com> Cc: Brad Larson <brad@pensando.io>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "alcooperx@gmail.com" <alcooperx@gmail.com>, "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>, "arnd@arndb.de" <arnd@arndb.de>, "brijeshkumar.singh@amd.com" <brijeshkumar.singh@amd.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "gsomlo@gmail.com" <gsomlo@gmail.com>, "gerg@linux-m68k.org" <gerg@linux-m68k.org>, "krzk@kernel.org" <krzk@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "broonie@kernel.org" <broonie@kernel.org>, "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "piotrs@cadence.com" <piotrs@cadence.com>, "p.yadav@ti.com" <p.yadav@ti.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "samuel@sholland.org" <samuel@sholland.org>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "will@kernel.org" <will@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 04/17] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Date: Sun, 11 Sep 2022 21:34:15 +0300 [thread overview] Message-ID: <20220911183415.ufeasmm3uev7wqx4@mobilestation> (raw) In-Reply-To: <0c2ac76e-45ff-b5a1-f33a-177eea04c17d@amd.com> On Wed, Aug 31, 2022 at 06:28:46PM +0000, Larson, Bradley wrote: > On 8/21/22 10:49 AM, Serge Semin wrote: > > On Sat, Aug 20, 2022 at 12:57:37PM -0700, Brad Larson wrote: > >> From: Brad Larson <blarson@amd.com> > >> > >> The AMD Pensando Elba SoC has integrated the DW APB SPI Controller > >> > >> Signed-off-by: Brad Larson <blarson@amd.com> > >> --- > >> .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > >> index 37c3c272407d..403d6416f7ac 100644 > >> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > >> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > >> @@ -37,6 +37,15 @@ allOf: > >> else: > >> required: > >> - interrupts > >> + - if: > >> + properties: > >> + compatible: > >> + contains: > >> + enum: > >> + - amd,pensando-elba-spi > >> + then: > >> + required: > >> + - amd,pensando-elba-syscon > > Please add the "amd,pensando-elba-syscon" property definition as I > > asked here: > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20220704131810.kabkuy6e4qmhfm3n%40mobilestation%2F&data=05%7C01%7Cbradley.larson%40amd.com%7C1c4f822c81424048873508da839d90fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637967010019245894%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xl9OU9P9QK3wLHc25hQZK393ylULd41qc4HB2Zt%2F0BQ%3D&reserved=0 > > Proposing this addition: > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -148,6 +148,15 @@ properties: > of the designware controller, and the upper limit is also subject to > controller configuration. > > + amd,pensando-elba-syscon: > + $ref: "/schemas/types.yaml#/definitions/phandle-array" > + maxItems: 1 > + description: > + A phandle to syscon used to access the spi chip-select override > register. > + items: > + - items: > + - description: phandle to the syscon node > + No. What Krzysztof and I asked was to add the property definition into the allOf: [ if ..., ] statement. Please read more carefully my last comment: https://lore.kernel.org/lkml/20220704131810.kabkuy6e4qmhfm3n@mobilestation/ The definition is supposed to look like this: > + - if: > + properties: > + compatible: > + contains: > + const: amd,pensando-elba-spi > + then: + properties: + amd,pensando-elba-syscon + $ref: /schemas/types.yaml#/definitions/phandle + description: AMD Pensando Elba SoC system controller > + required: > + - amd,pensando-elba-syscon * Please also note that I've replaced "enum:" with "const:" in the if statement above. The difference with what you suggested is that my version is applicable for the Pensando ELBA SPI controller only, while your update will cause applying the "amd,pensando-elba-syscon" property constraints for all DW SSI controllers which isn't what we would want. -Sergey > patternProperties: > "^.*@[0-9a-f]+$": > type: object > > Regards, > Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-11 18:34 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-20 19:57 [PATCH v6 00/17] Support AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 01/17] dt-bindings: arm: add AMD Pensando boards Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:15 ` Krzysztof Kozlowski 2022-08-22 18:15 ` Krzysztof Kozlowski 2022-08-31 22:40 ` Larson, Bradley 2022-08-31 22:40 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 02/17] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 21:29 ` Rob Herring 2022-08-22 21:29 ` Rob Herring 2022-08-31 22:36 ` Larson, Bradley 2022-08-31 22:36 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 03/17] dt-bindings: spi: cdns: Add compatible for " Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:22 ` Krzysztof Kozlowski 2022-08-22 18:22 ` Krzysztof Kozlowski 2022-08-31 18:37 ` Larson, Bradley 2022-08-31 18:37 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 04/17] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 17:49 ` Serge Semin 2022-08-21 17:49 ` Serge Semin 2022-08-31 18:28 ` Larson, Bradley 2022-08-31 18:28 ` Larson, Bradley 2022-09-11 18:34 ` Serge Semin [this message] 2022-09-11 18:34 ` Serge Semin 2022-09-14 18:47 ` Larson, Bradley 2022-09-14 18:47 ` Larson, Bradley 2022-08-22 18:19 ` Krzysztof Kozlowski 2022-08-22 18:19 ` Krzysztof Kozlowski 2022-08-31 18:45 ` Larson, Bradley 2022-08-31 18:45 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 05/17] dt-bindings: mfd: syscon: Add amd,pensando-elba-syscon compatible Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:23 ` Krzysztof Kozlowski 2022-08-22 18:23 ` Krzysztof Kozlowski 2022-08-31 18:35 ` Larson, Bradley 2022-08-31 18:35 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 20:21 ` Rob Herring 2022-08-21 20:21 ` Rob Herring 2022-08-22 14:25 ` Rob Herring 2022-08-22 14:25 ` Rob Herring 2022-08-31 23:01 ` Larson, Bradley 2022-08-31 23:01 ` Larson, Bradley 2022-09-01 7:20 ` Krzysztof Kozlowski 2022-09-01 7:20 ` Krzysztof Kozlowski 2022-09-01 20:37 ` Larson, Bradley 2022-09-01 20:37 ` Larson, Bradley 2022-09-08 11:27 ` Krzysztof Kozlowski 2022-09-08 11:27 ` Krzysztof Kozlowski 2022-09-13 21:57 ` Larson, Bradley 2022-09-13 21:57 ` Larson, Bradley 2022-09-16 9:56 ` Krzysztof Kozlowski 2022-09-16 9:56 ` Krzysztof Kozlowski 2022-09-29 22:50 ` Larson, Bradley 2022-09-29 22:50 ` Larson, Bradley 2022-10-07 15:53 ` Krzysztof Kozlowski 2022-10-07 15:53 ` Krzysztof Kozlowski 2022-08-20 19:57 ` [PATCH v6 07/17] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 20:21 ` Rob Herring 2022-08-21 20:21 ` Rob Herring 2022-08-20 19:57 ` [PATCH v6 08/17] MAINTAINERS: Add entry for AMD PENSANDO Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 09/17] arm64: Add config for AMD Pensando SoC platforms Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 10/17] arm64: dts: Add AMD Pensando Elba SoC support Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-09-30 7:27 ` Krzysztof Kozlowski 2022-09-30 7:27 ` Krzysztof Kozlowski 2022-10-04 19:46 ` Larson, Bradley 2022-10-04 19:46 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 11/17] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 12/17] spi: dw: Add support " Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 18:18 ` Serge Semin 2022-08-21 18:18 ` Serge Semin 2022-08-31 18:04 ` Larson, Bradley 2022-08-31 18:04 ` Larson, Bradley 2022-09-11 18:20 ` Serge Semin 2022-09-11 18:20 ` Serge Semin 2022-09-14 17:03 ` Larson, Bradley 2022-09-14 17:03 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 13/17] mmc: sdhci-cadence: Enable device specific override of writel() Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 14/17] mfd: pensando-elbasr: Add AMD Pensando Elba System Resource chip Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 15/17] reset: elbasr: Add AMD Pensando Elba SR Reset Controller Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 7:04 ` Philipp Zabel 2022-08-22 7:04 ` Philipp Zabel 2022-08-20 19:57 ` [PATCH v6 16/17] mmc: sdhci-cadence: Add AMD Pensando Elba SoC support Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 17/17] mmc: sdhci-cadence: Support mmc hardware reset Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 7:03 ` Philipp Zabel 2022-08-22 7:03 ` Philipp Zabel 2022-08-31 22:49 ` Larson, Bradley 2022-08-31 22:49 ` Larson, Bradley 2022-08-22 10:53 ` Ulf Hansson 2022-08-22 10:53 ` Ulf Hansson 2022-08-22 12:25 ` Mark Brown 2022-08-22 12:25 ` Mark Brown 2022-08-31 23:29 ` Larson, Bradley 2022-08-31 23:29 ` Larson, Bradley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220911183415.ufeasmm3uev7wqx4@mobilestation \ --to=fancer.lancer@gmail.com \ --cc=Bradley.Larson@amd.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=Thomas.Lendacky@amd.com \ --cc=adrian.hunter@intel.com \ --cc=alcooperx@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=brad@pensando.io \ --cc=brijeshkumar.singh@amd.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=gerg@linux-m68k.org \ --cc=gsomlo@gmail.com \ --cc=krzk@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=p.yadav@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=piotrs@cadence.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=ulf.hansson@linaro.org \ --cc=will@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.