From: "Larson, Bradley" <Bradley.Larson@amd.com> To: Philipp Zabel <p.zabel@pengutronix.de>, Brad Larson <brad@pensando.io>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "alcooperx@gmail.com" <alcooperx@gmail.com>, "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>, "arnd@arndb.de" <arnd@arndb.de>, "brijeshkumar.singh@amd.com" <brijeshkumar.singh@amd.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "gsomlo@gmail.com" <gsomlo@gmail.com>, "gerg@linux-m68k.org" <gerg@linux-m68k.org>, "krzk@kernel.org" <krzk@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "broonie@kernel.org" <broonie@kernel.org>, "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>, "piotrs@cadence.com" <piotrs@cadence.com>, "p.yadav@ti.com" <p.yadav@ti.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "samuel@sholland.org" <samuel@sholland.org>, "fancer.lancer@gmail.com" <fancer.lancer@gmail.com>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "will@kernel.org" <will@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 17/17] mmc: sdhci-cadence: Support mmc hardware reset Date: Wed, 31 Aug 2022 22:49:19 +0000 [thread overview] Message-ID: <dcdc51bb-fc8d-04e5-2edb-903f7a531cb8@amd.com> (raw) In-Reply-To: <e4f16bcd11db29869c08f920d2bd9480fcdc076d.camel@pengutronix.de> On 8/22/22 12:03 AM, Philipp Zabel wrote: > Hi Brad, > > On Sa, 2022-08-20 at 12:57 -0700, Brad Larson wrote: > [...] >> +static void sdhci_mmc_hw_reset(struct mmc_host *mmc) >> +{ >> + struct sdhci_host *host = mmc_priv(mmc); >> + struct sdhci_cdns_priv *priv = sdhci_cdns_priv(host); >> + >> + dev_info(mmc_dev(host->mmc), "emmc hardware reset\n"); >> + >> + reset_control_assert(priv->rst_hw); >> + /* For eMMC, minimum is 1us but give it 9us for good measure */ >> + udelay(9); > At a glance, this seems excessive. Is there a reason 9 us is better > than, say, 2 or 3? Yes, 3x the minimum should be fine. Changed to 3 usec. > [...] >> @@ -520,6 +538,17 @@ static int sdhci_cdns_probe(struct platform_device *pdev) >> if (ret) >> goto free; >> >> >> >> >> + if (host->mmc->caps & MMC_CAP_HW_RESET) { >> + priv->rst_hw = devm_reset_control_get_optional_exclusive(dev, "hw"); > This should be described in cdns,sdhci.yaml first. Adding this to cdns,sdhci.yaml and running through schema checker. --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml @@ -114,6 +114,16 @@ properties: minimum: 0 maximum: 0x7f + reset-names: + items: + - const: hw + + resets: + description: + optional. phandle to the system reset controller with line index + for mmc hw reset line if exists. + maxItems: 1 + required: - compatible Regards, Brad
WARNING: multiple messages have this Message-ID (diff)
From: "Larson, Bradley" <Bradley.Larson@amd.com> To: Philipp Zabel <p.zabel@pengutronix.de>, Brad Larson <brad@pensando.io>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "alcooperx@gmail.com" <alcooperx@gmail.com>, "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>, "arnd@arndb.de" <arnd@arndb.de>, "brijeshkumar.singh@amd.com" <brijeshkumar.singh@amd.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "gsomlo@gmail.com" <gsomlo@gmail.com>, "gerg@linux-m68k.org" <gerg@linux-m68k.org>, "krzk@kernel.org" <krzk@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "broonie@kernel.org" <broonie@kernel.org>, "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>, "piotrs@cadence.com" <piotrs@cadence.com>, "p.yadav@ti.com" <p.yadav@ti.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "samuel@sholland.org" <samuel@sholland.org>, "fancer.lancer@gmail.com" <fancer.lancer@gmail.com>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "will@kernel.org" <will@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 17/17] mmc: sdhci-cadence: Support mmc hardware reset Date: Wed, 31 Aug 2022 22:49:19 +0000 [thread overview] Message-ID: <dcdc51bb-fc8d-04e5-2edb-903f7a531cb8@amd.com> (raw) In-Reply-To: <e4f16bcd11db29869c08f920d2bd9480fcdc076d.camel@pengutronix.de> On 8/22/22 12:03 AM, Philipp Zabel wrote: > Hi Brad, > > On Sa, 2022-08-20 at 12:57 -0700, Brad Larson wrote: > [...] >> +static void sdhci_mmc_hw_reset(struct mmc_host *mmc) >> +{ >> + struct sdhci_host *host = mmc_priv(mmc); >> + struct sdhci_cdns_priv *priv = sdhci_cdns_priv(host); >> + >> + dev_info(mmc_dev(host->mmc), "emmc hardware reset\n"); >> + >> + reset_control_assert(priv->rst_hw); >> + /* For eMMC, minimum is 1us but give it 9us for good measure */ >> + udelay(9); > At a glance, this seems excessive. Is there a reason 9 us is better > than, say, 2 or 3? Yes, 3x the minimum should be fine. Changed to 3 usec. > [...] >> @@ -520,6 +538,17 @@ static int sdhci_cdns_probe(struct platform_device *pdev) >> if (ret) >> goto free; >> >> >> >> >> + if (host->mmc->caps & MMC_CAP_HW_RESET) { >> + priv->rst_hw = devm_reset_control_get_optional_exclusive(dev, "hw"); > This should be described in cdns,sdhci.yaml first. Adding this to cdns,sdhci.yaml and running through schema checker. --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml @@ -114,6 +114,16 @@ properties: minimum: 0 maximum: 0x7f + reset-names: + items: + - const: hw + + resets: + description: + optional. phandle to the system reset controller with line index + for mmc hw reset line if exists. + maxItems: 1 + required: - compatible Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-31 22:49 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-20 19:57 [PATCH v6 00/17] Support AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 01/17] dt-bindings: arm: add AMD Pensando boards Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:15 ` Krzysztof Kozlowski 2022-08-22 18:15 ` Krzysztof Kozlowski 2022-08-31 22:40 ` Larson, Bradley 2022-08-31 22:40 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 02/17] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 21:29 ` Rob Herring 2022-08-22 21:29 ` Rob Herring 2022-08-31 22:36 ` Larson, Bradley 2022-08-31 22:36 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 03/17] dt-bindings: spi: cdns: Add compatible for " Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:22 ` Krzysztof Kozlowski 2022-08-22 18:22 ` Krzysztof Kozlowski 2022-08-31 18:37 ` Larson, Bradley 2022-08-31 18:37 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 04/17] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 17:49 ` Serge Semin 2022-08-21 17:49 ` Serge Semin 2022-08-31 18:28 ` Larson, Bradley 2022-08-31 18:28 ` Larson, Bradley 2022-09-11 18:34 ` Serge Semin 2022-09-11 18:34 ` Serge Semin 2022-09-14 18:47 ` Larson, Bradley 2022-09-14 18:47 ` Larson, Bradley 2022-08-22 18:19 ` Krzysztof Kozlowski 2022-08-22 18:19 ` Krzysztof Kozlowski 2022-08-31 18:45 ` Larson, Bradley 2022-08-31 18:45 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 05/17] dt-bindings: mfd: syscon: Add amd,pensando-elba-syscon compatible Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:23 ` Krzysztof Kozlowski 2022-08-22 18:23 ` Krzysztof Kozlowski 2022-08-31 18:35 ` Larson, Bradley 2022-08-31 18:35 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 20:21 ` Rob Herring 2022-08-21 20:21 ` Rob Herring 2022-08-22 14:25 ` Rob Herring 2022-08-22 14:25 ` Rob Herring 2022-08-31 23:01 ` Larson, Bradley 2022-08-31 23:01 ` Larson, Bradley 2022-09-01 7:20 ` Krzysztof Kozlowski 2022-09-01 7:20 ` Krzysztof Kozlowski 2022-09-01 20:37 ` Larson, Bradley 2022-09-01 20:37 ` Larson, Bradley 2022-09-08 11:27 ` Krzysztof Kozlowski 2022-09-08 11:27 ` Krzysztof Kozlowski 2022-09-13 21:57 ` Larson, Bradley 2022-09-13 21:57 ` Larson, Bradley 2022-09-16 9:56 ` Krzysztof Kozlowski 2022-09-16 9:56 ` Krzysztof Kozlowski 2022-09-29 22:50 ` Larson, Bradley 2022-09-29 22:50 ` Larson, Bradley 2022-10-07 15:53 ` Krzysztof Kozlowski 2022-10-07 15:53 ` Krzysztof Kozlowski 2022-08-20 19:57 ` [PATCH v6 07/17] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 20:21 ` Rob Herring 2022-08-21 20:21 ` Rob Herring 2022-08-20 19:57 ` [PATCH v6 08/17] MAINTAINERS: Add entry for AMD PENSANDO Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 09/17] arm64: Add config for AMD Pensando SoC platforms Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 10/17] arm64: dts: Add AMD Pensando Elba SoC support Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-09-30 7:27 ` Krzysztof Kozlowski 2022-09-30 7:27 ` Krzysztof Kozlowski 2022-10-04 19:46 ` Larson, Bradley 2022-10-04 19:46 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 11/17] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 12/17] spi: dw: Add support " Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 18:18 ` Serge Semin 2022-08-21 18:18 ` Serge Semin 2022-08-31 18:04 ` Larson, Bradley 2022-08-31 18:04 ` Larson, Bradley 2022-09-11 18:20 ` Serge Semin 2022-09-11 18:20 ` Serge Semin 2022-09-14 17:03 ` Larson, Bradley 2022-09-14 17:03 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 13/17] mmc: sdhci-cadence: Enable device specific override of writel() Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 14/17] mfd: pensando-elbasr: Add AMD Pensando Elba System Resource chip Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 15/17] reset: elbasr: Add AMD Pensando Elba SR Reset Controller Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 7:04 ` Philipp Zabel 2022-08-22 7:04 ` Philipp Zabel 2022-08-20 19:57 ` [PATCH v6 16/17] mmc: sdhci-cadence: Add AMD Pensando Elba SoC support Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 17/17] mmc: sdhci-cadence: Support mmc hardware reset Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 7:03 ` Philipp Zabel 2022-08-22 7:03 ` Philipp Zabel 2022-08-31 22:49 ` Larson, Bradley [this message] 2022-08-31 22:49 ` Larson, Bradley 2022-08-22 10:53 ` Ulf Hansson 2022-08-22 10:53 ` Ulf Hansson 2022-08-22 12:25 ` Mark Brown 2022-08-22 12:25 ` Mark Brown 2022-08-31 23:29 ` Larson, Bradley 2022-08-31 23:29 ` Larson, Bradley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dcdc51bb-fc8d-04e5-2edb-903f7a531cb8@amd.com \ --to=bradley.larson@amd.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=Thomas.Lendacky@amd.com \ --cc=adrian.hunter@intel.com \ --cc=alcooperx@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=brad@pensando.io \ --cc=brijeshkumar.singh@amd.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=fancer.lancer@gmail.com \ --cc=gerg@linux-m68k.org \ --cc=gsomlo@gmail.com \ --cc=krzk@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=p.yadav@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=piotrs@cadence.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=ulf.hansson@linaro.org \ --cc=will@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.