From: "Larson, Bradley" <Bradley.Larson@amd.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Larson, Bradley" <Bradley.Larson@amd.com>, Rob Herring <robh@kernel.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "alcooperx@gmail.com" <alcooperx@gmail.com>, "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>, "arnd@arndb.de" <arnd@arndb.de>, "brijeshkumar.singh@amd.com" <brijeshkumar.singh@amd.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "gsomlo@gmail.com" <gsomlo@gmail.com>, "gerg@linux-m68k.org" <gerg@linux-m68k.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "broonie@kernel.org" <broonie@kernel.org>, "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "piotrs@cadence.com" <piotrs@cadence.com>, "p.yadav@ti.com" <p.yadav@ti.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "samuel@sholland.org" <samuel@sholland.org>, "fancer.lancer@gmail.com" <fancer.lancer@gmail.com>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "will@kernel.org" <will@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Date: Thu, 29 Sep 2022 22:50:43 +0000 [thread overview] Message-ID: <8ce3ee59-bc37-ea97-c94d-b6f4f9c28751@amd.com> (raw) In-Reply-To: <9e006307-f7c7-c68a-e5c3-d0d0b2807d87@linaro.org> On 9/16/22 2:56 AM, Krzysztof Kozlowski wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On 13/09/2022 22:57, Larson, Bradley wrote: >> On 9/8/22 4:27 AM, Krzysztof Kozlowski wrote: >>> On 01/09/2022 22:37, Larson, Bradley wrote: >>>> On 9/1/22 12:20 AM, Krzysztof Kozlowski wrote: >>>>> On 01/09/2022 02:01, Larson, Bradley wrote: >>>>> > Wait, can we skip the driver entirely? I am not reviewing your driver > and what it creates under /dev. Yes, see precise answer requested below. >> In comparision, the pensando device is also on the other end of spi, >> four chip selects with /dev created for each for userspace control, >> and one child device on cs0 for hw reset emmc that the Linux block >> layer controls (single bit managed only by kernel). >> >> Pensando: >> &spi0 { >> num-cs = <4>; >> cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, >> <&porta 7 GPIO_ACTIVE_LOW>; >> status = "okay"; >> system-controller@0 { >> compatible = "amd,pensando-elbasr"; >> reg = <0>; >> #address-cells = <1>; >> #size-cells = <0>; >> spi-max-frequency = <12000000>; >> >> rstc: reset-controller { >> compatible = "amd,pensando-elbasr-reset"; >> #reset-cells = <1>; >> }; >> }; >> >> system-controller@1 { >> compatible = "amd,pensando-elbasr"; >> reg = <1>; >> spi-max-frequency = <12000000>; >> }; >> >> system-controller@2 { >> compatible = "amd,pensando-elbasr"; >> reg = <2>; >> spi-max-frequency = <12000000>; >> interrupt-parent = <&porta>; >> interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> }; >> >> system-controller@3 { >> compatible = "amd,pensando-elbasr"; >> reg = <3>; >> spi-max-frequency = <12000000>; >> }; >> }; > You replied with quite a response of which 90% is unrelated talk about > driver. Please be specific. We talk here only about hardware. > Your last DTS might be the answer, but you never explicitly wrote > it... So let's check if I understand it correctly. Only some of elbasr > block contain reset control? Yes, only the elbasr block accessed on CS0 provides reset control. The other 3 blocks don't have any reset control and never will. > This however does not answer my questions before.... You keep ignoring > them. So please answer yes or no: "Are there other sub-devices?" No > " and your binding is incomplete?" No > and a new question: "Is reset block (amd,pensando-elbasr-reset) > re-usable so it will appear in different device (not in > amd,pensando-elbasr)?" No its not re-usable Regards, Brad
WARNING: multiple messages have this Message-ID (diff)
From: "Larson, Bradley" <Bradley.Larson@amd.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Larson, Bradley" <Bradley.Larson@amd.com>, Rob Herring <robh@kernel.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "alcooperx@gmail.com" <alcooperx@gmail.com>, "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>, "arnd@arndb.de" <arnd@arndb.de>, "brijeshkumar.singh@amd.com" <brijeshkumar.singh@amd.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "gsomlo@gmail.com" <gsomlo@gmail.com>, "gerg@linux-m68k.org" <gerg@linux-m68k.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "broonie@kernel.org" <broonie@kernel.org>, "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "piotrs@cadence.com" <piotrs@cadence.com>, "p.yadav@ti.com" <p.yadav@ti.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "samuel@sholland.org" <samuel@sholland.org>, "fancer.lancer@gmail.com" <fancer.lancer@gmail.com>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>, "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "will@kernel.org" <will@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Date: Thu, 29 Sep 2022 22:50:43 +0000 [thread overview] Message-ID: <8ce3ee59-bc37-ea97-c94d-b6f4f9c28751@amd.com> (raw) In-Reply-To: <9e006307-f7c7-c68a-e5c3-d0d0b2807d87@linaro.org> On 9/16/22 2:56 AM, Krzysztof Kozlowski wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On 13/09/2022 22:57, Larson, Bradley wrote: >> On 9/8/22 4:27 AM, Krzysztof Kozlowski wrote: >>> On 01/09/2022 22:37, Larson, Bradley wrote: >>>> On 9/1/22 12:20 AM, Krzysztof Kozlowski wrote: >>>>> On 01/09/2022 02:01, Larson, Bradley wrote: >>>>> > Wait, can we skip the driver entirely? I am not reviewing your driver > and what it creates under /dev. Yes, see precise answer requested below. >> In comparision, the pensando device is also on the other end of spi, >> four chip selects with /dev created for each for userspace control, >> and one child device on cs0 for hw reset emmc that the Linux block >> layer controls (single bit managed only by kernel). >> >> Pensando: >> &spi0 { >> num-cs = <4>; >> cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, >> <&porta 7 GPIO_ACTIVE_LOW>; >> status = "okay"; >> system-controller@0 { >> compatible = "amd,pensando-elbasr"; >> reg = <0>; >> #address-cells = <1>; >> #size-cells = <0>; >> spi-max-frequency = <12000000>; >> >> rstc: reset-controller { >> compatible = "amd,pensando-elbasr-reset"; >> #reset-cells = <1>; >> }; >> }; >> >> system-controller@1 { >> compatible = "amd,pensando-elbasr"; >> reg = <1>; >> spi-max-frequency = <12000000>; >> }; >> >> system-controller@2 { >> compatible = "amd,pensando-elbasr"; >> reg = <2>; >> spi-max-frequency = <12000000>; >> interrupt-parent = <&porta>; >> interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> }; >> >> system-controller@3 { >> compatible = "amd,pensando-elbasr"; >> reg = <3>; >> spi-max-frequency = <12000000>; >> }; >> }; > You replied with quite a response of which 90% is unrelated talk about > driver. Please be specific. We talk here only about hardware. > Your last DTS might be the answer, but you never explicitly wrote > it... So let's check if I understand it correctly. Only some of elbasr > block contain reset control? Yes, only the elbasr block accessed on CS0 provides reset control. The other 3 blocks don't have any reset control and never will. > This however does not answer my questions before.... You keep ignoring > them. So please answer yes or no: "Are there other sub-devices?" No > " and your binding is incomplete?" No > and a new question: "Is reset block (amd,pensando-elbasr-reset) > re-usable so it will appear in different device (not in > amd,pensando-elbasr)?" No its not re-usable Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-29 22:50 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-20 19:57 [PATCH v6 00/17] Support AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 01/17] dt-bindings: arm: add AMD Pensando boards Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:15 ` Krzysztof Kozlowski 2022-08-22 18:15 ` Krzysztof Kozlowski 2022-08-31 22:40 ` Larson, Bradley 2022-08-31 22:40 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 02/17] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 21:29 ` Rob Herring 2022-08-22 21:29 ` Rob Herring 2022-08-31 22:36 ` Larson, Bradley 2022-08-31 22:36 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 03/17] dt-bindings: spi: cdns: Add compatible for " Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:22 ` Krzysztof Kozlowski 2022-08-22 18:22 ` Krzysztof Kozlowski 2022-08-31 18:37 ` Larson, Bradley 2022-08-31 18:37 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 04/17] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 17:49 ` Serge Semin 2022-08-21 17:49 ` Serge Semin 2022-08-31 18:28 ` Larson, Bradley 2022-08-31 18:28 ` Larson, Bradley 2022-09-11 18:34 ` Serge Semin 2022-09-11 18:34 ` Serge Semin 2022-09-14 18:47 ` Larson, Bradley 2022-09-14 18:47 ` Larson, Bradley 2022-08-22 18:19 ` Krzysztof Kozlowski 2022-08-22 18:19 ` Krzysztof Kozlowski 2022-08-31 18:45 ` Larson, Bradley 2022-08-31 18:45 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 05/17] dt-bindings: mfd: syscon: Add amd,pensando-elba-syscon compatible Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 18:23 ` Krzysztof Kozlowski 2022-08-22 18:23 ` Krzysztof Kozlowski 2022-08-31 18:35 ` Larson, Bradley 2022-08-31 18:35 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 20:21 ` Rob Herring 2022-08-21 20:21 ` Rob Herring 2022-08-22 14:25 ` Rob Herring 2022-08-22 14:25 ` Rob Herring 2022-08-31 23:01 ` Larson, Bradley 2022-08-31 23:01 ` Larson, Bradley 2022-09-01 7:20 ` Krzysztof Kozlowski 2022-09-01 7:20 ` Krzysztof Kozlowski 2022-09-01 20:37 ` Larson, Bradley 2022-09-01 20:37 ` Larson, Bradley 2022-09-08 11:27 ` Krzysztof Kozlowski 2022-09-08 11:27 ` Krzysztof Kozlowski 2022-09-13 21:57 ` Larson, Bradley 2022-09-13 21:57 ` Larson, Bradley 2022-09-16 9:56 ` Krzysztof Kozlowski 2022-09-16 9:56 ` Krzysztof Kozlowski 2022-09-29 22:50 ` Larson, Bradley [this message] 2022-09-29 22:50 ` Larson, Bradley 2022-10-07 15:53 ` Krzysztof Kozlowski 2022-10-07 15:53 ` Krzysztof Kozlowski 2022-08-20 19:57 ` [PATCH v6 07/17] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 20:21 ` Rob Herring 2022-08-21 20:21 ` Rob Herring 2022-08-20 19:57 ` [PATCH v6 08/17] MAINTAINERS: Add entry for AMD PENSANDO Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 09/17] arm64: Add config for AMD Pensando SoC platforms Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 10/17] arm64: dts: Add AMD Pensando Elba SoC support Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-09-30 7:27 ` Krzysztof Kozlowski 2022-09-30 7:27 ` Krzysztof Kozlowski 2022-10-04 19:46 ` Larson, Bradley 2022-10-04 19:46 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 11/17] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 12/17] spi: dw: Add support " Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-21 18:18 ` Serge Semin 2022-08-21 18:18 ` Serge Semin 2022-08-31 18:04 ` Larson, Bradley 2022-08-31 18:04 ` Larson, Bradley 2022-09-11 18:20 ` Serge Semin 2022-09-11 18:20 ` Serge Semin 2022-09-14 17:03 ` Larson, Bradley 2022-09-14 17:03 ` Larson, Bradley 2022-08-20 19:57 ` [PATCH v6 13/17] mmc: sdhci-cadence: Enable device specific override of writel() Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 14/17] mfd: pensando-elbasr: Add AMD Pensando Elba System Resource chip Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 15/17] reset: elbasr: Add AMD Pensando Elba SR Reset Controller Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 7:04 ` Philipp Zabel 2022-08-22 7:04 ` Philipp Zabel 2022-08-20 19:57 ` [PATCH v6 16/17] mmc: sdhci-cadence: Add AMD Pensando Elba SoC support Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-20 19:57 ` [PATCH v6 17/17] mmc: sdhci-cadence: Support mmc hardware reset Brad Larson 2022-08-20 19:57 ` Brad Larson 2022-08-22 7:03 ` Philipp Zabel 2022-08-22 7:03 ` Philipp Zabel 2022-08-31 22:49 ` Larson, Bradley 2022-08-31 22:49 ` Larson, Bradley 2022-08-22 10:53 ` Ulf Hansson 2022-08-22 10:53 ` Ulf Hansson 2022-08-22 12:25 ` Mark Brown 2022-08-22 12:25 ` Mark Brown 2022-08-31 23:29 ` Larson, Bradley 2022-08-31 23:29 ` Larson, Bradley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8ce3ee59-bc37-ea97-c94d-b6f4f9c28751@amd.com \ --to=bradley.larson@amd.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=Thomas.Lendacky@amd.com \ --cc=adrian.hunter@intel.com \ --cc=alcooperx@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=brijeshkumar.singh@amd.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=fancer.lancer@gmail.com \ --cc=gerg@linux-m68k.org \ --cc=gsomlo@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=p.yadav@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=piotrs@cadence.com \ --cc=rdunlap@infradead.org \ --cc=robh@kernel.org \ --cc=samuel@sholland.org \ --cc=ulf.hansson@linaro.org \ --cc=will@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.