From: Stefan Wahren <stefan.wahren@i2se.com> To: Baruch Siach <baruch@tkos.co.il> Cc: linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson <dave.stevenson@raspberrypi.org>, devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Eric Anholt <eric@anholt.net> Subject: Re: [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Date: Tue, 2 Jan 2018 19:49:44 +0100 (CET) [thread overview] Message-ID: <2013811470.181895.1514918984637@email.1und1.de> (raw) In-Reply-To: <bcac00c71b29c359b59053a30d817a8f17d6731d.1514898134.git.baruch@tkos.co.il> Hi Baruch, additionally the my comments on Michael's patches in March 2017, some new below. > Baruch Siach <baruch@tkos.co.il> hat am 2. Januar 2018 um 14:19 geschrieben: > > > From: Dave Stevenson <dave.stevenson@raspberrypi.org> > > Pi3 and Compute Module 3 have a GPIO expander that the > VPU communicates with. > There is a mailbox service that now allows control of this > expander, so add a kernel driver that can make use of it. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > drivers/gpio/Kconfig | 7 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-bcm-exp.c | 254 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 262 insertions(+) > create mode 100644 drivers/gpio/gpio-bcm-exp.c > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index d6a8e851ad13..e2aab64ea772 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -128,6 +128,13 @@ config GPIO_AXP209 > help > Say yes to enable GPIO support for the AXP209 PMIC > > +config GPIO_BCM_EXP > + bool "Broadcom Exp GPIO" same as in the binding, i don't think this is specific to Broadcom. > + depends on OF_GPIO && RASPBERRYPI_FIRMWARE && (ARCH_BCM2835 || COMPILE_TEST) This is too long. Please split up. > + help > + Turn on GPIO support for Broadcom chips using the firmware mailbox > + to communicate with VideoCore on BCM283x chips. > + > config GPIO_BCM_KONA > bool "Broadcom Kona GPIO" > depends on OF_GPIO && (ARCH_BCM_MOBILE || COMPILE_TEST) > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile > index 4bc24febb889..c5f481b1d53c 100644 > --- a/drivers/gpio/Makefile > +++ b/drivers/gpio/Makefile > @@ -33,6 +33,7 @@ obj-$(CONFIG_GPIO_ARIZONA) += gpio-arizona.o > obj-$(CONFIG_GPIO_ATH79) += gpio-ath79.o > obj-$(CONFIG_GPIO_ASPEED) += gpio-aspeed.o > obj-$(CONFIG_GPIO_AXP209) += gpio-axp209.o > +obj-$(CONFIG_GPIO_BCM_EXP) += gpio-bcm-exp.o > obj-$(CONFIG_GPIO_BCM_KONA) += gpio-bcm-kona.o > obj-$(CONFIG_GPIO_BD9571MWV) += gpio-bd9571mwv.o > obj-$(CONFIG_GPIO_BRCMSTB) += gpio-brcmstb.o > diff --git a/drivers/gpio/gpio-bcm-exp.c b/drivers/gpio/gpio-bcm-exp.c > new file mode 100644 > index 000000000000..d68adafaee4a > --- /dev/null > +++ b/drivers/gpio/gpio-bcm-exp.c > @@ -0,0 +1,254 @@ > +/* > + * Broadcom expander GPIO driver > + * > + * Uses the firmware mailbox service to communicate with the > + * GPIO expander on the VPU. > + * > + * Copyright (C) 2017 Raspberry Pi Trading Ltd. > + * > + * Author: Dave Stevenson <dave.stevenson@raspberrypi.org> > + * Based on gpio-bcm-virt.c by Dom Cobley <popcornmix@gmail.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ SPDX identifier? > + > +#include <linux/err.h> > +#include <linux/gpio.h> > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/dma-mapping.h> > +#include <soc/bcm2835/raspberrypi-firmware.h> > + > +#define MODULE_NAME "brcmexp-gpio" > +#define NUM_GPIO 8 > + > +struct brcmexp_gpio { > + struct gpio_chip gc; > + struct device *dev; > + struct rpi_firmware *fw; > +}; > + > +struct gpio_set_config { > + u32 gpio, direction, polarity, term_en, term_pull_up, state; > +}; > + > +struct gpio_get_config { > + u32 gpio, direction, polarity, term_en, term_pull_up; > +}; > + > +struct gpio_get_set_state { > + u32 gpio, state; > +}; > + > +static int brcmexp_gpio_get_polarity(struct gpio_chip *gc, unsigned int off) > +{ > + struct brcmexp_gpio *gpio; > + struct gpio_get_config get; > + int ret; > + > + gpio = container_of(gc, struct brcmexp_gpio, gc); > + > + get.gpio = off + gpio->gc.base; /* GPIO to update */ Please don't misuse the gpiochip base to communicate with the firmware. AFAIK the gc.base should be -1 (dynamic), so better use a define for the base. > + > + ret = rpi_firmware_property(gpio->fw, RPI_FIRMWARE_GET_GPIO_CONFIG, > + &get, sizeof(get)); > + if (ret) { > + dev_err(gpio->dev, > + "Failed to get GPIO %u config (%d)\n", off, ret); > + return ret; > + } Shouldn't we also check the in-bound status at get.gpio? And in all the other gpio ops? > ... > + > +static int brcmexp_gpio_probe(struct platform_device *pdev) > +{ > + int err = 0; > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + struct device_node *fw_node; > + struct rpi_firmware *fw; > + struct brcmexp_gpio *ucb; > + > + fw_node = of_parse_phandle(np, "firmware", 0); > + if (!fw_node) { > + dev_err(dev, "Missing firmware node\n"); > + return -ENOENT; > + } > + > + fw = rpi_firmware_get(fw_node); > + if (!fw) > + return -EPROBE_DEFER; > + > + ucb = devm_kzalloc(dev, sizeof(*ucb), GFP_KERNEL); > + if (!ucb) > + return -EINVAL; > + > + ucb->fw = fw; > + ucb->dev = dev; > + ucb->gc.label = MODULE_NAME; > + ucb->gc.owner = THIS_MODULE; > + ucb->gc.of_node = np; > + ucb->gc.base = 128; As said above this should be -1 Stefan
WARNING: multiple messages have this Message-ID (diff)
From: stefan.wahren@i2se.com (Stefan Wahren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Date: Tue, 2 Jan 2018 19:49:44 +0100 (CET) [thread overview] Message-ID: <2013811470.181895.1514918984637@email.1und1.de> (raw) In-Reply-To: <bcac00c71b29c359b59053a30d817a8f17d6731d.1514898134.git.baruch@tkos.co.il> Hi Baruch, additionally the my comments on Michael's patches in March 2017, some new below. > Baruch Siach <baruch@tkos.co.il> hat am 2. Januar 2018 um 14:19 geschrieben: > > > From: Dave Stevenson <dave.stevenson@raspberrypi.org> > > Pi3 and Compute Module 3 have a GPIO expander that the > VPU communicates with. > There is a mailbox service that now allows control of this > expander, so add a kernel driver that can make use of it. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > drivers/gpio/Kconfig | 7 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-bcm-exp.c | 254 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 262 insertions(+) > create mode 100644 drivers/gpio/gpio-bcm-exp.c > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index d6a8e851ad13..e2aab64ea772 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -128,6 +128,13 @@ config GPIO_AXP209 > help > Say yes to enable GPIO support for the AXP209 PMIC > > +config GPIO_BCM_EXP > + bool "Broadcom Exp GPIO" same as in the binding, i don't think this is specific to Broadcom. > + depends on OF_GPIO && RASPBERRYPI_FIRMWARE && (ARCH_BCM2835 || COMPILE_TEST) This is too long. Please split up. > + help > + Turn on GPIO support for Broadcom chips using the firmware mailbox > + to communicate with VideoCore on BCM283x chips. > + > config GPIO_BCM_KONA > bool "Broadcom Kona GPIO" > depends on OF_GPIO && (ARCH_BCM_MOBILE || COMPILE_TEST) > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile > index 4bc24febb889..c5f481b1d53c 100644 > --- a/drivers/gpio/Makefile > +++ b/drivers/gpio/Makefile > @@ -33,6 +33,7 @@ obj-$(CONFIG_GPIO_ARIZONA) += gpio-arizona.o > obj-$(CONFIG_GPIO_ATH79) += gpio-ath79.o > obj-$(CONFIG_GPIO_ASPEED) += gpio-aspeed.o > obj-$(CONFIG_GPIO_AXP209) += gpio-axp209.o > +obj-$(CONFIG_GPIO_BCM_EXP) += gpio-bcm-exp.o > obj-$(CONFIG_GPIO_BCM_KONA) += gpio-bcm-kona.o > obj-$(CONFIG_GPIO_BD9571MWV) += gpio-bd9571mwv.o > obj-$(CONFIG_GPIO_BRCMSTB) += gpio-brcmstb.o > diff --git a/drivers/gpio/gpio-bcm-exp.c b/drivers/gpio/gpio-bcm-exp.c > new file mode 100644 > index 000000000000..d68adafaee4a > --- /dev/null > +++ b/drivers/gpio/gpio-bcm-exp.c > @@ -0,0 +1,254 @@ > +/* > + * Broadcom expander GPIO driver > + * > + * Uses the firmware mailbox service to communicate with the > + * GPIO expander on the VPU. > + * > + * Copyright (C) 2017 Raspberry Pi Trading Ltd. > + * > + * Author: Dave Stevenson <dave.stevenson@raspberrypi.org> > + * Based on gpio-bcm-virt.c by Dom Cobley <popcornmix@gmail.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ SPDX identifier? > + > +#include <linux/err.h> > +#include <linux/gpio.h> > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/dma-mapping.h> > +#include <soc/bcm2835/raspberrypi-firmware.h> > + > +#define MODULE_NAME "brcmexp-gpio" > +#define NUM_GPIO 8 > + > +struct brcmexp_gpio { > + struct gpio_chip gc; > + struct device *dev; > + struct rpi_firmware *fw; > +}; > + > +struct gpio_set_config { > + u32 gpio, direction, polarity, term_en, term_pull_up, state; > +}; > + > +struct gpio_get_config { > + u32 gpio, direction, polarity, term_en, term_pull_up; > +}; > + > +struct gpio_get_set_state { > + u32 gpio, state; > +}; > + > +static int brcmexp_gpio_get_polarity(struct gpio_chip *gc, unsigned int off) > +{ > + struct brcmexp_gpio *gpio; > + struct gpio_get_config get; > + int ret; > + > + gpio = container_of(gc, struct brcmexp_gpio, gc); > + > + get.gpio = off + gpio->gc.base; /* GPIO to update */ Please don't misuse the gpiochip base to communicate with the firmware. AFAIK the gc.base should be -1 (dynamic), so better use a define for the base. > + > + ret = rpi_firmware_property(gpio->fw, RPI_FIRMWARE_GET_GPIO_CONFIG, > + &get, sizeof(get)); > + if (ret) { > + dev_err(gpio->dev, > + "Failed to get GPIO %u config (%d)\n", off, ret); > + return ret; > + } Shouldn't we also check the in-bound status at get.gpio? And in all the other gpio ops? > ... > + > +static int brcmexp_gpio_probe(struct platform_device *pdev) > +{ > + int err = 0; > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + struct device_node *fw_node; > + struct rpi_firmware *fw; > + struct brcmexp_gpio *ucb; > + > + fw_node = of_parse_phandle(np, "firmware", 0); > + if (!fw_node) { > + dev_err(dev, "Missing firmware node\n"); > + return -ENOENT; > + } > + > + fw = rpi_firmware_get(fw_node); > + if (!fw) > + return -EPROBE_DEFER; > + > + ucb = devm_kzalloc(dev, sizeof(*ucb), GFP_KERNEL); > + if (!ucb) > + return -EINVAL; > + > + ucb->fw = fw; > + ucb->dev = dev; > + ucb->gc.label = MODULE_NAME; > + ucb->gc.owner = THIS_MODULE; > + ucb->gc.of_node = np; > + ucb->gc.base = 128; As said above this should be -1 Stefan
next prev parent reply other threads:[~2018-01-02 18:50 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-02 13:19 [PATCH 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 13:19 ` [PATCH 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 13:19 ` [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 18:26 ` Stefan Wahren 2018-01-02 18:26 ` Stefan Wahren [not found] ` <860502005.181510.1514917560724-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2018-01-04 19:35 ` Baruch Siach 2018-01-04 19:35 ` Baruch Siach 2018-01-02 13:19 ` [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 18:49 ` Stefan Wahren [this message] 2018-01-02 18:49 ` Stefan Wahren [not found] ` <2013811470.181895.1514918984637-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2018-01-09 13:41 ` Baruch Siach 2018-01-09 13:41 ` Baruch Siach 2018-01-09 20:15 ` Stefan Wahren 2018-01-09 20:15 ` Stefan Wahren 2018-01-03 10:08 ` Linus Walleij 2018-01-03 10:08 ` Linus Walleij 2018-01-10 3:45 ` Baruch Siach 2018-01-10 3:45 ` Baruch Siach 2018-01-11 9:39 ` Linus Walleij 2018-01-11 9:39 ` Linus Walleij [not found] ` <cover.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> 2018-01-02 13:19 ` [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach 2018-01-02 13:19 ` Baruch Siach [not found] ` <a29df633ee568e150c150debde66c0783a57c70a.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> 2018-01-02 19:03 ` Stefan Wahren 2018-01-02 19:03 ` Stefan Wahren [not found] ` <1524381852.182115.1514919793281-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2018-01-03 20:17 ` Stefan Wahren 2018-01-03 20:17 ` Stefan Wahren 2018-01-03 20:29 ` Phil Elwell 2018-01-03 20:29 ` Phil Elwell [not found] ` <3993684b-5b99-6c38-6247-999f7564762b-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org> 2018-01-04 3:06 ` Peter Robinson 2018-01-04 3:06 ` Peter Robinson 2018-01-02 18:05 ` [PATCH 0/4] gpio: driver for the RPi3 " Stefan Wahren 2018-01-02 18:05 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2013811470.181895.1514918984637@email.1und1.de \ --to=stefan.wahren@i2se.com \ --cc=baruch@tkos.co.il \ --cc=dave.stevenson@raspberrypi.org \ --cc=devicetree@vger.kernel.org \ --cc=eric@anholt.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.