From: Linus Walleij <linus.walleij@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
linux-gpio@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service
Date: Thu, 11 Jan 2018 10:39:32 +0100 [thread overview]
Message-ID: <CACRpkdZWF+8dX6eOHDO+qv=ubwqxTx4MJphoOCX4130eaEqGMA@mail.gmail.com> (raw)
In-Reply-To: <20180110034557.5sqpbsvt6ly6s2go@tarshish>
On Wed, Jan 10, 2018 at 4:45 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Linus,
>
> On Wed, Jan 03, 2018 at 11:08:15AM +0100, Linus Walleij wrote:
>> On Tue, Jan 2, 2018 at 2:19 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>> > +#include <linux/err.h>
>> > +#include <linux/gpio.h>
>>
>> Just use
>>
>> #include <linux/driver.h>
>
> You mean linux/gpio/driver.h, right?
Yes.
> I still need linux/gpio.h for GPIOF_DIR_*.
Don't use these, just use 0 and 1 open coded for the
moment (if you check my devel branch, the references to
these flags are gone).
We need to make new defines for the new API.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service
Date: Thu, 11 Jan 2018 10:39:32 +0100 [thread overview]
Message-ID: <CACRpkdZWF+8dX6eOHDO+qv=ubwqxTx4MJphoOCX4130eaEqGMA@mail.gmail.com> (raw)
In-Reply-To: <20180110034557.5sqpbsvt6ly6s2go@tarshish>
On Wed, Jan 10, 2018 at 4:45 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Linus,
>
> On Wed, Jan 03, 2018 at 11:08:15AM +0100, Linus Walleij wrote:
>> On Tue, Jan 2, 2018 at 2:19 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>> > +#include <linux/err.h>
>> > +#include <linux/gpio.h>
>>
>> Just use
>>
>> #include <linux/driver.h>
>
> You mean linux/gpio/driver.h, right?
Yes.
> I still need linux/gpio.h for GPIOF_DIR_*.
Don't use these, just use 0 and 1 open coded for the
moment (if you check my devel branch, the references to
these flags are gone).
We need to make new defines for the new API.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-01-11 9:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 13:19 [PATCH 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 18:26 ` Stefan Wahren
2018-01-02 18:26 ` Stefan Wahren
[not found] ` <860502005.181510.1514917560724-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-04 19:35 ` Baruch Siach
2018-01-04 19:35 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 18:49 ` Stefan Wahren
2018-01-02 18:49 ` Stefan Wahren
[not found] ` <2013811470.181895.1514918984637-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-09 13:41 ` Baruch Siach
2018-01-09 13:41 ` Baruch Siach
2018-01-09 20:15 ` Stefan Wahren
2018-01-09 20:15 ` Stefan Wahren
2018-01-03 10:08 ` Linus Walleij
2018-01-03 10:08 ` Linus Walleij
2018-01-10 3:45 ` Baruch Siach
2018-01-10 3:45 ` Baruch Siach
2018-01-11 9:39 ` Linus Walleij [this message]
2018-01-11 9:39 ` Linus Walleij
[not found] ` <cover.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-02 13:19 ` [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-02 13:19 ` Baruch Siach
[not found] ` <a29df633ee568e150c150debde66c0783a57c70a.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-02 19:03 ` Stefan Wahren
2018-01-02 19:03 ` Stefan Wahren
[not found] ` <1524381852.182115.1514919793281-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-03 20:17 ` Stefan Wahren
2018-01-03 20:17 ` Stefan Wahren
2018-01-03 20:29 ` Phil Elwell
2018-01-03 20:29 ` Phil Elwell
[not found] ` <3993684b-5b99-6c38-6247-999f7564762b-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2018-01-04 3:06 ` Peter Robinson
2018-01-04 3:06 ` Peter Robinson
2018-01-02 18:05 ` [PATCH 0/4] gpio: driver for the RPi3 " Stefan Wahren
2018-01-02 18:05 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZWF+8dX6eOHDO+qv=ubwqxTx4MJphoOCX4130eaEqGMA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=baruch@tkos.co.il \
--cc=dave.stevenson@raspberrypi.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.