From: Peter Robinson <pbrobinson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Phil Elwell <phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
Cc: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander
Date: Thu, 4 Jan 2018 03:06:47 +0000 [thread overview]
Message-ID: <CALeDE9M2-WXz-zp-7Sx0VbrG7aa16box9oOtRKONXsnokrZEUw@mail.gmail.com> (raw)
In-Reply-To: <3993684b-5b99-6c38-6247-999f7564762b-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
>>> Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> hat am 2. Januar 2018 um 20:03
>>> geschrieben:
>>>
>>>
>>> Hi Baruch,
>>>
>>>> Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> hat am 2. Januar 2018 um 14:19
>>>> geschrieben:
>>>
>>>
>>>> + expgpio: expgpio {
>>>> + compatible = "brcm,bcm2835-expgpio";
>>>> + gpio-controller;
>>>> + #gpio-cells = <2>;
>>>> + firmware = <&firmware>;
>>>
>>>
>>> Please add the gpio-line-names from Eric's patch [1].
>>>
>>> Thanks
>>> Stefan
>>>
>>> [1] - https://patchwork.kernel.org/patch/9339857/
>>>
>>
>> sorry i missed the fact that the same GPIO expander is on the CM3. So
>> please move the exgpio node to bcm2837.dtsi and only define the
>> gpio-line-names in this file.
>
>
> The GPIO expander is not a part of the BCM2837 SoC, and not all
> BCM2837-based Pis have a GPIO expander - see the Pi 2+.
There's two ways that's generally handled upstream, either just
duplicate across the two .dts files or to put it in a separate .dtsi
and include it in the relevant .dts files, see arch/arm/boot/dts/axp*
as relevant examples.
Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: pbrobinson@gmail.com (Peter Robinson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander
Date: Thu, 4 Jan 2018 03:06:47 +0000 [thread overview]
Message-ID: <CALeDE9M2-WXz-zp-7Sx0VbrG7aa16box9oOtRKONXsnokrZEUw@mail.gmail.com> (raw)
In-Reply-To: <3993684b-5b99-6c38-6247-999f7564762b@raspberrypi.org>
>>> Stefan Wahren <stefan.wahren@i2se.com> hat am 2. Januar 2018 um 20:03
>>> geschrieben:
>>>
>>>
>>> Hi Baruch,
>>>
>>>> Baruch Siach <baruch@tkos.co.il> hat am 2. Januar 2018 um 14:19
>>>> geschrieben:
>>>
>>>
>>>> + expgpio: expgpio {
>>>> + compatible = "brcm,bcm2835-expgpio";
>>>> + gpio-controller;
>>>> + #gpio-cells = <2>;
>>>> + firmware = <&firmware>;
>>>
>>>
>>> Please add the gpio-line-names from Eric's patch [1].
>>>
>>> Thanks
>>> Stefan
>>>
>>> [1] - https://patchwork.kernel.org/patch/9339857/
>>>
>>
>> sorry i missed the fact that the same GPIO expander is on the CM3. So
>> please move the exgpio node to bcm2837.dtsi and only define the
>> gpio-line-names in this file.
>
>
> The GPIO expander is not a part of the BCM2837 SoC, and not all
> BCM2837-based Pis have a GPIO expander - see the Pi 2+.
There's two ways that's generally handled upstream, either just
duplicate across the two .dts files or to put it in a separate .dtsi
and include it in the relevant .dts files, see arch/arm/boot/dts/axp*
as relevant examples.
Peter
next prev parent reply other threads:[~2018-01-04 3:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 13:19 [PATCH 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 18:26 ` Stefan Wahren
2018-01-02 18:26 ` Stefan Wahren
[not found] ` <860502005.181510.1514917560724-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-04 19:35 ` Baruch Siach
2018-01-04 19:35 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Baruch Siach
2018-01-02 13:19 ` Baruch Siach
2018-01-02 18:49 ` Stefan Wahren
2018-01-02 18:49 ` Stefan Wahren
[not found] ` <2013811470.181895.1514918984637-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-09 13:41 ` Baruch Siach
2018-01-09 13:41 ` Baruch Siach
2018-01-09 20:15 ` Stefan Wahren
2018-01-09 20:15 ` Stefan Wahren
2018-01-03 10:08 ` Linus Walleij
2018-01-03 10:08 ` Linus Walleij
2018-01-10 3:45 ` Baruch Siach
2018-01-10 3:45 ` Baruch Siach
2018-01-11 9:39 ` Linus Walleij
2018-01-11 9:39 ` Linus Walleij
[not found] ` <cover.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-02 13:19 ` [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-02 13:19 ` Baruch Siach
[not found] ` <a29df633ee568e150c150debde66c0783a57c70a.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-02 19:03 ` Stefan Wahren
2018-01-02 19:03 ` Stefan Wahren
[not found] ` <1524381852.182115.1514919793281-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-03 20:17 ` Stefan Wahren
2018-01-03 20:17 ` Stefan Wahren
2018-01-03 20:29 ` Phil Elwell
2018-01-03 20:29 ` Phil Elwell
[not found] ` <3993684b-5b99-6c38-6247-999f7564762b-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2018-01-04 3:06 ` Peter Robinson [this message]
2018-01-04 3:06 ` Peter Robinson
2018-01-02 18:05 ` [PATCH 0/4] gpio: driver for the RPi3 " Stefan Wahren
2018-01-02 18:05 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALeDE9M2-WXz-zp-7Sx0VbrG7aa16box9oOtRKONXsnokrZEUw@mail.gmail.com \
--to=pbrobinson-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org \
--cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.