From: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Stevenson <dave.stevenson-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Subject: Re: [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Date: Thu, 4 Jan 2018 21:35:35 +0200 [thread overview] Message-ID: <20180104193535.63jmkxjvo3mynzpc@tarshish> (raw) In-Reply-To: <860502005.181510.1514917560724-7tX72C7vayboQLBSYMtkGA@public.gmane.org> Hi Stefan, On Tue, Jan 02, 2018 at 07:26:00PM +0100, Stefan Wahren wrote: > > Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> hat am 2. Januar 2018 um 14:19 geschrieben: > > > > > > The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware over > > I2C. The firmware mailbox interface allows the ARM core to control the > > GPIO lines. > > > > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> > > --- > > .../bindings/gpio/brcm,bcm2835-expgpio.txt | 24 ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt > > > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt b/Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt > > new file mode 100644 > > index 000000000000..55257f31a9be > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt > > @@ -0,0 +1,24 @@ > > +Raspberry Pi GPIO expander > > + > > +The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware. The > > +firmware exposes a mailbox interface that allows the ARM core to control the > > +GPIO lines on the expander. > > + > > +Required properties: > > + > > +- compatible : Should be "brcm,bcm2835-expgpio" > > from my understand this driver is specific to the Raspberry Pi and it's > vendor is the Raspberry Pi Foundation. So i prefer Eric's suggestion of > "raspberrypi,firmware-gpio", which also applies to the filename. That was my inclination as well. But I thought that keeping DT compatibility with downstream is desirable. I'll change compatible/file/driver names to raspberry something. baruch > > +- gpio-controller : Marks the device node as a gpio controller > > +- #gpio-cells : Should be two. The first cell is the pin number, and > > + the second cell is used to specify the gpio polarity: > > + 0 = active high > > + 1 = active low > > +- firmware : Reference to the RPi firmware device node > > + > > +Example: > > + > > +expgpio: expgpio { > > + compatible = "brcm,bcm2835-expgpio"; > > + gpio-controller; > > + #gpio-cells = <2>; > > + firmware = <&firmware>; > > +}; -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.52.368.4656, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Date: Thu, 4 Jan 2018 21:35:35 +0200 [thread overview] Message-ID: <20180104193535.63jmkxjvo3mynzpc@tarshish> (raw) In-Reply-To: <860502005.181510.1514917560724@email.1und1.de> Hi Stefan, On Tue, Jan 02, 2018 at 07:26:00PM +0100, Stefan Wahren wrote: > > Baruch Siach <baruch@tkos.co.il> hat am 2. Januar 2018 um 14:19 geschrieben: > > > > > > The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware over > > I2C. The firmware mailbox interface allows the ARM core to control the > > GPIO lines. > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > --- > > .../bindings/gpio/brcm,bcm2835-expgpio.txt | 24 ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt > > > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt b/Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt > > new file mode 100644 > > index 000000000000..55257f31a9be > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/brcm,bcm2835-expgpio.txt > > @@ -0,0 +1,24 @@ > > +Raspberry Pi GPIO expander > > + > > +The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware. The > > +firmware exposes a mailbox interface that allows the ARM core to control the > > +GPIO lines on the expander. > > + > > +Required properties: > > + > > +- compatible : Should be "brcm,bcm2835-expgpio" > > from my understand this driver is specific to the Raspberry Pi and it's > vendor is the Raspberry Pi Foundation. So i prefer Eric's suggestion of > "raspberrypi,firmware-gpio", which also applies to the filename. That was my inclination as well. But I thought that keeping DT compatibility with downstream is desirable. I'll change compatible/file/driver names to raspberry something. baruch > > +- gpio-controller : Marks the device node as a gpio controller > > +- #gpio-cells : Should be two. The first cell is the pin number, and > > + the second cell is used to specify the gpio polarity: > > + 0 = active high > > + 1 = active low > > +- firmware : Reference to the RPi firmware device node > > + > > +Example: > > + > > +expgpio: expgpio { > > + compatible = "brcm,bcm2835-expgpio"; > > + gpio-controller; > > + #gpio-cells = <2>; > > + firmware = <&firmware>; > > +}; -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2018-01-04 19:35 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-02 13:19 [PATCH 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 13:19 ` [PATCH 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 13:19 ` [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 18:26 ` Stefan Wahren 2018-01-02 18:26 ` Stefan Wahren [not found] ` <860502005.181510.1514917560724-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2018-01-04 19:35 ` Baruch Siach [this message] 2018-01-04 19:35 ` Baruch Siach 2018-01-02 13:19 ` [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Baruch Siach 2018-01-02 13:19 ` Baruch Siach 2018-01-02 18:49 ` Stefan Wahren 2018-01-02 18:49 ` Stefan Wahren [not found] ` <2013811470.181895.1514918984637-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2018-01-09 13:41 ` Baruch Siach 2018-01-09 13:41 ` Baruch Siach 2018-01-09 20:15 ` Stefan Wahren 2018-01-09 20:15 ` Stefan Wahren 2018-01-03 10:08 ` Linus Walleij 2018-01-03 10:08 ` Linus Walleij 2018-01-10 3:45 ` Baruch Siach 2018-01-10 3:45 ` Baruch Siach 2018-01-11 9:39 ` Linus Walleij 2018-01-11 9:39 ` Linus Walleij [not found] ` <cover.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> 2018-01-02 13:19 ` [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach 2018-01-02 13:19 ` Baruch Siach [not found] ` <a29df633ee568e150c150debde66c0783a57c70a.1514898134.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> 2018-01-02 19:03 ` Stefan Wahren 2018-01-02 19:03 ` Stefan Wahren [not found] ` <1524381852.182115.1514919793281-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2018-01-03 20:17 ` Stefan Wahren 2018-01-03 20:17 ` Stefan Wahren 2018-01-03 20:29 ` Phil Elwell 2018-01-03 20:29 ` Phil Elwell [not found] ` <3993684b-5b99-6c38-6247-999f7564762b-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org> 2018-01-04 3:06 ` Peter Robinson 2018-01-04 3:06 ` Peter Robinson 2018-01-02 18:05 ` [PATCH 0/4] gpio: driver for the RPi3 " Stefan Wahren 2018-01-02 18:05 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180104193535.63jmkxjvo3mynzpc@tarshish \ --to=baruch-nswtu9s1w3p6gbpvegmw2w@public.gmane.org \ --cc=dave.stevenson-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.