From: Pavel Machek <pavel@ucw.cz>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Zhang Rui <rui.zhang@intel.com>,
pali.rohar@gmail.com, sre@kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
fabio.estevam@nxp.com
Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Tue, 24 Jan 2017 18:58:01 +0100 [thread overview]
Message-ID: <20170124175800.GA15070@amd> (raw)
In-Reply-To: <88c94ea6-abe2-0f20-337e-e9ee00c883d8@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
> >>Right.
> >>
> >>Before reverting, can you please try if this patch works or not?
> >
> >Not really. Revert now. Sorry.
> >
> >Are you sure? This does not look equivalent to me at all.
> >
> >"name" file handling moved from drivers to the core, which added some
> >crazy checks what name can contain. Even if this "works", what is the
> >expected effect on the "name" file?
> >
> The hwmon name attribute must not include '-', as documented in
> Documentation/hwmon/sysfs-interface. Is enforcing that 'crazy' ?
> Maybe in your world, but not in mine.
Well, lets revert the patch and then we can discuss what to do with
the "name" problem.
Unfortunately, code enforces different rules than documentation says,
and it is all visible to userspace.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Tue, 24 Jan 2017 18:58:01 +0100 [thread overview]
Message-ID: <20170124175800.GA15070@amd> (raw)
In-Reply-To: <88c94ea6-abe2-0f20-337e-e9ee00c883d8@roeck-us.net>
> >>Right.
> >>
> >>Before reverting, can you please try if this patch works or not?
> >
> >Not really. Revert now. Sorry.
> >
> >Are you sure? This does not look equivalent to me at all.
> >
> >"name" file handling moved from drivers to the core, which added some
> >crazy checks what name can contain. Even if this "works", what is the
> >expected effect on the "name" file?
> >
> The hwmon name attribute must not include '-', as documented in
> Documentation/hwmon/sysfs-interface. Is enforcing that 'crazy' ?
> Maybe in your world, but not in mine.
Well, lets revert the patch and then we can discuss what to do with
the "name" problem.
Unfortunately, code enforces different rules than documentation says,
and it is all visible to userspace.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170124/c7c57cea/attachment.sig>
next prev parent reply other threads:[~2017-01-24 17:58 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:40 v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Pavel Machek
2017-01-23 12:40 ` Pavel Machek
2017-01-23 12:42 ` Pali Rohár
2017-01-23 12:42 ` Pali Rohár
2017-01-23 14:20 ` Pavel Machek
2017-01-23 14:20 ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:31 ` Guenter Roeck
2017-01-23 14:31 ` Guenter Roeck
2017-01-23 14:40 ` Pavel Machek
2017-01-23 14:40 ` Pavel Machek
2017-01-23 17:10 ` Guenter Roeck
2017-01-23 17:10 ` Guenter Roeck
2017-01-23 23:26 ` Pavel Machek
2017-01-23 23:26 ` Pavel Machek
2017-01-23 23:49 ` Guenter Roeck
2017-01-23 23:49 ` Guenter Roeck
2017-01-24 7:06 ` Zhang Rui
2017-01-24 7:06 ` Zhang Rui
2017-01-24 7:37 ` Pavel Machek
2017-01-24 7:37 ` Pavel Machek
2017-01-24 14:18 ` Guenter Roeck
2017-01-24 14:18 ` Guenter Roeck
2017-01-24 17:58 ` Pavel Machek [this message]
2017-01-24 17:58 ` Pavel Machek
2017-01-24 18:45 ` Guenter Roeck
2017-01-24 18:45 ` Guenter Roeck
2017-01-24 22:46 ` Pavel Machek
2017-01-24 22:46 ` Pavel Machek
2017-01-24 23:07 ` Fabio Estevam
2017-01-24 23:07 ` Fabio Estevam
2017-01-25 5:29 ` Zhang Rui
2017-01-25 5:29 ` Zhang Rui
2017-01-25 10:17 ` Pavel Machek
2017-01-25 10:17 ` Pavel Machek
2017-01-25 11:12 ` Pavel Machek
2017-01-25 11:12 ` Pavel Machek
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 12:09 ` Pali Rohár
2017-01-25 12:09 ` Pali Rohár
2017-01-27 1:37 ` Zhang Rui
2017-01-27 1:37 ` Zhang Rui
2017-01-27 1:37 ` Zhang Rui
2017-01-27 2:03 ` Guenter Roeck
2017-01-27 2:03 ` Guenter Roeck
2017-01-27 3:39 ` Zhang Rui
2017-01-27 3:39 ` Zhang Rui
2017-01-27 3:39 ` Zhang Rui
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 11:16 ` Pavel Machek
2017-01-27 11:16 ` Pavel Machek
2017-01-27 14:13 ` Guenter Roeck
2017-01-27 14:13 ` Guenter Roeck
2017-01-27 19:06 ` Pavel Machek
2017-01-27 19:06 ` Pavel Machek
2017-01-27 19:06 ` Pavel Machek
2017-01-27 14:40 ` Zhang Rui
2017-01-27 14:40 ` Zhang Rui
2017-01-27 17:20 ` Guenter Roeck
2017-01-27 17:20 ` Guenter Roeck
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 8:35 ` Pali Rohár
2017-01-27 8:35 ` Pali Rohár
2017-01-27 11:09 ` Pavel Machek
2017-01-27 11:09 ` Pavel Machek
2017-01-27 11:09 ` Pavel Machek
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 19:02 ` Pavel Machek
2017-01-27 19:02 ` Pavel Machek
2017-01-27 19:02 ` Pavel Machek
2017-01-27 11:29 ` Pavel Machek
2017-01-27 11:29 ` Pavel Machek
2017-01-24 14:10 ` Guenter Roeck
2017-01-24 14:10 ` Guenter Roeck
2017-01-24 14:15 ` Pavel Machek
2017-01-24 14:15 ` Pavel Machek
2017-01-24 14:30 ` Guenter Roeck
2017-01-24 14:30 ` Guenter Roeck
2017-01-24 7:34 ` Pavel Machek
2017-01-24 7:34 ` Pavel Machek
2017-01-24 14:15 ` Guenter Roeck
2017-01-24 14:15 ` Guenter Roeck
2017-01-23 20:22 ` Pavel Machek
2017-01-23 20:22 ` Pavel Machek
2017-01-23 20:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124175800.GA15070@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=rui.zhang@intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.