From: Pavel Machek <pavel@ucw.cz>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Pali Rohár" <pali.rohar@gmail.com>,
sre@kernel.org, "kernel list" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
fabio.estevam@nxp.com
Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 20:29:09 +0100 [thread overview]
Message-ID: <20170127192909.GD20571@amd> (raw)
In-Reply-To: <1485528033.2469.61.camel@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]
Hi!
> > > > That sounds like fun. Changing bq27200-0 to bq27200_0 is
> > > > Forbidden by
> > > > the ABI Police, but taking the entire device away is ok.
> > > >
> > > No. IMO, it depends on if the interface is used or not.
> > > If hwmon I/F is used, we can not take it away, nor change its name.
> > Even if the use doesn't depend on that name ?
> >
> when I said "the interface is used", I mean the name string is used.
> > >
> > > If thermal zone I/F is used, we can not change it's 'type' name to
> > > be
> > > compatible with new hwmon API.
> > >
> > You mean you can not fix the name to be compatible with libsensors.
> >
>
> We can try to convert it to a libsensor-compatible string, either for
> hwmon only, or for both thermal and hwmon. But this is an ABI change,
> right?
> And my understanding about the ABI change is that, if no one cares
> about it, we're okay, or else, this is a regression, and we need to
> fall back to the previous ABI immediately. In order to change it in a
> long run, we need to make a note in Documentation/ABI/, and change it
> sometime in the future (a couple of release cycles or even more).
If no one cares, you can get away with the change. So I guess that's
what we should try. In -rc1. We should _not_ do "this changes in 2
years" dance, as that would increase chance for someone to use the old
name.
So I guess changing to libsensor-compatible name in v4.11-rc0 (maybe
with note in the ABI documenation) is the best plan. If someone
complains, we'll have to revert and think about something else.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Zhang Rui <rui.zhang@intel.com>
Cc: ivo.g.dimitrov.75@gmail.com, khilman@kernel.org,
tony@atomide.com, aaro.koskinen@iki.fi,
"kernel list" <linux-kernel@vger.kernel.org>,
sre@kernel.org, abcloriens@gmail.com,
"Guenter Roeck" <linux@roeck-us.net>,
"Pali Rohár" <pali.rohar@gmail.com>,
fabio.estevam@nxp.com, linux-omap@vger.kernel.org,
patrikbachan@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
serge@hallyn.com
Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 20:29:09 +0100 [thread overview]
Message-ID: <20170127192909.GD20571@amd> (raw)
In-Reply-To: <1485528033.2469.61.camel@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1749 bytes --]
Hi!
> > > > That sounds like fun. Changing bq27200-0 to bq27200_0 is
> > > > Forbidden by
> > > > the ABI Police, but taking the entire device away is ok.
> > > >
> > > No. IMO, it depends on if the interface is used or not.
> > > If hwmon I/F is used, we can not take it away, nor change its name.
> > Even if the use doesn't depend on that name ?
> >
> when I said "the interface is used", I mean the name string is used.
> > >
> > > If thermal zone I/F is used, we can not change it's 'type' name to
> > > be
> > > compatible with new hwmon API.
> > >
> > You mean you can not fix the name to be compatible with libsensors.
> >
>
> We can try to convert it to a libsensor-compatible string, either for
> hwmon only, or for both thermal and hwmon. But this is an ABI change,
> right?
> And my understanding about the ABI change is that, if no one cares
> about it, we're okay, or else, this is a regression, and we need to
> fall back to the previous ABI immediately. In order to change it in a
> long run, we need to make a note in Documentation/ABI/, and change it
> sometime in the future (a couple of release cycles or even more).
If no one cares, you can get away with the change. So I guess that's
what we should try. In -rc1. We should _not_ do "this changes in 2
years" dance, as that would increase chance for someone to use the old
name.
So I guess changing to libsensor-compatible name in v4.11-rc0 (maybe
with note in the ABI documenation) is the best plan. If someone
complains, we'll have to revert and think about something else.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 20:29:09 +0100 [thread overview]
Message-ID: <20170127192909.GD20571@amd> (raw)
In-Reply-To: <1485528033.2469.61.camel@intel.com>
Hi!
> > > > That sounds like fun. Changing bq27200-0 to bq27200_0 is
> > > > Forbidden by
> > > > the ABI Police, but taking the entire device away is ok.
> > > >
> > > No. IMO, it depends on if the interface is used or not.
> > > If hwmon I/F is used, we can not take it away, nor change its name.
> > Even if the use doesn't depend on that name ?
> >
> when I said "the interface is used", I mean the name string is used.
> > >
> > > If thermal zone I/F is used, we can not change it's 'type' name to
> > > be
> > > compatible with new hwmon API.
> > >
> > You mean you can not fix the name to be compatible with libsensors.
> >
>
> We can try to convert it to a libsensor-compatible string, either for
> hwmon only, or for both thermal and hwmon. But this is an ABI change,
> right?
> And my understanding about the ABI change is that, if no one cares
> about it, we're okay, or else, this is a regression, and we need to
> fall back to the previous ABI immediately. In order to change it in a
> long run, we need to make a note in Documentation/ABI/, and change it
> sometime in the future (a couple of release cycles or even more).
If no one cares, you can get away with the change. So I guess that's
what we should try. In -rc1. We should _not_ do "this changes in 2
years" dance, as that would increase chance for someone to use the old
name.
So I guess changing to libsensor-compatible name in v4.11-rc0 (maybe
with note in the ABI documenation) is the best plan. If someone
complains, we'll have to revert and think about something else.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170127/e9ed2a62/attachment-0001.sig>
next prev parent reply other threads:[~2017-01-27 19:30 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:40 v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Pavel Machek
2017-01-23 12:40 ` Pavel Machek
2017-01-23 12:42 ` Pali Rohár
2017-01-23 12:42 ` Pali Rohár
2017-01-23 14:20 ` Pavel Machek
2017-01-23 14:20 ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:31 ` Guenter Roeck
2017-01-23 14:31 ` Guenter Roeck
2017-01-23 14:40 ` Pavel Machek
2017-01-23 14:40 ` Pavel Machek
2017-01-23 17:10 ` Guenter Roeck
2017-01-23 17:10 ` Guenter Roeck
2017-01-23 23:26 ` Pavel Machek
2017-01-23 23:26 ` Pavel Machek
2017-01-23 23:49 ` Guenter Roeck
2017-01-23 23:49 ` Guenter Roeck
2017-01-24 7:06 ` Zhang Rui
2017-01-24 7:06 ` Zhang Rui
2017-01-24 7:37 ` Pavel Machek
2017-01-24 7:37 ` Pavel Machek
2017-01-24 14:18 ` Guenter Roeck
2017-01-24 14:18 ` Guenter Roeck
2017-01-24 17:58 ` Pavel Machek
2017-01-24 17:58 ` Pavel Machek
2017-01-24 18:45 ` Guenter Roeck
2017-01-24 18:45 ` Guenter Roeck
2017-01-24 22:46 ` Pavel Machek
2017-01-24 22:46 ` Pavel Machek
2017-01-24 23:07 ` Fabio Estevam
2017-01-24 23:07 ` Fabio Estevam
2017-01-25 5:29 ` Zhang Rui
2017-01-25 5:29 ` Zhang Rui
2017-01-25 10:17 ` Pavel Machek
2017-01-25 10:17 ` Pavel Machek
2017-01-25 11:12 ` Pavel Machek
2017-01-25 11:12 ` Pavel Machek
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 12:09 ` Pali Rohár
2017-01-25 12:09 ` Pali Rohár
2017-01-27 1:37 ` Zhang Rui
2017-01-27 1:37 ` Zhang Rui
2017-01-27 1:37 ` Zhang Rui
2017-01-27 2:03 ` Guenter Roeck
2017-01-27 2:03 ` Guenter Roeck
2017-01-27 3:39 ` Zhang Rui
2017-01-27 3:39 ` Zhang Rui
2017-01-27 3:39 ` Zhang Rui
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 11:16 ` Pavel Machek
2017-01-27 11:16 ` Pavel Machek
2017-01-27 14:13 ` Guenter Roeck
2017-01-27 14:13 ` Guenter Roeck
2017-01-27 19:06 ` Pavel Machek
2017-01-27 19:06 ` Pavel Machek
2017-01-27 19:06 ` Pavel Machek
2017-01-27 14:40 ` Zhang Rui
2017-01-27 14:40 ` Zhang Rui
2017-01-27 17:20 ` Guenter Roeck
2017-01-27 17:20 ` Guenter Roeck
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek [this message]
2017-01-27 19:29 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 8:35 ` Pali Rohár
2017-01-27 8:35 ` Pali Rohár
2017-01-27 11:09 ` Pavel Machek
2017-01-27 11:09 ` Pavel Machek
2017-01-27 11:09 ` Pavel Machek
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 19:02 ` Pavel Machek
2017-01-27 19:02 ` Pavel Machek
2017-01-27 19:02 ` Pavel Machek
2017-01-27 11:29 ` Pavel Machek
2017-01-27 11:29 ` Pavel Machek
2017-01-24 14:10 ` Guenter Roeck
2017-01-24 14:10 ` Guenter Roeck
2017-01-24 14:15 ` Pavel Machek
2017-01-24 14:15 ` Pavel Machek
2017-01-24 14:30 ` Guenter Roeck
2017-01-24 14:30 ` Guenter Roeck
2017-01-24 7:34 ` Pavel Machek
2017-01-24 7:34 ` Pavel Machek
2017-01-24 14:15 ` Guenter Roeck
2017-01-24 14:15 ` Guenter Roeck
2017-01-23 20:22 ` Pavel Machek
2017-01-23 20:22 ` Pavel Machek
2017-01-23 20:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127192909.GD20571@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=rui.zhang@intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.