From: Guenter Roeck <linux@roeck-us.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Zhang Rui" <rui.zhang@intel.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
sre@kernel.org, "kernel list" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
fabio.estevam@nxp.com
Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 06:13:43 -0800 [thread overview]
Message-ID: <37154fca-5cfd-7f65-0f9b-14b979a094e6@roeck-us.net> (raw)
In-Reply-To: <20170127111626.GB5335@amd>
On 01/27/2017 03:16 AM, Pavel Machek wrote:
> Hi!
>
>>>> That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by
>>>> the ABI Police, but taking the entire device away is ok.
>
> Changing bq27200-0 to bq27200_0 is forbidden in -rc6 time. If you
> believe noone depends on the name, argue your case, and it might be
> possible to change it in -rc0.
>
> If someone uses the name, they care about the device, and you can't
> take it away.
>
>>> No. IMO, it depends on if the interface is used or not.
>>> If hwmon I/F is used, we can not take it away, nor change its name.
>>
>> Even if the use doesn't depend on that name ?
>
> If the use doesn't depend on the name, you may get away with changing
> the name. (But not in -rc6.)
>
>>> If thermal zone I/F is used, we can not change it's 'type' name to be
>>> compatible with new hwmon API.
>>
>> You mean you can not fix the name to be compatible with libsensors.
>>
>> Makes me wonder if there shouldn't be a rule that exploits must not
>> be fixed if already exploited.
>
> That is not useful argumentation.
Oh, but it is. Providing a valid name is a bug fix for me. For you it is
an ABI change. So the ultimate question is what counts as an ABI change
and what counts as a bug fix.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 06:13:43 -0800 [thread overview]
Message-ID: <37154fca-5cfd-7f65-0f9b-14b979a094e6@roeck-us.net> (raw)
In-Reply-To: <20170127111626.GB5335@amd>
On 01/27/2017 03:16 AM, Pavel Machek wrote:
> Hi!
>
>>>> That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by
>>>> the ABI Police, but taking the entire device away is ok.
>
> Changing bq27200-0 to bq27200_0 is forbidden in -rc6 time. If you
> believe noone depends on the name, argue your case, and it might be
> possible to change it in -rc0.
>
> If someone uses the name, they care about the device, and you can't
> take it away.
>
>>> No. IMO, it depends on if the interface is used or not.
>>> If hwmon I/F is used, we can not take it away, nor change its name.
>>
>> Even if the use doesn't depend on that name ?
>
> If the use doesn't depend on the name, you may get away with changing
> the name. (But not in -rc6.)
>
>>> If thermal zone I/F is used, we can not change it's 'type' name to be
>>> compatible with new hwmon API.
>>
>> You mean you can not fix the name to be compatible with libsensors.
>>
>> Makes me wonder if there shouldn't be a rule that exploits must not
>> be fixed if already exploited.
>
> That is not useful argumentation.
Oh, but it is. Providing a valid name is a bug fix for me. For you it is
an ABI change. So the ultimate question is what counts as an ABI change
and what counts as a bug fix.
Guenter
next prev parent reply other threads:[~2017-01-27 14:14 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:40 v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Pavel Machek
2017-01-23 12:40 ` Pavel Machek
2017-01-23 12:42 ` Pali Rohár
2017-01-23 12:42 ` Pali Rohár
2017-01-23 14:20 ` Pavel Machek
2017-01-23 14:20 ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:31 ` Guenter Roeck
2017-01-23 14:31 ` Guenter Roeck
2017-01-23 14:40 ` Pavel Machek
2017-01-23 14:40 ` Pavel Machek
2017-01-23 17:10 ` Guenter Roeck
2017-01-23 17:10 ` Guenter Roeck
2017-01-23 23:26 ` Pavel Machek
2017-01-23 23:26 ` Pavel Machek
2017-01-23 23:49 ` Guenter Roeck
2017-01-23 23:49 ` Guenter Roeck
2017-01-24 7:06 ` Zhang Rui
2017-01-24 7:06 ` Zhang Rui
2017-01-24 7:37 ` Pavel Machek
2017-01-24 7:37 ` Pavel Machek
2017-01-24 14:18 ` Guenter Roeck
2017-01-24 14:18 ` Guenter Roeck
2017-01-24 17:58 ` Pavel Machek
2017-01-24 17:58 ` Pavel Machek
2017-01-24 18:45 ` Guenter Roeck
2017-01-24 18:45 ` Guenter Roeck
2017-01-24 22:46 ` Pavel Machek
2017-01-24 22:46 ` Pavel Machek
2017-01-24 23:07 ` Fabio Estevam
2017-01-24 23:07 ` Fabio Estevam
2017-01-25 5:29 ` Zhang Rui
2017-01-25 5:29 ` Zhang Rui
2017-01-25 10:17 ` Pavel Machek
2017-01-25 10:17 ` Pavel Machek
2017-01-25 11:12 ` Pavel Machek
2017-01-25 11:12 ` Pavel Machek
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 11:51 ` Guenter Roeck
2017-01-25 12:09 ` Pali Rohár
2017-01-25 12:09 ` Pali Rohár
2017-01-27 1:37 ` Zhang Rui
2017-01-27 1:37 ` Zhang Rui
2017-01-27 1:37 ` Zhang Rui
2017-01-27 2:03 ` Guenter Roeck
2017-01-27 2:03 ` Guenter Roeck
2017-01-27 3:39 ` Zhang Rui
2017-01-27 3:39 ` Zhang Rui
2017-01-27 3:39 ` Zhang Rui
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 6:27 ` Guenter Roeck
2017-01-27 11:16 ` Pavel Machek
2017-01-27 11:16 ` Pavel Machek
2017-01-27 14:13 ` Guenter Roeck [this message]
2017-01-27 14:13 ` Guenter Roeck
2017-01-27 19:06 ` Pavel Machek
2017-01-27 19:06 ` Pavel Machek
2017-01-27 19:06 ` Pavel Machek
2017-01-27 14:40 ` Zhang Rui
2017-01-27 14:40 ` Zhang Rui
2017-01-27 17:20 ` Guenter Roeck
2017-01-27 17:20 ` Guenter Roeck
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:12 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 19:29 ` Pavel Machek
2017-01-27 8:35 ` Pali Rohár
2017-01-27 8:35 ` Pali Rohár
2017-01-27 11:09 ` Pavel Machek
2017-01-27 11:09 ` Pavel Machek
2017-01-27 11:09 ` Pavel Machek
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 14:14 ` Guenter Roeck
2017-01-27 19:02 ` Pavel Machek
2017-01-27 19:02 ` Pavel Machek
2017-01-27 19:02 ` Pavel Machek
2017-01-27 11:29 ` Pavel Machek
2017-01-27 11:29 ` Pavel Machek
2017-01-24 14:10 ` Guenter Roeck
2017-01-24 14:10 ` Guenter Roeck
2017-01-24 14:15 ` Pavel Machek
2017-01-24 14:15 ` Pavel Machek
2017-01-24 14:30 ` Guenter Roeck
2017-01-24 14:30 ` Guenter Roeck
2017-01-24 7:34 ` Pavel Machek
2017-01-24 7:34 ` Pavel Machek
2017-01-24 14:15 ` Guenter Roeck
2017-01-24 14:15 ` Guenter Roeck
2017-01-23 20:22 ` Pavel Machek
2017-01-23 20:22 ` Pavel Machek
2017-01-23 20:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37154fca-5cfd-7f65-0f9b-14b979a094e6@roeck-us.net \
--to=linux@roeck-us.net \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.