All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Zhang Rui" <rui.zhang@intel.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	sre@kernel.org, "kernel list" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
	aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
	patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
	fabio.estevam@nxp.com
Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 06:14:57 -0800	[thread overview]
Message-ID: <74f6b75a-66b0-789f-658b-0e9f5cfed5a8@roeck-us.net> (raw)
In-Reply-To: <20170127110947.GA5335@amd>

On 01/27/2017 03:09 AM, Pavel Machek wrote:
>
>>> If this is the case, you'd better set
>>> (struct thermal_zone_params)->no_hwmon when registering the thermal
>>> zone device, in which case, the hwmon device will not be created.
>>>
>>> In fact, I'd prefer to change tzp->no_hwmon to tzp->hwmon to not create
>>> hwmon I/F by default, and see if there is anyone using it. If yes, we
>>> can set the flag in soc thermal driver, explicitly, at meantime, a
>>> hwmon compatible name is required.
>>>
>>> But one foreseeable result is that we may get bug reports from end user
>>> that some sensors (acpitz, etc) are gone in 'sensors' output. And TBH,
>>> I'm not quite sure if this can be counted as a regression or not.
>>>
>>
>> That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by
>> the ABI Police, but taking the entire device away is ok.
>
> Stop trying to break other people's systems. Thanks you.
>
You still have not shown that it does. Actually, I am trying to _fix_
other people's systems (those using libsensors).

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: ivo.g.dimitrov.75@gmail.com, khilman@kernel.org,
	tony@atomide.com, aaro.koskinen@iki.fi,
	"kernel list" <linux-kernel@vger.kernel.org>,
	sre@kernel.org, abcloriens@gmail.com,
	"Pali Rohár" <pali.rohar@gmail.com>,
	fabio.estevam@nxp.com, "Zhang Rui" <rui.zhang@intel.com>,
	linux-omap@vger.kernel.org, patrikbachan@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	serge@hallyn.com
Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 06:14:57 -0800	[thread overview]
Message-ID: <74f6b75a-66b0-789f-658b-0e9f5cfed5a8@roeck-us.net> (raw)
In-Reply-To: <20170127110947.GA5335@amd>

On 01/27/2017 03:09 AM, Pavel Machek wrote:
>
>>> If this is the case, you'd better set
>>> (struct thermal_zone_params)->no_hwmon when registering the thermal
>>> zone device, in which case, the hwmon device will not be created.
>>>
>>> In fact, I'd prefer to change tzp->no_hwmon to tzp->hwmon to not create
>>> hwmon I/F by default, and see if there is anyone using it. If yes, we
>>> can set the flag in soc thermal driver, explicitly, at meantime, a
>>> hwmon compatible name is required.
>>>
>>> But one foreseeable result is that we may get bug reports from end user
>>> that some sensors (acpitz, etc) are gone in 'sensors' output. And TBH,
>>> I'm not quite sure if this can be counted as a regression or not.
>>>
>>
>> That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by
>> the ABI Police, but taking the entire device away is ok.
>
> Stop trying to break other people's systems. Thanks you.
>
You still have not shown that it does. Actually, I am trying to _fix_
other people's systems (those using libsensors).

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
Date: Fri, 27 Jan 2017 06:14:57 -0800	[thread overview]
Message-ID: <74f6b75a-66b0-789f-658b-0e9f5cfed5a8@roeck-us.net> (raw)
In-Reply-To: <20170127110947.GA5335@amd>

On 01/27/2017 03:09 AM, Pavel Machek wrote:
>
>>> If this is the case, you'd better set
>>> (struct thermal_zone_params)->no_hwmon when registering the thermal
>>> zone device, in which case, the hwmon device will not be created.
>>>
>>> In fact, I'd prefer to change tzp->no_hwmon to tzp->hwmon to not create
>>> hwmon I/F by default, and see if there is anyone using it. If yes, we
>>> can set the flag in soc thermal driver, explicitly, at meantime, a
>>> hwmon compatible name is required.
>>>
>>> But one foreseeable result is that we may get bug reports from end user
>>> that some sensors (acpitz, etc) are gone in 'sensors' output. And TBH,
>>> I'm not quite sure if this can be counted as a regression or not.
>>>
>>
>> That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by
>> the ABI Police, but taking the entire device away is ok.
>
> Stop trying to break other people's systems. Thanks you.
>
You still have not shown that it does. Actually, I am trying to _fix_
other people's systems (those using libsensors).

Guenter

  reply	other threads:[~2017-01-27 14:16 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 12:40 v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Pavel Machek
2017-01-23 12:40 ` Pavel Machek
2017-01-23 12:42 ` Pali Rohár
2017-01-23 12:42   ` Pali Rohár
2017-01-23 14:20   ` Pavel Machek
2017-01-23 14:20     ` Pavel Machek
2017-01-23 14:19 ` Pavel Machek
2017-01-23 14:19   ` Pavel Machek
2017-01-23 14:31   ` Guenter Roeck
2017-01-23 14:31     ` Guenter Roeck
2017-01-23 14:40     ` Pavel Machek
2017-01-23 14:40       ` Pavel Machek
2017-01-23 17:10       ` Guenter Roeck
2017-01-23 17:10         ` Guenter Roeck
2017-01-23 23:26       ` Pavel Machek
2017-01-23 23:26         ` Pavel Machek
2017-01-23 23:49         ` Guenter Roeck
2017-01-23 23:49           ` Guenter Roeck
2017-01-24  7:06           ` Zhang Rui
2017-01-24  7:06             ` Zhang Rui
2017-01-24  7:37             ` Pavel Machek
2017-01-24  7:37               ` Pavel Machek
2017-01-24 14:18               ` Guenter Roeck
2017-01-24 14:18                 ` Guenter Roeck
2017-01-24 17:58                 ` Pavel Machek
2017-01-24 17:58                   ` Pavel Machek
2017-01-24 18:45                   ` Guenter Roeck
2017-01-24 18:45                     ` Guenter Roeck
2017-01-24 22:46                     ` Pavel Machek
2017-01-24 22:46                       ` Pavel Machek
2017-01-24 23:07                       ` Fabio Estevam
2017-01-24 23:07                         ` Fabio Estevam
2017-01-25  5:29                         ` Zhang Rui
2017-01-25  5:29                           ` Zhang Rui
2017-01-25 10:17                           ` Pavel Machek
2017-01-25 10:17                             ` Pavel Machek
2017-01-25 11:12                     ` Pavel Machek
2017-01-25 11:12                       ` Pavel Machek
2017-01-25 11:51                       ` Guenter Roeck
2017-01-25 11:51                         ` Guenter Roeck
2017-01-25 11:51                         ` Guenter Roeck
2017-01-25 12:09                       ` Pali Rohár
2017-01-25 12:09                         ` Pali Rohár
2017-01-27  1:37                         ` Zhang Rui
2017-01-27  1:37                           ` Zhang Rui
2017-01-27  1:37                           ` Zhang Rui
2017-01-27  2:03                           ` Guenter Roeck
2017-01-27  2:03                             ` Guenter Roeck
2017-01-27  3:39                             ` Zhang Rui
2017-01-27  3:39                               ` Zhang Rui
2017-01-27  3:39                               ` Zhang Rui
2017-01-27  6:27                               ` Guenter Roeck
2017-01-27  6:27                                 ` Guenter Roeck
2017-01-27  6:27                                 ` Guenter Roeck
2017-01-27 11:16                                 ` Pavel Machek
2017-01-27 11:16                                   ` Pavel Machek
2017-01-27 14:13                                   ` Guenter Roeck
2017-01-27 14:13                                     ` Guenter Roeck
2017-01-27 19:06                                     ` Pavel Machek
2017-01-27 19:06                                       ` Pavel Machek
2017-01-27 19:06                                       ` Pavel Machek
2017-01-27 14:40                                 ` Zhang Rui
2017-01-27 14:40                                   ` Zhang Rui
2017-01-27 17:20                                   ` Guenter Roeck
2017-01-27 17:20                                     ` Guenter Roeck
2017-01-27 19:12                                     ` Pavel Machek
2017-01-27 19:12                                       ` Pavel Machek
2017-01-27 19:12                                       ` Pavel Machek
2017-01-27 19:29                                   ` Pavel Machek
2017-01-27 19:29                                     ` Pavel Machek
2017-01-27 19:29                                     ` Pavel Machek
2017-01-27  8:35                               ` Pali Rohár
2017-01-27  8:35                                 ` Pali Rohár
2017-01-27 11:09                             ` Pavel Machek
2017-01-27 11:09                               ` Pavel Machek
2017-01-27 11:09                               ` Pavel Machek
2017-01-27 14:14                               ` Guenter Roeck [this message]
2017-01-27 14:14                                 ` Guenter Roeck
2017-01-27 14:14                                 ` Guenter Roeck
2017-01-27 19:02                                 ` Pavel Machek
2017-01-27 19:02                                   ` Pavel Machek
2017-01-27 19:02                                   ` Pavel Machek
2017-01-27 11:29                         ` Pavel Machek
2017-01-27 11:29                           ` Pavel Machek
2017-01-24 14:10             ` Guenter Roeck
2017-01-24 14:10               ` Guenter Roeck
2017-01-24 14:15               ` Pavel Machek
2017-01-24 14:15                 ` Pavel Machek
2017-01-24 14:30                 ` Guenter Roeck
2017-01-24 14:30                   ` Guenter Roeck
2017-01-24  7:34           ` Pavel Machek
2017-01-24  7:34             ` Pavel Machek
2017-01-24 14:15             ` Guenter Roeck
2017-01-24 14:15               ` Guenter Roeck
2017-01-23 20:22   ` Pavel Machek
2017-01-23 20:22     ` Pavel Machek
2017-01-23 20:22     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74f6b75a-66b0-789f-658b-0e9f5cfed5a8@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=aaro.koskinen@iki.fi \
    --cc=abcloriens@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=rui.zhang@intel.com \
    --cc=serge@hallyn.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.