From: "Pali Rohár" <pali@kernel.org> To: Naveen Naidu <naveennaidu479@gmail.com> Cc: Rob Herring <robh@kernel.org>, bhelgaas@google.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, andrew.murray@arm.com Subject: Re: [PATCH 02/22] PCI: Unify PCI error response checking Date: Wed, 13 Oct 2021 00:52:44 +0200 [thread overview] Message-ID: <20211012225244.y75fsd7777ubvljl@pali> (raw) In-Reply-To: <20211012162054.rxx7aubwdvhl2eqj@theprophet> On Tuesday 12 October 2021 21:51:08 Naveen Naidu wrote: > On 11/10, Rob Herring wrote: > > On Mon, Oct 11, 2021 at 11:08:32PM +0530, Naveen Naidu wrote: > > > return PCIBIOS_DEVICE_NOT_FOUND; > > > > Neither does this using custom error codes rather than standard Linux > > errno. I point this out as I that's were I'd start with the config > > accessors. Though there are lots of occurrences so we'd need a way to do > > this in manageable steps. > > > > I am sorry, but I do not have any answer for this. I really do not know > why we return custom error codes instead of standard Linux errno. Maybe > someone else can pitch in on this. More people are asking same question and Bjorn recently wrote answer: https://lore.kernel.org/linux-pci/20211011205851.GA1690395@bhelgaas/ It looks like some relict from past when PCI was implemented only for x86. Anyway, I was looking at PCI firmware spec (where are these PCBIOS_* codes defined) and config read function can return only PCIBIOS_SUCCESSFUL value. So if kernel PCI API is following this PCBIOS API it means that controller drivers are implementing it improperly if they returns also non-success value for read method in some cases. And for me it looks like very "stupid" API for read as it has basically same meaning as function with void return value. > > Can't we make PCI_OP_READ and PCI_USER_READ_CONFIG set the data value > > and delete the drivers all doing this? Then we have 2 copies (in source) > > rather than the many this series modifies. Though I'm not sure if there > > are other cases of calling pci_bus.ops.read() which expect to get ~0. > > > > This seems like a really good idea :) But again, I am not entirely sure > if doing so would give us any unexpected behaviour. I'll wait for some > one to reply to this and if people agree to it, I would be glad to make > the changes to PCI_OP_READ and PCI_USER_READ_CONFIG and send a new > patch. If you are going to discuss and change API of config read / write functions, please CC me. For example pci-aardvark controller reports not only "unknown error" happened (via 0xffffffff) but can report exact PCIe error (CRS, UR, CA) which can be mapped to some linux errnos. I can imagine that it can be useful for some callers.
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org> To: Naveen Naidu <naveennaidu479@gmail.com> Cc: Rob Herring <robh@kernel.org>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, andrew.murray@arm.com, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH 02/22] PCI: Unify PCI error response checking Date: Wed, 13 Oct 2021 00:52:44 +0200 [thread overview] Message-ID: <20211012225244.y75fsd7777ubvljl@pali> (raw) In-Reply-To: <20211012162054.rxx7aubwdvhl2eqj@theprophet> On Tuesday 12 October 2021 21:51:08 Naveen Naidu wrote: > On 11/10, Rob Herring wrote: > > On Mon, Oct 11, 2021 at 11:08:32PM +0530, Naveen Naidu wrote: > > > return PCIBIOS_DEVICE_NOT_FOUND; > > > > Neither does this using custom error codes rather than standard Linux > > errno. I point this out as I that's were I'd start with the config > > accessors. Though there are lots of occurrences so we'd need a way to do > > this in manageable steps. > > > > I am sorry, but I do not have any answer for this. I really do not know > why we return custom error codes instead of standard Linux errno. Maybe > someone else can pitch in on this. More people are asking same question and Bjorn recently wrote answer: https://lore.kernel.org/linux-pci/20211011205851.GA1690395@bhelgaas/ It looks like some relict from past when PCI was implemented only for x86. Anyway, I was looking at PCI firmware spec (where are these PCBIOS_* codes defined) and config read function can return only PCIBIOS_SUCCESSFUL value. So if kernel PCI API is following this PCBIOS API it means that controller drivers are implementing it improperly if they returns also non-success value for read method in some cases. And for me it looks like very "stupid" API for read as it has basically same meaning as function with void return value. > > Can't we make PCI_OP_READ and PCI_USER_READ_CONFIG set the data value > > and delete the drivers all doing this? Then we have 2 copies (in source) > > rather than the many this series modifies. Though I'm not sure if there > > are other cases of calling pci_bus.ops.read() which expect to get ~0. > > > > This seems like a really good idea :) But again, I am not entirely sure > if doing so would give us any unexpected behaviour. I'll wait for some > one to reply to this and if people agree to it, I would be glad to make > the changes to PCI_OP_READ and PCI_USER_READ_CONFIG and send a new > patch. If you are going to discuss and change API of config read / write functions, please CC me. For example pci-aardvark controller reports not only "unknown error" happened (via 0xffffffff) but can report exact PCIe error (CRS, UR, CA) which can be mapped to some linux errnos. I can imagine that it can be useful for some callers. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-10-12 22:52 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-11 17:35 [PATCH 00/22] PCI: Unify PCI error response checking Naveen Naidu 2021-10-11 17:35 ` Naveen Naidu 2021-10-11 17:35 ` Naveen Naidu 2021-10-11 17:35 ` Naveen Naidu 2021-10-11 17:35 ` Naveen Naidu 2021-10-11 17:35 ` Naveen Naidu 2021-10-11 17:37 ` [PATCH 01/22] PCI: Add PCI_ERROR_RESPONSE and it's related defintions Naveen Naidu 2021-10-11 17:37 ` Naveen Naidu 2021-10-11 17:37 ` Naveen Naidu 2021-10-11 17:37 ` Naveen Naidu 2021-10-11 17:37 ` Naveen Naidu 2021-10-11 17:37 ` Naveen Naidu 2021-10-11 17:38 ` [PATCH 02/22] PCI: Unify PCI error response checking Naveen Naidu 2021-10-11 17:38 ` Naveen Naidu 2021-10-11 22:05 ` Rob Herring 2021-10-11 22:05 ` Rob Herring 2021-10-12 16:21 ` Naveen Naidu 2021-10-12 16:21 ` Naveen Naidu 2021-10-12 18:02 ` Rob Herring 2021-10-12 18:02 ` Rob Herring 2021-10-12 22:52 ` Pali Rohár [this message] 2021-10-12 22:52 ` Pali Rohár 2021-10-13 2:43 ` Bjorn Helgaas 2021-10-13 2:43 ` Bjorn Helgaas 2021-10-13 13:06 ` Rob Herring 2021-10-13 13:06 ` Rob Herring 2021-10-13 17:16 ` Naveen Naidu 2021-10-13 17:16 ` Naveen Naidu 2021-10-13 17:54 ` Pali Rohár 2021-10-13 17:54 ` Pali Rohár 2021-10-13 18:48 ` Bjorn Helgaas 2021-10-13 18:48 ` Bjorn Helgaas 2021-10-13 21:47 ` Rob Herring 2021-10-13 21:47 ` Rob Herring 2021-10-13 22:03 ` Pali Rohár 2021-10-13 22:03 ` Pali Rohár 2021-10-13 22:12 ` Bjorn Helgaas 2021-10-13 22:12 ` Bjorn Helgaas 2021-10-11 17:45 ` [PATCH 03/22] PCI: thunder: Use SET_PCI_ERROR_RESPONSE() when device not found Naveen Naidu 2021-10-11 17:45 ` Naveen Naidu 2021-10-11 17:45 ` Naveen Naidu 2021-10-11 17:46 ` [PATCH 04/22] PCI: iproc: " Naveen Naidu 2021-10-11 17:46 ` Naveen Naidu 2021-10-11 17:46 ` Naveen Naidu 2021-10-11 17:51 ` [PATCH 05/22] PCI: mediatek: " Naveen Naidu 2021-10-11 17:51 ` Naveen Naidu 2021-10-11 17:51 ` Naveen Naidu 2021-10-11 17:51 ` Naveen Naidu 2021-10-11 17:52 ` [PATCH 06/22] PCI: exynos: " Naveen Naidu 2021-10-11 17:52 ` Naveen Naidu 2021-10-11 17:52 ` Naveen Naidu 2021-10-11 17:53 ` [PATCH 07/22] PCI: histb: " Naveen Naidu 2021-10-11 17:53 ` Naveen Naidu 2021-10-11 17:55 ` [PATCH 08/22] PCI: kirin: " Naveen Naidu 2021-10-11 17:55 ` Naveen Naidu 2021-10-11 17:56 ` [PATCH 09/22] PCI: aardvark: " Naveen Naidu 2021-10-11 17:56 ` Naveen Naidu 2021-10-11 17:56 ` Naveen Naidu 2021-10-11 18:08 ` Pali Rohár 2021-10-11 18:08 ` Pali Rohár 2021-10-11 18:08 ` Pali Rohár 2021-10-11 18:28 ` Naveen Naidu 2021-10-11 18:28 ` Naveen Naidu 2021-10-11 18:28 ` Naveen Naidu [not found] ` <20211011182526.kboaxqofdpd2jjrl@theprophet> 2021-10-11 18:41 ` Pali Rohár 2021-10-11 18:41 ` Pali Rohár 2021-10-11 18:41 ` Pali Rohár 2021-10-12 15:59 ` Naveen Naidu 2021-10-12 15:59 ` Naveen Naidu 2021-10-12 15:59 ` Naveen Naidu 2021-10-13 2:13 ` Bjorn Helgaas 2021-10-13 2:13 ` Bjorn Helgaas 2021-10-13 2:13 ` Bjorn Helgaas 2021-10-13 17:59 ` Pali Rohár 2021-10-13 17:59 ` Pali Rohár 2021-10-13 17:59 ` Pali Rohár 2021-10-11 18:00 ` [PATCH 10/22] PCI: mvebu: " Naveen Naidu 2021-10-11 18:00 ` Naveen Naidu 2021-10-11 18:00 ` Naveen Naidu 2021-10-11 18:00 ` [PATCH 11/22] PCI: altera: " Naveen Naidu 2021-10-11 18:00 ` Naveen Naidu 2021-10-11 18:02 ` [PATCH 12/22] PCI: rcar: " Naveen Naidu 2021-10-11 18:02 ` Naveen Naidu 2021-10-11 18:02 ` [PATCH 13/22] PCI: rockchip: " Naveen Naidu 2021-10-11 18:02 ` Naveen Naidu 2021-10-11 18:02 ` Naveen Naidu 2021-10-11 18:02 ` Naveen Naidu 2021-10-11 18:04 ` [PATCH 14/22] PCI/ERR: Use RESPONSE_IS_PCI_ERROR() to check read from hardware Naveen Naidu 2021-10-11 18:04 ` Naveen Naidu 2021-10-11 18:06 ` [PATCH 15/22] PCI: vmd: " Naveen Naidu 2021-10-11 18:06 ` Naveen Naidu 2021-10-14 18:04 ` Jonathan Derrick 2021-10-14 18:04 ` Jonathan Derrick 2021-10-11 18:07 ` [PATCH 16/22] PCI: pciehp: " Naveen Naidu 2021-10-11 18:07 ` Naveen Naidu 2021-10-11 19:47 ` Lukas Wunner 2021-10-11 19:47 ` Lukas Wunner 2021-10-12 16:05 ` Naveen Naidu 2021-10-12 16:05 ` Naveen Naidu 2021-10-12 23:12 ` Pali Rohár 2021-10-12 23:12 ` Pali Rohár 2021-10-13 12:20 ` Lukas Wunner 2021-10-13 12:20 ` Lukas Wunner 2021-10-11 18:08 ` [PATCH 17/22] PCI/DPC: " Naveen Naidu 2021-10-11 18:08 ` Naveen Naidu 2021-10-11 18:08 ` Naveen Naidu 2021-10-11 18:10 ` [PATCH 18/22] PCI/PME: " Naveen Naidu 2021-10-11 18:10 ` Naveen Naidu 2021-10-11 18:11 ` [PATCH 19/22] PCI: cpqphp: " Naveen Naidu 2021-10-11 18:11 ` Naveen Naidu 2021-10-11 18:11 ` [PATCH 20/22] PCI: keystone: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu 2021-10-11 18:11 ` Naveen Naidu 2021-10-11 18:12 ` [PATCH 21/22] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Naveen Naidu 2021-10-11 18:12 ` Naveen Naidu 2021-10-11 18:13 ` [PATCH 22/22] PCI: xgene: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu 2021-10-11 18:13 ` Naveen Naidu 2021-10-11 18:13 ` Naveen Naidu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211012225244.y75fsd7777ubvljl@pali \ --to=pali@kernel.org \ --cc=andrew.murray@arm.com \ --cc=bhelgaas@google.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=naveennaidu479@gmail.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.