From: Bjorn Helgaas <helgaas@kernel.org>
To: Naveen Naidu <naveennaidu479@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
PCI <linux-pci@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 02/22] PCI: Unify PCI error response checking
Date: Wed, 13 Oct 2021 13:48:39 -0500 [thread overview]
Message-ID: <20211013184839.GA1909162@bhelgaas> (raw)
In-Reply-To: <20211013171653.zx4sxdzhvy2ujytd@theprophet>
On Wed, Oct 13, 2021 at 10:46:53PM +0530, Naveen Naidu wrote:
> 2. "Rework any callers expecting a positive return value"
>
> This means, find out the places where we have something like
>
> err = pci_read_config_dword();
> if (err > 0)
>
> Then change it to:
>
> err = pci_read_config_dword(pdev, PCI_REG_NPKDSC, &npkdsc);
> if (err != PCIBIOS_SUCCESSFUL)
I'm sure this is obvious, but I would try hard not to add any new uses
of PCIBIOS_SUCCESSFUL.
> Is there any easy way to search for these patterns, or should I look
> for each instance of pci_read_config_* and other such variants and
> see if such an case exists?
coccigrep might be able to find things like this, but I'ver never
really become friends with it.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Naveen Naidu <naveennaidu479@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
PCI <linux-pci@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 02/22] PCI: Unify PCI error response checking
Date: Wed, 13 Oct 2021 13:48:39 -0500 [thread overview]
Message-ID: <20211013184839.GA1909162@bhelgaas> (raw)
In-Reply-To: <20211013171653.zx4sxdzhvy2ujytd@theprophet>
On Wed, Oct 13, 2021 at 10:46:53PM +0530, Naveen Naidu wrote:
> 2. "Rework any callers expecting a positive return value"
>
> This means, find out the places where we have something like
>
> err = pci_read_config_dword();
> if (err > 0)
>
> Then change it to:
>
> err = pci_read_config_dword(pdev, PCI_REG_NPKDSC, &npkdsc);
> if (err != PCIBIOS_SUCCESSFUL)
I'm sure this is obvious, but I would try hard not to add any new uses
of PCIBIOS_SUCCESSFUL.
> Is there any easy way to search for these patterns, or should I look
> for each instance of pci_read_config_* and other such variants and
> see if such an case exists?
coccigrep might be able to find things like this, but I'ver never
really become friends with it.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-10-13 18:48 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 17:35 [PATCH 00/22] PCI: Unify PCI error response checking Naveen Naidu
2021-10-11 17:35 ` Naveen Naidu
2021-10-11 17:35 ` Naveen Naidu
2021-10-11 17:35 ` Naveen Naidu
2021-10-11 17:35 ` Naveen Naidu
2021-10-11 17:35 ` Naveen Naidu
2021-10-11 17:37 ` [PATCH 01/22] PCI: Add PCI_ERROR_RESPONSE and it's related defintions Naveen Naidu
2021-10-11 17:37 ` Naveen Naidu
2021-10-11 17:37 ` Naveen Naidu
2021-10-11 17:37 ` Naveen Naidu
2021-10-11 17:37 ` Naveen Naidu
2021-10-11 17:37 ` Naveen Naidu
2021-10-11 17:38 ` [PATCH 02/22] PCI: Unify PCI error response checking Naveen Naidu
2021-10-11 17:38 ` Naveen Naidu
2021-10-11 22:05 ` Rob Herring
2021-10-11 22:05 ` Rob Herring
2021-10-12 16:21 ` Naveen Naidu
2021-10-12 16:21 ` Naveen Naidu
2021-10-12 18:02 ` Rob Herring
2021-10-12 18:02 ` Rob Herring
2021-10-12 22:52 ` Pali Rohár
2021-10-12 22:52 ` Pali Rohár
2021-10-13 2:43 ` Bjorn Helgaas
2021-10-13 2:43 ` Bjorn Helgaas
2021-10-13 13:06 ` Rob Herring
2021-10-13 13:06 ` Rob Herring
2021-10-13 17:16 ` Naveen Naidu
2021-10-13 17:16 ` Naveen Naidu
2021-10-13 17:54 ` Pali Rohár
2021-10-13 17:54 ` Pali Rohár
2021-10-13 18:48 ` Bjorn Helgaas [this message]
2021-10-13 18:48 ` Bjorn Helgaas
2021-10-13 21:47 ` Rob Herring
2021-10-13 21:47 ` Rob Herring
2021-10-13 22:03 ` Pali Rohár
2021-10-13 22:03 ` Pali Rohár
2021-10-13 22:12 ` Bjorn Helgaas
2021-10-13 22:12 ` Bjorn Helgaas
2021-10-11 17:45 ` [PATCH 03/22] PCI: thunder: Use SET_PCI_ERROR_RESPONSE() when device not found Naveen Naidu
2021-10-11 17:45 ` Naveen Naidu
2021-10-11 17:45 ` Naveen Naidu
2021-10-11 17:46 ` [PATCH 04/22] PCI: iproc: " Naveen Naidu
2021-10-11 17:46 ` Naveen Naidu
2021-10-11 17:46 ` Naveen Naidu
2021-10-11 17:51 ` [PATCH 05/22] PCI: mediatek: " Naveen Naidu
2021-10-11 17:51 ` Naveen Naidu
2021-10-11 17:51 ` Naveen Naidu
2021-10-11 17:51 ` Naveen Naidu
2021-10-11 17:52 ` [PATCH 06/22] PCI: exynos: " Naveen Naidu
2021-10-11 17:52 ` Naveen Naidu
2021-10-11 17:52 ` Naveen Naidu
2021-10-11 17:53 ` [PATCH 07/22] PCI: histb: " Naveen Naidu
2021-10-11 17:53 ` Naveen Naidu
2021-10-11 17:55 ` [PATCH 08/22] PCI: kirin: " Naveen Naidu
2021-10-11 17:55 ` Naveen Naidu
2021-10-11 17:56 ` [PATCH 09/22] PCI: aardvark: " Naveen Naidu
2021-10-11 17:56 ` Naveen Naidu
2021-10-11 17:56 ` Naveen Naidu
2021-10-11 18:08 ` Pali Rohár
2021-10-11 18:08 ` Pali Rohár
2021-10-11 18:08 ` Pali Rohár
2021-10-11 18:28 ` Naveen Naidu
2021-10-11 18:28 ` Naveen Naidu
2021-10-11 18:28 ` Naveen Naidu
[not found] ` <20211011182526.kboaxqofdpd2jjrl@theprophet>
2021-10-11 18:41 ` Pali Rohár
2021-10-11 18:41 ` Pali Rohár
2021-10-11 18:41 ` Pali Rohár
2021-10-12 15:59 ` Naveen Naidu
2021-10-12 15:59 ` Naveen Naidu
2021-10-12 15:59 ` Naveen Naidu
2021-10-13 2:13 ` Bjorn Helgaas
2021-10-13 2:13 ` Bjorn Helgaas
2021-10-13 2:13 ` Bjorn Helgaas
2021-10-13 17:59 ` Pali Rohár
2021-10-13 17:59 ` Pali Rohár
2021-10-13 17:59 ` Pali Rohár
2021-10-11 18:00 ` [PATCH 10/22] PCI: mvebu: " Naveen Naidu
2021-10-11 18:00 ` Naveen Naidu
2021-10-11 18:00 ` Naveen Naidu
2021-10-11 18:00 ` [PATCH 11/22] PCI: altera: " Naveen Naidu
2021-10-11 18:00 ` Naveen Naidu
2021-10-11 18:02 ` [PATCH 12/22] PCI: rcar: " Naveen Naidu
2021-10-11 18:02 ` Naveen Naidu
2021-10-11 18:02 ` [PATCH 13/22] PCI: rockchip: " Naveen Naidu
2021-10-11 18:02 ` Naveen Naidu
2021-10-11 18:02 ` Naveen Naidu
2021-10-11 18:02 ` Naveen Naidu
2021-10-11 18:04 ` [PATCH 14/22] PCI/ERR: Use RESPONSE_IS_PCI_ERROR() to check read from hardware Naveen Naidu
2021-10-11 18:04 ` Naveen Naidu
2021-10-11 18:06 ` [PATCH 15/22] PCI: vmd: " Naveen Naidu
2021-10-11 18:06 ` Naveen Naidu
2021-10-14 18:04 ` Jonathan Derrick
2021-10-14 18:04 ` Jonathan Derrick
2021-10-11 18:07 ` [PATCH 16/22] PCI: pciehp: " Naveen Naidu
2021-10-11 18:07 ` Naveen Naidu
2021-10-11 19:47 ` Lukas Wunner
2021-10-11 19:47 ` Lukas Wunner
2021-10-12 16:05 ` Naveen Naidu
2021-10-12 16:05 ` Naveen Naidu
2021-10-12 23:12 ` Pali Rohár
2021-10-12 23:12 ` Pali Rohár
2021-10-13 12:20 ` Lukas Wunner
2021-10-13 12:20 ` Lukas Wunner
2021-10-11 18:08 ` [PATCH 17/22] PCI/DPC: " Naveen Naidu
2021-10-11 18:08 ` Naveen Naidu
2021-10-11 18:08 ` Naveen Naidu
2021-10-11 18:10 ` [PATCH 18/22] PCI/PME: " Naveen Naidu
2021-10-11 18:10 ` Naveen Naidu
2021-10-11 18:11 ` [PATCH 19/22] PCI: cpqphp: " Naveen Naidu
2021-10-11 18:11 ` Naveen Naidu
2021-10-11 18:11 ` [PATCH 20/22] PCI: keystone: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu
2021-10-11 18:11 ` Naveen Naidu
2021-10-11 18:12 ` [PATCH 21/22] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Naveen Naidu
2021-10-11 18:12 ` Naveen Naidu
2021-10-11 18:13 ` [PATCH 22/22] PCI: xgene: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu
2021-10-11 18:13 ` Naveen Naidu
2021-10-11 18:13 ` Naveen Naidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013184839.GA1909162@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=naveennaidu479@gmail.com \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.