From: Mika Kuoppala <mika.kuoppala@linux.intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/27] drm/i915: Flush context free work on cleanup Date: Tue, 12 Nov 2019 16:23:14 +0200 [thread overview] Message-ID: <87mud141il.fsf@gaia.fi.intel.com> (raw) In-Reply-To: <20191112092854.869-1-chris@chris-wilson.co.uk> Chris Wilson <chris@chris-wilson.co.uk> writes: > Throw in a flush_work() and rcu_barrier() to specifically flush the > context cleanup work. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > index 72d389afa28a..17f395672e5e 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915) > void i915_gem_driver_release__contexts(struct drm_i915_private *i915) > { > destroy_kernel_context(&i915->kernel_context); > + flush_work(&i915->gem.contexts.free_work); > } > > static int context_idr_cleanup(int id, void *p, void *data) > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > index b9613d044393..1f68700a2311 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > @@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt) > gt->engine[id] = NULL; > gt->i915->engine[id] = NULL; > } > + rcu_barrier(); I guess we need this for releasing kernel_ctx but I don't see why exactly. -Mika > } > > /** > -- > 2.24.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 01/27] drm/i915: Flush context free work on cleanup Date: Tue, 12 Nov 2019 16:23:14 +0200 [thread overview] Message-ID: <87mud141il.fsf@gaia.fi.intel.com> (raw) Message-ID: <20191112142314.NT6JXl-7F0GHASR0S774ka1dHNQ_bRchTdJAWg6X93Y@z> (raw) In-Reply-To: <20191112092854.869-1-chris@chris-wilson.co.uk> Chris Wilson <chris@chris-wilson.co.uk> writes: > Throw in a flush_work() and rcu_barrier() to specifically flush the > context cleanup work. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > index 72d389afa28a..17f395672e5e 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915) > void i915_gem_driver_release__contexts(struct drm_i915_private *i915) > { > destroy_kernel_context(&i915->kernel_context); > + flush_work(&i915->gem.contexts.free_work); > } > > static int context_idr_cleanup(int id, void *p, void *data) > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > index b9613d044393..1f68700a2311 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > @@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt) > gt->engine[id] = NULL; > gt->i915->engine[id] = NULL; > } > + rcu_barrier(); I guess we need this for releasing kernel_ctx but I don't see why exactly. -Mika > } > > /** > -- > 2.24.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-12 14:23 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-12 9:28 [PATCH 01/27] drm/i915: Flush context free work on cleanup Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 02/27] drm/i915/gt: Try an extra flush on the Haswell blitter Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 03/27] drm/i915/gem: Silence sparse for RCU protection inside the constructor Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 04/27] drm/i915/selftests: Mock the engine sorting for easy validation Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 05/27] Revert "drm/i915: use a separate context for gpu relocs" Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 06/27] drm/i915: Use a ctor for TYPESAFE_BY_RCU i915_request Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 07/27] drm/i915: Drop GEM context as a direct link from i915_request Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 08/27] drm/i915: Push the use-semaphore marker onto the intel_context Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 09/27] drm/i915: Remove i915->kernel_context Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 10/27] drm/i915: Move i915_gem_init_contexts() earlier Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 11/27] drm/i915/uc: Use an internal buffer for firmware images Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 12/27] drm/i915/gt: Pull GT initialisation under intel_gt_init() Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 13/27] drm/i915/gt: Merge engine init/setup loops Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 14/27] drm/i915/gt: Expose engine properties via sysfs Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 15/27] drm/i915/gt: Expose engine->mmio_base " Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-21 13:18 ` Lionel Landwerlin 2019-11-21 13:18 ` [Intel-gfx] " Lionel Landwerlin 2019-11-21 13:23 ` Chris Wilson 2019-11-21 13:23 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 16/27] drm/i915/gt: Expose timeslice duration to sysfs Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 17/27] drm/i915/gt: Expose busywait " Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 18/27] drm/i915/gt: Expose reset stop timeout via sysfs Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 19/27] drm/i915/gt: Expose preempt reset " Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 20/27] drm/i915/gt: Expose heartbeat interval " Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 21/27] drm/i915: Flush idle barriers when waiting Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 22/27] drm/i915: Allow userspace to specify ringsize on construction Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 23/27] drm/i915/gem: Honour O_NONBLOCK before throttling execbuf submissions Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 24/27] drm/i915/gt: Set unused mocs entry to follow PTE on tgl as on all others Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 14:13 ` Mika Kuoppala 2019-11-12 14:13 ` [Intel-gfx] " Mika Kuoppala 2019-11-12 14:39 ` Chris Wilson 2019-11-12 14:39 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 25/27] drm/i915/gt: Tidy up debug-warns for the mocs control table Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 26/27] drm/i915/gt: Refactor mocs loops into single control macro Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 17:02 ` Mika Kuoppala 2019-11-12 17:02 ` [Intel-gfx] " Mika Kuoppala 2019-11-12 18:12 ` Chris Wilson 2019-11-12 18:12 ` [Intel-gfx] " Chris Wilson 2019-11-12 9:28 ` [PATCH 27/27] drm/i915/selftests: Add coverage of mocs registers Chris Wilson 2019-11-12 9:28 ` [Intel-gfx] " Chris Wilson 2019-11-12 10:12 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/27] drm/i915: Flush context free work on cleanup Patchwork 2019-11-12 10:12 ` [Intel-gfx] " Patchwork 2019-11-12 10:23 ` ✗ Fi.CI.SPARSE: " Patchwork 2019-11-12 10:23 ` [Intel-gfx] " Patchwork 2019-11-12 10:33 ` ✗ Fi.CI.BAT: failure " Patchwork 2019-11-12 10:33 ` [Intel-gfx] " Patchwork 2019-11-12 14:23 ` Mika Kuoppala [this message] 2019-11-12 14:23 ` [Intel-gfx] [PATCH 01/27] " Mika Kuoppala 2019-11-12 14:39 ` Chris Wilson 2019-11-12 14:39 ` [Intel-gfx] " Chris Wilson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87mud141il.fsf@gaia.fi.intel.com \ --to=mika.kuoppala@linux.intel.com \ --cc=chris@chris-wilson.co.uk \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.