From: Himanshu Madhani <hmadhani@marvell.com>
To: Quinn Tran <qutran@marvell.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Cc: "linux@yadro.com" <linux@yadro.com>
Subject: Re: [EXT] [PATCH v2 05/15] scsi: qla2xxx: Allow PLOGI in target mode
Date: Thu, 21 Nov 2019 16:38:41 +0000 [thread overview]
Message-ID: <02BC133C-1758-4FD7-AD39-5B97AD4C6158@marvell.com> (raw)
In-Reply-To: <BYAPR18MB2759F79A6F217771C44CDF0BD54F0@BYAPR18MB2759.namprd18.prod.outlook.com>
DQoNCu+7v09uIDExLzIwLzE5LCA0OjUyIFBNLCAiUXVpbm4gVHJhbiIgPHF1dHJhbkBtYXJ2ZWxs
LmNvbT4gd3JvdGU6DQoNCiAgICBBY2NvcmRpbmcgdG8gRkMtTFMtMyAoRmlicmUgQ2hhbm5lbCBM
aW5rIFNlcnZpY2VzKSA2LjMuMi40ICJOX1BvcnQgTG9naW4gLSBObyBGYWJyaWMgcHJlc2VudCIs
IGlmIGJvdGggcGFydGllcyBpbiB0aGUgcG9pbnQtdG8tcG9pbnQgY29ubmVjdGlvbiBrbm93IE5f
UG9ydF9OYW1lcyBvZiBlYWNoIG90aGVyLCBOeF9Qb3J0IHdpdGggdGhlIGhpZ2hlc3QgTl9Qb3J0
X25hbWUgc2hhbGwgdHJhbnNtaXQgUExPR0kuIFRoZSBzcGVjaWZpY2F0aW9uIHNldHMgbm8gcmVz
dHJpY3Rpb25zIG9uIHRoZSBwb3J0IHJvbGUgdGhhdCBzaG91bGQgc2VuZCBQTE9HSS4NCiAgICAN
CiAgICBIb3dldmVyLCBGQ1AtNCAoRmlicmUgQ2hhbm5lbCBQcm90b2NvbCBmb3IgU0NTSSwgRm91
cnRoIFZlcnNpb24pIDYuMiAiT3ZlcnZpZXcgb2YgUHJvY2VzcyBMb2dpbiBhbmQgUHJvY2VzcyBM
b2dvdXQiLCBpbnN0cnVjdHMgdGhhdCBpbiBwb2ludC10by1wb2ludCB0b3BvbG9neSwgaW5pdGlh
dG9yIHNoYWxsIHNlbmQgZXhwbGljaXQgUFJMSSBFTFMuDQogICAgDQogICAgVGhlIGNoYW5nZSBm
aXhlcyBzdHVjayBQMlAgbG9naW4sIHdoZW4gdGFyZ2V0IFdXUE4gaXMgaGlnaGVyIHRoYW4gaW5p
dGlhdG9yIFdXUE4uDQogICAgDQogICAgQ2M6IFF1aW5uIFRyYW4gPHF1dHJhbkBtYXJ2ZWxsLmNv
bT4NCiAgICBDYzogSGltYW5zaHUgTWFkaGFuaSA8aG1hZGhhbmlAbWFydmVsbC5jb20+DQogICAg
U2lnbmVkLW9mZi1ieTogUm9tYW4gQm9sc2hha292IDxyLmJvbHNoYWtvdkB5YWRyby5jb20+DQog
ICAgLS0tDQogICAgIGRyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9pbml0LmMgfCA4ICsrKystLS0t
DQogICAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQog
ICAgDQogICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9pbml0LmMgYi9k
cml2ZXJzL3Njc2kvcWxhMnh4eC9xbGFfaW5pdC5jIGluZGV4IGZjYjMwOWJlNTBkOS4uMTIzOTE4
MTViZTA2IDEwMDY0NA0KICAgIC0tLSBhL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9pbml0LmMN
CiAgICArKysgYi9kcml2ZXJzL3Njc2kvcWxhMnh4eC9xbGFfaW5pdC5jDQogICAgQEAgLTE1Mjcs
MTAgKzE1MjcsNiBAQCBpbnQgcWxhMjR4eF9mY3BvcnRfaGFuZGxlX2xvZ2luKHN0cnVjdCBzY3Np
X3FsYV9ob3N0ICp2aGEsIGZjX3BvcnRfdCAqZmNwb3J0KQ0KICAgICAJCX0NCiAgICAgCX0NCiAg
ICAgDQogICAgLQkvKiBmb3IgcHVyZSBUYXJnZXQgTW9kZS4gTG9naW4gd2lsbCBub3QgYmUgaW5p
dGlhdGVkICovDQogICAgLQlpZiAodmhhLT5ob3N0LT5hY3RpdmVfbW9kZSA9PSBNT0RFX1RBUkdF
VCkNCiAgICAtCQlyZXR1cm4gMDsNCiAgICAtDQogICAgUVQ6ICBOYWNrLiAgTGVhdmUgdGhpcyBo
dW5rLiAgSW5zdGVhZCBkbyB0aGlzDQoNCiAgICANCiAgICBpZiAodmhhLT5ob3N0LT5hY3RpdmVf
bW9kZSA9PSBNT0RFX1RBUkdFVCkgJiYgIU4yTl9UT1BPKHZoYS0+aHcpDQogICAgDQogICAgLS0N
Cg0KQWdyZWUuIFBsZWFzZSByZXNlbmQgd2l0aCB1cGRhdGUuDQogICAgDQogICAgDQogICAgIAlp
ZiAoZmNwb3J0LT5mbGFncyAmIEZDRl9BU1lOQ19TRU5UKSB7DQogICAgIAkJc2V0X2JpdChSRUxP
R0lOX05FRURFRCwgJnZoYS0+ZHBjX2ZsYWdzKTsNCiAgICAgCQlyZXR1cm4gMDsNCiAgICBAQCAt
MTcyMCw2ICsxNzE2LDEwIEBAIHZvaWQgcWxhMjR4eF9oYW5kbGVfcmVsb2dpbl9ldmVudChzY3Np
X3FsYV9ob3N0X3QgKnZoYSwgIHZvaWQgcWxhX2hhbmRsZV9lbHNfcGxvZ2lfZG9uZShzY3NpX3Fs
YV9ob3N0X3QgKnZoYSwNCiAgICAgCQkJCSAgICAgIHN0cnVjdCBldmVudF9hcmcgKmVhKQ0KICAg
ICB7DQogICAgKwkvKiBmb3IgcHVyZSBUYXJnZXQgTW9kZSwgUFJMSSB3aWxsIG5vdCBiZSBpbml0
aWF0ZWQgKi8NCiAgICArCWlmICh2aGEtPmhvc3QtPmFjdGl2ZV9tb2RlID09IE1PREVfVEFSR0VU
KQ0KICAgICsJCXJldHVybjsNCiAgICArDQogICAgUVQ6ICBBY2suDQogICAgDQogICAgIAlxbF9k
YmcocWxfZGJnX2Rpc2MsIHZoYSwgMHgyMTE4LA0KICAgICAJICAgICIlcyAlZCAlOHBoQyBwb3N0
IFBSTElcbiIsDQogICAgIAkgICAgX19mdW5jX18sIF9fTElORV9fLCBlYS0+ZmNwb3J0LT5wb3J0
X25hbWUpOw0KICAgIC0tDQogICAgMi4yNC4wDQogICAgDQogICAgDQoNCg=
WARNING: multiple messages have this Message-ID (diff)
From: Himanshu Madhani <hmadhani@marvell.com>
To: Quinn Tran <qutran@marvell.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Cc: "linux@yadro.com" <linux@yadro.com>
Subject: Re: [EXT] [PATCH v2 05/15] scsi: qla2xxx: Allow PLOGI in target mode
Date: Thu, 21 Nov 2019 16:38:41 +0000 [thread overview]
Message-ID: <02BC133C-1758-4FD7-AD39-5B97AD4C6158@marvell.com> (raw)
In-Reply-To: <BYAPR18MB2759F79A6F217771C44CDF0BD54F0@BYAPR18MB2759.namprd18.prod.outlook.com>
On 11/20/19, 4:52 PM, "Quinn Tran" <qutran@marvell.com> wrote:
According to FC-LS-3 (Fibre Channel Link Services) 6.3.2.4 "N_Port Login - No Fabric present", if both parties in the point-to-point connection know N_Port_Names of each other, Nx_Port with the highest N_Port_name shall transmit PLOGI. The specification sets no restrictions on the port role that should send PLOGI.
However, FCP-4 (Fibre Channel Protocol for SCSI, Fourth Version) 6.2 "Overview of Process Login and Process Logout", instructs that in point-to-point topology, initiator shall send explicit PRLI ELS.
The change fixes stuck P2P login, when target WWPN is higher than initiator WWPN.
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
drivers/scsi/qla2xxx/qla_init.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index fcb309be50d9..12391815be06 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1527,10 +1527,6 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)
}
}
- /* for pure Target Mode. Login will not be initiated */
- if (vha->host->active_mode == MODE_TARGET)
- return 0;
-
QT: Nack. Leave this hunk. Instead do this
if (vha->host->active_mode == MODE_TARGET) && !N2N_TOPO(vha->hw)
--
Agree. Please resend with update.
if (fcport->flags & FCF_ASYNC_SENT) {
set_bit(RELOGIN_NEEDED, &vha->dpc_flags);
return 0;
@@ -1720,6 +1716,10 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, void qla_handle_els_plogi_done(scsi_qla_host_t *vha,
struct event_arg *ea)
{
+ /* for pure Target Mode, PRLI will not be initiated */
+ if (vha->host->active_mode == MODE_TARGET)
+ return;
+
QT: Ack.
ql_dbg(ql_dbg_disc, vha, 0x2118,
"%s %d %8phC post PRLI\n",
__func__, __LINE__, ea->fcport->port_name);
--
2.24.0
next prev parent reply other threads:[~2019-11-21 16:38 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 22:27 [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 01/15] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 02/15] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 03/15] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 04/15] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 05/15] scsi: qla2xxx: Allow PLOGI in target mode Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:52 ` [EXT] " Quinn Tran
2019-11-21 16:38 ` Himanshu Madhani [this message]
2019-11-21 16:38 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 06/15] scsi: qla2xxx: Don't call qlt_async_event twice Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 15:43 ` Himanshu Madhani
2019-11-21 15:43 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 07/15] scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 16:39 ` [EXT] " Himanshu Madhani
2019-11-21 16:39 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 08/15] scsi: qla2xxx: Configure local loop for N2N target Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 23:06 ` [EXT] " Quinn Tran
2019-11-21 16:39 ` Himanshu Madhani
2019-11-21 16:39 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 09/15] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 23:53 ` [EXT] " Quinn Tran
2019-11-21 16:40 ` Himanshu Madhani
2019-11-21 16:40 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 10/15] scsi: qla2xxx: Don't defer relogin unconditonally Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 0:03 ` [EXT] " Quinn Tran
2019-11-20 22:27 ` [PATCH v2 11/15] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 12/15] scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-23 4:58 ` kbuild test robot
2019-11-23 4:58 ` kbuild test robot
2019-11-23 4:58 ` kbuild test robot
2019-11-20 22:27 ` [PATCH v2 13/15] scsi: qla2xxx: Add async mode for qla24xx_els_dcmd_iocb Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 22:50 ` [EXT] " Quinn Tran
2019-11-22 5:04 ` Mark Harvey
2019-11-22 5:04 ` Mark Harvey
2019-11-22 17:00 ` Quinn Tran
2019-11-22 17:00 ` Quinn Tran
2019-11-24 19:15 ` Roman Bolshakov
2019-11-24 19:15 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 14/15] scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 16:37 ` Himanshu Madhani
2019-11-21 16:37 ` Himanshu Madhani
2019-11-21 22:52 ` [EXT] " Quinn Tran
2019-11-20 22:27 ` [PATCH v2 15/15] scsi: qla2xxx: Handle ABTS according to FCP spec for logged out ports Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-23 5:57 ` kbuild test robot
2019-11-23 5:57 ` kbuild test robot
2019-11-23 5:57 ` kbuild test robot
2019-11-22 9:14 ` [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Hannes Reinecke
2019-11-22 9:14 ` Hannes Reinecke
2019-11-22 21:36 ` Martin Wilck
2019-11-22 21:36 ` Martin Wilck
2019-11-24 18:31 ` Roman Bolshakov
2019-11-24 18:31 ` Roman Bolshakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02BC133C-1758-4FD7-AD39-5B97AD4C6158@marvell.com \
--to=hmadhani@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=qutran@marvell.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.