From: Roman Bolshakov <r.bolshakov@yadro.com> To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: linux@yadro.com, Roman Bolshakov <r.bolshakov@yadro.com> Subject: [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Date: Wed, 20 Nov 2019 22:27:08 +0000 [thread overview] Message-ID: <20191120222723.27779-1-r.bolshakov@yadro.com> (raw) Hi Martin, The patch series contains fixes for qla2xxx and solves two visible issues: - Target port in N2N topology doesn't perform login if it has higher WWPN than initiator - ABORT TASK TMF leads to crash if it's received shortly after ACL of an initiator is deleted and there's active I/O from the initiator It also contains reliability improvements and cleanups. Unfortunately, there's still an issue the latest patch. The discard works but ELS IOCB for LOGO is likely built incorrectly by qla24xx_els_dcmd_iocb(). The issue can also be exposed when "1" is written to fc_host/hostN/device/issue_logo file with logging turned on. Changes since v1 (https://patchwork.kernel.org/cover/11141979/): - Fixes target port in N2N mode were added (patches 5-11); - Target port makes explicit LOGO on session teardown in the patch made by Quinn. Together with patch 1, it helps to immediately turn fc_remote_port to the Blocked stated on client side and avoids visibly stuck session; - The last three patches address violation of FCP specification with regards to handling of ABTS-LS from ports that are not currently logged in. Thank you, Roman Quinn Tran (1): scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov (14): scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd scsi: qla2xxx: Initialize free_work before flushing it scsi: qla2xxx: Drop superfluous INIT_WORK of del_work scsi: qla2xxx: Change discovery state before PLOGI scsi: qla2xxx: Allow PLOGI in target mode scsi: qla2xxx: Don't call qlt_async_event twice scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length scsi: qla2xxx: Configure local loop for N2N target scsi: qla2xxx: Send Notify ACK after N2N PLOGI scsi: qla2xxx: Don't defer relogin unconditonally scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI scsi: qla2xxx: Add async mode for qla24xx_els_dcmd_iocb scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB scsi: qla2xxx: Handle ABTS according to FCP spec for logged out ports drivers/scsi/qla2xxx/qla_attr.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 21 ++++++--------- drivers/scsi/qla2xxx/qla_iocb.c | 42 ++++++++++++++++++++++++------ drivers/scsi/qla2xxx/qla_isr.c | 4 --- drivers/scsi/qla2xxx/qla_mbx.c | 3 ++- drivers/scsi/qla2xxx/qla_target.c | 34 ++++++++++++++++-------- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 3 +++ 9 files changed, 73 insertions(+), 39 deletions(-) -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: Roman Bolshakov <r.bolshakov@yadro.com> To: <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org> Cc: <linux@yadro.com>, Roman Bolshakov <r.bolshakov@yadro.com> Subject: [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Date: Thu, 21 Nov 2019 01:27:08 +0300 [thread overview] Message-ID: <20191120222723.27779-1-r.bolshakov@yadro.com> (raw) Hi Martin, The patch series contains fixes for qla2xxx and solves two visible issues: - Target port in N2N topology doesn't perform login if it has higher WWPN than initiator - ABORT TASK TMF leads to crash if it's received shortly after ACL of an initiator is deleted and there's active I/O from the initiator It also contains reliability improvements and cleanups. Unfortunately, there's still an issue the latest patch. The discard works but ELS IOCB for LOGO is likely built incorrectly by qla24xx_els_dcmd_iocb(). The issue can also be exposed when "1" is written to fc_host/hostN/device/issue_logo file with logging turned on. Changes since v1 (https://patchwork.kernel.org/cover/11141979/): - Fixes target port in N2N mode were added (patches 5-11); - Target port makes explicit LOGO on session teardown in the patch made by Quinn. Together with patch 1, it helps to immediately turn fc_remote_port to the Blocked stated on client side and avoids visibly stuck session; - The last three patches address violation of FCP specification with regards to handling of ABTS-LS from ports that are not currently logged in. Thank you, Roman Quinn Tran (1): scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov (14): scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd scsi: qla2xxx: Initialize free_work before flushing it scsi: qla2xxx: Drop superfluous INIT_WORK of del_work scsi: qla2xxx: Change discovery state before PLOGI scsi: qla2xxx: Allow PLOGI in target mode scsi: qla2xxx: Don't call qlt_async_event twice scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length scsi: qla2xxx: Configure local loop for N2N target scsi: qla2xxx: Send Notify ACK after N2N PLOGI scsi: qla2xxx: Don't defer relogin unconditonally scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI scsi: qla2xxx: Add async mode for qla24xx_els_dcmd_iocb scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB scsi: qla2xxx: Handle ABTS according to FCP spec for logged out ports drivers/scsi/qla2xxx/qla_attr.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 21 ++++++--------- drivers/scsi/qla2xxx/qla_iocb.c | 42 ++++++++++++++++++++++++------ drivers/scsi/qla2xxx/qla_isr.c | 4 --- drivers/scsi/qla2xxx/qla_mbx.c | 3 ++- drivers/scsi/qla2xxx/qla_target.c | 34 ++++++++++++++++-------- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 3 +++ 9 files changed, 73 insertions(+), 39 deletions(-) -- 2.24.0
next reply other threads:[~2019-11-20 22:27 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-20 22:27 Roman Bolshakov [this message] 2019-11-20 22:27 ` [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 01/15] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 02/15] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 03/15] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 04/15] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 05/15] scsi: qla2xxx: Allow PLOGI in target mode Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 22:52 ` [EXT] " Quinn Tran 2019-11-21 16:38 ` Himanshu Madhani 2019-11-21 16:38 ` Himanshu Madhani 2019-11-20 22:27 ` [PATCH v2 06/15] scsi: qla2xxx: Don't call qlt_async_event twice Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-21 15:43 ` Himanshu Madhani 2019-11-21 15:43 ` Himanshu Madhani 2019-11-20 22:27 ` [PATCH v2 07/15] scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-21 16:39 ` [EXT] " Himanshu Madhani 2019-11-21 16:39 ` Himanshu Madhani 2019-11-20 22:27 ` [PATCH v2 08/15] scsi: qla2xxx: Configure local loop for N2N target Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 23:06 ` [EXT] " Quinn Tran 2019-11-21 16:39 ` Himanshu Madhani 2019-11-21 16:39 ` Himanshu Madhani 2019-11-20 22:27 ` [PATCH v2 09/15] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 23:53 ` [EXT] " Quinn Tran 2019-11-21 16:40 ` Himanshu Madhani 2019-11-21 16:40 ` Himanshu Madhani 2019-11-20 22:27 ` [PATCH v2 10/15] scsi: qla2xxx: Don't defer relogin unconditonally Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-21 0:03 ` [EXT] " Quinn Tran 2019-11-20 22:27 ` [PATCH v2 11/15] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 12/15] scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-23 4:58 ` kbuild test robot 2019-11-23 4:58 ` kbuild test robot 2019-11-23 4:58 ` kbuild test robot 2019-11-20 22:27 ` [PATCH v2 13/15] scsi: qla2xxx: Add async mode for qla24xx_els_dcmd_iocb Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-21 22:50 ` [EXT] " Quinn Tran 2019-11-22 5:04 ` Mark Harvey 2019-11-22 5:04 ` Mark Harvey 2019-11-22 17:00 ` Quinn Tran 2019-11-22 17:00 ` Quinn Tran 2019-11-24 19:15 ` Roman Bolshakov 2019-11-24 19:15 ` Roman Bolshakov 2019-11-20 22:27 ` [PATCH v2 14/15] scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-21 16:37 ` Himanshu Madhani 2019-11-21 16:37 ` Himanshu Madhani 2019-11-21 22:52 ` [EXT] " Quinn Tran 2019-11-20 22:27 ` [PATCH v2 15/15] scsi: qla2xxx: Handle ABTS according to FCP spec for logged out ports Roman Bolshakov 2019-11-20 22:27 ` Roman Bolshakov 2019-11-23 5:57 ` kbuild test robot 2019-11-23 5:57 ` kbuild test robot 2019-11-23 5:57 ` kbuild test robot 2019-11-22 9:14 ` [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Hannes Reinecke 2019-11-22 9:14 ` Hannes Reinecke 2019-11-22 21:36 ` Martin Wilck 2019-11-22 21:36 ` Martin Wilck 2019-11-24 18:31 ` Roman Bolshakov 2019-11-24 18:31 ` Roman Bolshakov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191120222723.27779-1-r.bolshakov@yadro.com \ --to=r.bolshakov@yadro.com \ --cc=linux-scsi@vger.kernel.org \ --cc=linux@yadro.com \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.