From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Martin Wilck <mwilck@suse.de>
Cc: Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux@yadro.com
Subject: Re: [PATCH v2 00/15] scsi: qla2xxx: Bug fixes
Date: Sun, 24 Nov 2019 18:31:04 +0000 [thread overview]
Message-ID: <20191124183104.fg364dol5rol3xfh@SPB-NB-133.local> (raw)
In-Reply-To: <139c4a1040a9077fff39486f47134960d543ca53.camel@suse.de>
On Fri, Nov 22, 2019 at 10:36:06PM +0100, Martin Wilck wrote:
> On Fri, 2019-11-22 at 10:14 +0100, Hannes Reinecke wrote:
> > This patchset has the nice benefit that it has fixed the crashes on
> > rmmod we had been seeing.
>
> Well, I investigated two distinct crash-at-rmmod cases, and one was
> already fixed by the earlier commit f45bca8c5052 ("scsi: qla2xxx: Fix
> double scsi_done for abort path"), whereas the other is still present,
> even after applying this series.
>
> Not to say the series is bad - we just shouldn't raise expectations
> too high.
>
Hi Martin,
This patch series only fixes a crash when there's active I/O and ACL of
the initiator is getting deleted. The issue can be reproduced quite
easily:
1. Configure a target with 1 LUN and 1 ACL (and 1 Mapped LUN inside)
2. Run I/O from initiator
3. Delete ACL while running the I/O
The crash happens ~30s after the ACL is deleted when the initiator
starts sending ABORT TASK TMF to abort timed out I/O. It might happen at
rmmod time but that's just coincidence of ABORT TASK being processed. It
might not happen if a rig shuts off in less than 30 seconds.
Thanks,
Roman
WARNING: multiple messages have this Message-ID (diff)
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Martin Wilck <mwilck@suse.de>
Cc: Hannes Reinecke <hare@suse.de>, <linux-scsi@vger.kernel.org>,
<target-devel@vger.kernel.org>, <linux@yadro.com>
Subject: Re: [PATCH v2 00/15] scsi: qla2xxx: Bug fixes
Date: Sun, 24 Nov 2019 21:31:04 +0300 [thread overview]
Message-ID: <20191124183104.fg364dol5rol3xfh@SPB-NB-133.local> (raw)
In-Reply-To: <139c4a1040a9077fff39486f47134960d543ca53.camel@suse.de>
On Fri, Nov 22, 2019 at 10:36:06PM +0100, Martin Wilck wrote:
> On Fri, 2019-11-22 at 10:14 +0100, Hannes Reinecke wrote:
> > This patchset has the nice benefit that it has fixed the crashes on
> > rmmod we had been seeing.
>
> Well, I investigated two distinct crash-at-rmmod cases, and one was
> already fixed by the earlier commit f45bca8c5052 ("scsi: qla2xxx: Fix
> double scsi_done for abort path"), whereas the other is still present,
> even after applying this series.
>
> Not to say the series is bad - we just shouldn't raise expectations
> too high.
>
Hi Martin,
This patch series only fixes a crash when there's active I/O and ACL of
the initiator is getting deleted. The issue can be reproduced quite
easily:
1. Configure a target with 1 LUN and 1 ACL (and 1 Mapped LUN inside)
2. Run I/O from initiator
3. Delete ACL while running the I/O
The crash happens ~30s after the ACL is deleted when the initiator
starts sending ABORT TASK TMF to abort timed out I/O. It might happen at
rmmod time but that's just coincidence of ABORT TASK being processed. It
might not happen if a rig shuts off in less than 30 seconds.
Thanks,
Roman
next prev parent reply other threads:[~2019-11-24 18:31 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 22:27 [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 01/15] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 02/15] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 03/15] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 04/15] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 05/15] scsi: qla2xxx: Allow PLOGI in target mode Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:52 ` [EXT] " Quinn Tran
2019-11-21 16:38 ` Himanshu Madhani
2019-11-21 16:38 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 06/15] scsi: qla2xxx: Don't call qlt_async_event twice Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 15:43 ` Himanshu Madhani
2019-11-21 15:43 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 07/15] scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 16:39 ` [EXT] " Himanshu Madhani
2019-11-21 16:39 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 08/15] scsi: qla2xxx: Configure local loop for N2N target Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 23:06 ` [EXT] " Quinn Tran
2019-11-21 16:39 ` Himanshu Madhani
2019-11-21 16:39 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 09/15] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 23:53 ` [EXT] " Quinn Tran
2019-11-21 16:40 ` Himanshu Madhani
2019-11-21 16:40 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 10/15] scsi: qla2xxx: Don't defer relogin unconditonally Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 0:03 ` [EXT] " Quinn Tran
2019-11-20 22:27 ` [PATCH v2 11/15] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 12/15] scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-23 4:58 ` kbuild test robot
2019-11-23 4:58 ` kbuild test robot
2019-11-23 4:58 ` kbuild test robot
2019-11-20 22:27 ` [PATCH v2 13/15] scsi: qla2xxx: Add async mode for qla24xx_els_dcmd_iocb Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 22:50 ` [EXT] " Quinn Tran
2019-11-22 5:04 ` Mark Harvey
2019-11-22 5:04 ` Mark Harvey
2019-11-22 17:00 ` Quinn Tran
2019-11-22 17:00 ` Quinn Tran
2019-11-24 19:15 ` Roman Bolshakov
2019-11-24 19:15 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 14/15] scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 16:37 ` Himanshu Madhani
2019-11-21 16:37 ` Himanshu Madhani
2019-11-21 22:52 ` [EXT] " Quinn Tran
2019-11-20 22:27 ` [PATCH v2 15/15] scsi: qla2xxx: Handle ABTS according to FCP spec for logged out ports Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-23 5:57 ` kbuild test robot
2019-11-23 5:57 ` kbuild test robot
2019-11-23 5:57 ` kbuild test robot
2019-11-22 9:14 ` [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Hannes Reinecke
2019-11-22 9:14 ` Hannes Reinecke
2019-11-22 21:36 ` Martin Wilck
2019-11-22 21:36 ` Martin Wilck
2019-11-24 18:31 ` Roman Bolshakov [this message]
2019-11-24 18:31 ` Roman Bolshakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124183104.fg364dol5rol3xfh@SPB-NB-133.local \
--to=r.bolshakov@yadro.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=mwilck@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.