From: Himanshu Madhani <hmadhani@marvell.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Cc: "linux@yadro.com" <linux@yadro.com>, Quinn Tran <qutran@marvell.com>
Subject: Re: [PATCH v2 06/15] scsi: qla2xxx: Don't call qlt_async_event twice
Date: Thu, 21 Nov 2019 15:43:20 +0000 [thread overview]
Message-ID: <54622BCF-5D5B-4D7F-870B-D5B04E4030FB@marvell.com> (raw)
In-Reply-To: <20191120222723.27779-7-r.bolshakov@yadro.com>
DQoNCu+7v09uIDExLzIwLzE5LCA0OjI3IFBNLCAidGFyZ2V0LWRldmVsLW93bmVyQHZnZXIua2Vy
bmVsLm9yZyBvbiBiZWhhbGYgb2YgUm9tYW4gQm9sc2hha292IiA8dGFyZ2V0LWRldmVsLW93bmVy
QHZnZXIua2VybmVsLm9yZyBvbiBiZWhhbGYgb2Ygci5ib2xzaGFrb3ZAeWFkcm8uY29tPiB3cm90
ZToNCg0KICAgIE1CQV9QT1JUX1VQREFURSBnZW5lcmF0ZXMgZHVwbGljYXRlIGxvZyBsaW5lcyBp
biB0YXJnZXQgbW9kZSBiZWNhdXNlDQogICAgcWx0X2FzeW5jX2V2ZW50IGlzIGNhbGxlZCB0d2lj
ZS4gRHJvcCB0aGUgY2FsbHMgd2l0aGluIHRoZSBjYXNlIGFzDQogICAgdGhlIGZ1bmN0aW9uIHdp
bGwgYmUgY2FsbGVkIHJpZ2h0IGFmdGVyIHRoZSBzd2l0Y2ggc3RhdGVtZW50Lg0KICAgIA0KICAg
IENjOiBRdWlubiBUcmFuIDxxdXRyYW5AbWFydmVsbC5jb20+DQogICAgQ2M6IEhpbWFuc2h1IE1h
ZGhhbmkgPGhtYWRoYW5pQG1hcnZlbGwuY29tPg0KICAgIFNpZ25lZC1vZmYtYnk6IFJvbWFuIEJv
bHNoYWtvdiA8ci5ib2xzaGFrb3ZAeWFkcm8uY29tPg0KICAgIC0tLQ0KICAgICBkcml2ZXJzL3Nj
c2kvcWxhMnh4eC9xbGFfaXNyLmMgfCA0IC0tLS0NCiAgICAgMSBmaWxlIGNoYW5nZWQsIDQgZGVs
ZXRpb25zKC0pDQogICAgDQogICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3Fs
YV9pc3IuYyBiL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9pc3IuYw0KICAgIGluZGV4IDFiOGYy
OTc0NDljZi4uYzYyNzQxNzhiMGIwIDEwMDY0NA0KICAgIC0tLSBhL2RyaXZlcnMvc2NzaS9xbGEy
eHh4L3FsYV9pc3IuYw0KICAgICsrKyBiL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9pc3IuYw0K
ICAgIEBAIC0xMDYxLDggKzEwNjEsNiBAQCBxbGEyeDAwX2FzeW5jX2V2ZW50KHNjc2lfcWxhX2hv
c3RfdCAqdmhhLCBzdHJ1Y3QgcnNwX3F1ZSAqcnNwLCB1aW50MTZfdCAqbWIpDQogICAgIAkJCXFs
X2RiZyhxbF9kYmdfYXN5bmMsIHZoYSwgMHg1MDExLA0KICAgICAJCQkgICAgIkFzeW5jaHJvbm91
cyBQT1JUIFVQREFURSBpZ25vcmVkICUwNHgvJTA0eC8lMDR4LlxuIiwNCiAgICAgCQkJICAgIG1i
WzFdLCBtYlsyXSwgbWJbM10pOw0KICAgIC0NCiAgICAtCQkJcWx0X2FzeW5jX2V2ZW50KG1iWzBd
LCB2aGEsIG1iKTsNCiAgICAgCQkJYnJlYWs7DQogICAgIAkJfQ0KICAgICANCiAgICBAQCAtMTA3
OSw4ICsxMDc3LDYgQEAgcWxhMngwMF9hc3luY19ldmVudChzY3NpX3FsYV9ob3N0X3QgKnZoYSwg
c3RydWN0IHJzcF9xdWUgKnJzcCwgdWludDE2X3QgKm1iKQ0KICAgICAJCXNldF9iaXQoTE9PUF9S
RVNZTkNfTkVFREVELCAmdmhhLT5kcGNfZmxhZ3MpOw0KICAgICAJCXNldF9iaXQoTE9DQUxfTE9P
UF9VUERBVEUsICZ2aGEtPmRwY19mbGFncyk7DQogICAgIAkJc2V0X2JpdChWUF9DT05GSUdfT0ss
ICZ2aGEtPnZwX2ZsYWdzKTsNCiAgICAtDQogICAgLQkJcWx0X2FzeW5jX2V2ZW50KG1iWzBdLCB2
aGEsIG1iKTsNCiAgICAgCQlicmVhazsNCiAgICAgDQogICAgIAljYXNlIE1CQV9SU0NOX1VQREFU
RToJCS8qIFN0YXRlIENoYW5nZSBSZWdpc3RyYXRpb24gKi8NCiAgICAtLSANCiAgICAyLjI0LjAN
CiAgICANCiAgICANCg0KTG9va3MgR29vZC4gDQoNCkFja2VkLWJ5OiBIaW1hbnNodSBNYWRoYW5p
IDxobWFkaGFuaUBtYXJ2ZWwuY29tPg0KDQo
WARNING: multiple messages have this Message-ID (diff)
From: Himanshu Madhani <hmadhani@marvell.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Cc: "linux@yadro.com" <linux@yadro.com>, Quinn Tran <qutran@marvell.com>
Subject: Re: [PATCH v2 06/15] scsi: qla2xxx: Don't call qlt_async_event twice
Date: Thu, 21 Nov 2019 15:43:20 +0000 [thread overview]
Message-ID: <54622BCF-5D5B-4D7F-870B-D5B04E4030FB@marvell.com> (raw)
In-Reply-To: <20191120222723.27779-7-r.bolshakov@yadro.com>
On 11/20/19, 4:27 PM, "target-devel-owner@vger.kernel.org on behalf of Roman Bolshakov" <target-devel-owner@vger.kernel.org on behalf of r.bolshakov@yadro.com> wrote:
MBA_PORT_UPDATE generates duplicate log lines in target mode because
qlt_async_event is called twice. Drop the calls within the case as
the function will be called right after the switch statement.
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
drivers/scsi/qla2xxx/qla_isr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 1b8f297449cf..c6274178b0b0 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -1061,8 +1061,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
ql_dbg(ql_dbg_async, vha, 0x5011,
"Asynchronous PORT UPDATE ignored %04x/%04x/%04x.\n",
mb[1], mb[2], mb[3]);
-
- qlt_async_event(mb[0], vha, mb);
break;
}
@@ -1079,8 +1077,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags);
set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags);
set_bit(VP_CONFIG_OK, &vha->vp_flags);
-
- qlt_async_event(mb[0], vha, mb);
break;
case MBA_RSCN_UPDATE: /* State Change Registration */
--
2.24.0
Looks Good.
Acked-by: Himanshu Madhani <hmadhani@marvel.com>
next prev parent reply other threads:[~2019-11-21 15:43 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 22:27 [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 01/15] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 02/15] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 03/15] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 04/15] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 05/15] scsi: qla2xxx: Allow PLOGI in target mode Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:52 ` [EXT] " Quinn Tran
2019-11-21 16:38 ` Himanshu Madhani
2019-11-21 16:38 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 06/15] scsi: qla2xxx: Don't call qlt_async_event twice Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 15:43 ` Himanshu Madhani [this message]
2019-11-21 15:43 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 07/15] scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 16:39 ` [EXT] " Himanshu Madhani
2019-11-21 16:39 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 08/15] scsi: qla2xxx: Configure local loop for N2N target Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 23:06 ` [EXT] " Quinn Tran
2019-11-21 16:39 ` Himanshu Madhani
2019-11-21 16:39 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 09/15] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 23:53 ` [EXT] " Quinn Tran
2019-11-21 16:40 ` Himanshu Madhani
2019-11-21 16:40 ` Himanshu Madhani
2019-11-20 22:27 ` [PATCH v2 10/15] scsi: qla2xxx: Don't defer relogin unconditonally Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 0:03 ` [EXT] " Quinn Tran
2019-11-20 22:27 ` [PATCH v2 11/15] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 12/15] scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-23 4:58 ` kbuild test robot
2019-11-23 4:58 ` kbuild test robot
2019-11-23 4:58 ` kbuild test robot
2019-11-20 22:27 ` [PATCH v2 13/15] scsi: qla2xxx: Add async mode for qla24xx_els_dcmd_iocb Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 22:50 ` [EXT] " Quinn Tran
2019-11-22 5:04 ` Mark Harvey
2019-11-22 5:04 ` Mark Harvey
2019-11-22 17:00 ` Quinn Tran
2019-11-22 17:00 ` Quinn Tran
2019-11-24 19:15 ` Roman Bolshakov
2019-11-24 19:15 ` Roman Bolshakov
2019-11-20 22:27 ` [PATCH v2 14/15] scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-21 16:37 ` Himanshu Madhani
2019-11-21 16:37 ` Himanshu Madhani
2019-11-21 22:52 ` [EXT] " Quinn Tran
2019-11-20 22:27 ` [PATCH v2 15/15] scsi: qla2xxx: Handle ABTS according to FCP spec for logged out ports Roman Bolshakov
2019-11-20 22:27 ` Roman Bolshakov
2019-11-23 5:57 ` kbuild test robot
2019-11-23 5:57 ` kbuild test robot
2019-11-23 5:57 ` kbuild test robot
2019-11-22 9:14 ` [PATCH v2 00/15] scsi: qla2xxx: Bug fixes Hannes Reinecke
2019-11-22 9:14 ` Hannes Reinecke
2019-11-22 21:36 ` Martin Wilck
2019-11-22 21:36 ` Martin Wilck
2019-11-24 18:31 ` Roman Bolshakov
2019-11-24 18:31 ` Roman Bolshakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54622BCF-5D5B-4D7F-870B-D5B04E4030FB@marvell.com \
--to=hmadhani@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=qutran@marvell.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.