Re: [RFC 1/4] twl-regulator: extend for SMPS regulators and external controllers

[Liam Girdwood <lrg@ti.com>]

On Fri, 2011-07-08 at 17:56 +0200, Kristo, Tero wrote:
> This commit adds two things to the TWL regulator driver code :
> 
>  * It extends the twl4030_set_voltage() and twl4030_get_voltage()
>    functions to understand that VDD1 and VDD2 are different regulators
>    from all the other regulators: they don't support a fixed set of
>    voltages, but a wide range of voltages between two minimum and
>    maximum limits.
> 
>  * It creates a twlreg_ext_ctrl structure, which allows code outside
>    of the TWL regulator driver to implement a regulator
>    controller. Such a controller is attached using the new
>    twlreg_attach_external_controller() function of the driver. When
>    such a controller is attached to a regulator, the ->set_voltage()
>    and ->get_voltage() calls made on the regulator will be forwarded
>    to the external controller. This facility will later be used to
>    integrate the Voltage Controller and SmartReflex features of the
>    OMAP CPU with this regulator driver.

This just looks like it should just be another regulator to me. The
board will be responsible for setting up the client mapping (i.e.
whether it should use the "extended" or normal regulator).

Fwiw, Graeme has already done a lot of work on supporting Smartreflex
with TWL6025, it may be best to contact him to align your work.

Liam