All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Balbi, Felipe" <balbi@ti.com>,
	linux-omap@vger.kernel.org, "Girdwood, Liam" <lrg@ti.com>
Subject: Re: [RFC 0/4] TWL external controller support
Date: Mon, 11 Jul 2011 16:06:32 +0300	[thread overview]
Message-ID: <1310389592.4331.53.camel@sokoban> (raw)
In-Reply-To: <20110711121111.GL5092@opensource.wolfsonmicro.com>

On Mon, 2011-07-11 at 14:11 +0200, Mark Brown wrote:
> On Mon, Jul 11, 2011 at 01:48:59PM +0300, Tero Kristo wrote:
> > On Mon, 2011-07-11 at 12:05 +0200, Mark Brown wrote:
> 
> > > No.  Why do you want these regulators to have anything to do with the
> > > TWL4030?
> 
> > So, a completely new driver should be made for these? The reason I
> > wanted to put them within TWL4030 code is that they reside inside
> > TWL4030, and there is already some code for accessing these regulators
> > (in the standard I2C access method) from the twl-regulator.c.
> 
> Well, if they're not perceptibly part of the same chip from a control
> point of view and need you to provide board specific callbacks it would
> seem logical...

Ok sounds fair enough, I'll rework this series to something like this
and re-post for commenting once I hear from Graeme also. I'll add a
compile time switch (or most likely use something existing) for
selecting which implementation to use for VDD1 and VDD2.

Thanks for comments.

-Tero


Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6. Kotipaikka: Helsinki
 


      reply	other threads:[~2011-07-11 13:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08 15:56 [RFC 0/4] TWL external controller support Tero Kristo
2011-07-08 15:56 ` [RFC 1/4] twl-regulator: extend for SMPS regulators and external controllers Tero Kristo
2011-07-08 18:26   ` Liam Girdwood
2011-07-09  1:21   ` Mark Brown
2011-07-08 15:56 ` [RFC 2/4] omap3beagle: Instantiate VDD1 and VDD2 regulators Tero Kristo
2011-07-08 16:22   ` Felipe Balbi
2011-07-08 15:56 ` [RFC 3/4] omap: attach external controller to VDD1/VDD2 Tero Kristo
2011-07-08 16:23   ` Felipe Balbi
2011-07-08 15:56 ` [RFC 4/4] OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-07-08 16:23   ` Koen Kooi
2011-07-08 16:25 ` [RFC 0/4] TWL external controller support Felipe Balbi
2011-07-09  1:24   ` Mark Brown
2011-07-09 10:40     ` Felipe Balbi
2011-07-09 10:56       ` Mark Brown
2011-07-11  8:23         ` Tero Kristo
2011-07-11 10:05           ` Mark Brown
2011-07-11 10:48             ` Tero Kristo
2011-07-11 12:11               ` Mark Brown
2011-07-11 13:06                 ` Tero Kristo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310389592.4331.53.camel@sokoban \
    --to=t-kristo@ti.com \
    --cc=balbi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.