All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, lrg@ti.com,
	broonie@opensource.wolfsonmicro.com
Subject: Re: [RFC 0/4] TWL external controller support
Date: Fri, 8 Jul 2011 19:25:32 +0300	[thread overview]
Message-ID: <20110708162531.GE31978@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1310140588-26078-1-git-send-email-t-kristo@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

hi,

On Fri, Jul 08, 2011 at 06:56:24PM +0300, Tero Kristo wrote:
> Following patches add an external controller support for TWL SMPS regulators.
> This is needed because OMAP has voltage processor support which provides
> interface to control a few regulators (VDD1 / VDD2 for OMAP3), and this
> is shared with smartreflex.
> 
> These patches work in a way that twl regulators now provide an external
> controller registration interface, and this is used by the OMAP voltage
> layer during init. set_voltage / get_voltage APIs now check for presence
> of external controller, and if it is there, calls are routed to external
> controller.
> 
> Baseline work for these patches was done by Thomas Petezzoni.
> 
> Any comments welcome, does something like this look like it could be pushed
> to regulator framework?

isn't this all the same as claiming the regulator but never actually
using the regulator APIs ? I mean, you could add the regulator, then on
smartreflex code, regulator_get(), but when it gets to get/set voltage,
you use the omap_*() functions instead of regulator_*().

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  parent reply	other threads:[~2011-07-08 16:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08 15:56 [RFC 0/4] TWL external controller support Tero Kristo
2011-07-08 15:56 ` [RFC 1/4] twl-regulator: extend for SMPS regulators and external controllers Tero Kristo
2011-07-08 18:26   ` Liam Girdwood
2011-07-09  1:21   ` Mark Brown
2011-07-08 15:56 ` [RFC 2/4] omap3beagle: Instantiate VDD1 and VDD2 regulators Tero Kristo
2011-07-08 16:22   ` Felipe Balbi
2011-07-08 15:56 ` [RFC 3/4] omap: attach external controller to VDD1/VDD2 Tero Kristo
2011-07-08 16:23   ` Felipe Balbi
2011-07-08 15:56 ` [RFC 4/4] OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-07-08 16:23   ` Koen Kooi
2011-07-08 16:25 ` Felipe Balbi [this message]
2011-07-09  1:24   ` [RFC 0/4] TWL external controller support Mark Brown
2011-07-09 10:40     ` Felipe Balbi
2011-07-09 10:56       ` Mark Brown
2011-07-11  8:23         ` Tero Kristo
2011-07-11 10:05           ` Mark Brown
2011-07-11 10:48             ` Tero Kristo
2011-07-11 12:11               ` Mark Brown
2011-07-11 13:06                 ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110708162531.GE31978@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.