From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, lrg@ti.com,
Thomas Petazzoni <t-petazzoni@ti.com>
Subject: Re: [RFC 1/4] twl-regulator: extend for SMPS regulators and external controllers
Date: Sat, 9 Jul 2011 10:21:20 +0900 [thread overview]
Message-ID: <20110709012118.GF18860@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1310140588-26078-2-git-send-email-t-kristo@ti.com>
On Fri, Jul 08, 2011 at 06:56:25PM +0300, Tero Kristo wrote:
> This commit adds two things to the TWL regulator driver code :
Why is this one commit rather than two commits implementing the two
changes?
> * It creates a twlreg_ext_ctrl structure, which allows code outside
> of the TWL regulator driver to implement a regulator
> controller. Such a controller is attached using the new
> twlreg_attach_external_controller() function of the driver. When
> such a controller is attached to a regulator, the ->set_voltage()
> and ->get_voltage() calls made on the regulator will be forwarded
> to the external controller. This facility will later be used to
> integrate the Voltage Controller and SmartReflex features of the
> OMAP CPU with this regulator driver.
The regulator API has perfectly good support for multiple regulators in
the system already, why would this driver know anything about other
regulators in the system? If there is something missing why are you
implementing it in a driver and not the core?
I've not read the actual patch.
next prev parent reply other threads:[~2011-07-09 1:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 15:56 [RFC 0/4] TWL external controller support Tero Kristo
2011-07-08 15:56 ` [RFC 1/4] twl-regulator: extend for SMPS regulators and external controllers Tero Kristo
2011-07-08 18:26 ` Liam Girdwood
2011-07-09 1:21 ` Mark Brown [this message]
2011-07-08 15:56 ` [RFC 2/4] omap3beagle: Instantiate VDD1 and VDD2 regulators Tero Kristo
2011-07-08 16:22 ` Felipe Balbi
2011-07-08 15:56 ` [RFC 3/4] omap: attach external controller to VDD1/VDD2 Tero Kristo
2011-07-08 16:23 ` Felipe Balbi
2011-07-08 15:56 ` [RFC 4/4] OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-07-08 16:23 ` Koen Kooi
2011-07-08 16:25 ` [RFC 0/4] TWL external controller support Felipe Balbi
2011-07-09 1:24 ` Mark Brown
2011-07-09 10:40 ` Felipe Balbi
2011-07-09 10:56 ` Mark Brown
2011-07-11 8:23 ` Tero Kristo
2011-07-11 10:05 ` Mark Brown
2011-07-11 10:48 ` Tero Kristo
2011-07-11 12:11 ` Mark Brown
2011-07-11 13:06 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110709012118.GF18860@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=t-kristo@ti.com \
--cc=t-petazzoni@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.