Re: [RFC 2/4] omap3beagle: Instantiate VDD1 and VDD2 regulators

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]

Hi,

On Fri, Jul 08, 2011 at 06:56:26PM +0300, Tero Kristo wrote:
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Instantiate the VDD1 and VDD2 regulators and connect them to their
> respective consumers: mpu.0 for VDD1 and l3_main.0 for VDD2.
> 
> TODO:
> 
>  * As these instantiations will be identical for all OMAP3 boards,
>    find a way of sharing them throughout the different OMAP3 boards.
> 
> Signed-off-by: Thomas Petazzoni <t-petazzoni@ti.com>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |   35 +++++++++++++++++++++++++++++++
>  1 files changed, 35 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 78cf5f2..6d3a266 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -24,6 +24,7 @@
>  #include <linux/input.h>
>  #include <linux/gpio_keys.h>
>  #include <linux/opp.h>
> +#include <linux/regulator/driver.h>
>  
>  #include <linux/mtd/mtd.h>
>  #include <linux/mtd/partitions.h>
> @@ -400,6 +401,38 @@ static struct regulator_init_data beagle_vpll2 = {
>  	.consumer_supplies	= beagle_vdvi_supplies,
>  };
>  
> +static struct regulator_consumer_supply beagle_vdd1_supply =

should be array.

> +	REGULATOR_SUPPLY("vcc", "mpu.0");
> +
> +static struct regulator_consumer_supply beagle_vdd2_supply =

should be array

> +	REGULATOR_SUPPLY("vcc", "l3_main.0");
> +
> +static struct regulator_init_data beagle_vdd1 = {
> +	.constraints = {
> +		.name			= "VDD1",
> +		.min_uV			= 600000,
> +		.max_uV			= 1450000,
> +		.valid_modes_mask	= REGULATOR_MODE_NORMAL
> +					| REGULATOR_MODE_STANDBY,
> +		.valid_ops_mask		= REGULATOR_CHANGE_VOLTAGE,
> +	},
> +	.num_consumer_supplies	= 1,

ARRAY_SIZE(beagle_vdd1_supply)

> +	.consumer_supplies	= &beagle_vdd1_supply,
> +};
> +
> +static struct regulator_init_data beagle_vdd2 = {
> +	.constraints = {
> +		.name			= "VDD2",
> +		.min_uV			= 600000,
> +		.max_uV			= 1450000,
> +		.valid_modes_mask	= REGULATOR_MODE_NORMAL
> +					| REGULATOR_MODE_STANDBY,
> +		.valid_ops_mask		= REGULATOR_CHANGE_VOLTAGE,
> +	},
> +	.num_consumer_supplies	= 1,

ARRAY_SIZE(beagle_vdd1_supply)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]