All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Andrew Fish <afish@apple.com>,
	edk2-devel@lists.sourceforge.net, linux-efi@vger.kernel.org,
	Gleb Natapov <gleb@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [edk2] Corrupted EFI region
Date: Mon, 05 Aug 2013 15:52:37 -0700	[thread overview]
Message-ID: <1375743157.18481.14.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <52001F6B.4000800@redhat.com>

On Mon, 2013-08-05 at 23:55 +0200, Laszlo Ersek wrote:
> On 08/05/13 23:41, Borislav Petkov wrote:
> > On Mon, Aug 05, 2013 at 02:37:08PM -0700, H. Peter Anvin wrote:
> >> All of this would be a non-problem if there weren't buggy
> >> implementations which can't run *without* SetVirtualAddressMap().
> > 
> > Oh, you mean, if we were to call the runtime services through their
> > physical addresses?
> 
> I heard that there was a (U)EFI firmware implementation that didn't even
> implement SetVirtualAddressMap(). It was okay because the main OS for
> that platform didn't want to call it, it thunked to physical mode for
> each runtime service call.
> 
> (This is not hearsay; I'm omitting the specifics because I'm not sure if
> I'm allowed to give any. I've heard about this stuff from a direct
> colleague who used to work on these systems.)

That's actually the way all non-x86 unix systems operate.  If you look
in the firmware mechanisms for almost every non-x86 system in the Linux
kernel architecture directories they do this if they have to access
firmware from Linux (we do it a lot on parisc to get the IODC to give us
the device inventory for instance).

I strongly suspect the origin of this weirdness is that once upon a time
windows didn't run with a separated address space and so needed a way of
accessing firmware in the same address space, hence the pointer
relocation trick, but even windows hasn't needed this for a while.

James



WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
To: Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	Andrew Fish <afish-2kanFRK1NckAvxtiuMwx3w@public.gmane.org>,
	edk2-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Gleb Natapov <gleb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [edk2] Corrupted EFI region
Date: Mon, 05 Aug 2013 15:52:37 -0700	[thread overview]
Message-ID: <1375743157.18481.14.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <52001F6B.4000800-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Mon, 2013-08-05 at 23:55 +0200, Laszlo Ersek wrote:
> On 08/05/13 23:41, Borislav Petkov wrote:
> > On Mon, Aug 05, 2013 at 02:37:08PM -0700, H. Peter Anvin wrote:
> >> All of this would be a non-problem if there weren't buggy
> >> implementations which can't run *without* SetVirtualAddressMap().
> > 
> > Oh, you mean, if we were to call the runtime services through their
> > physical addresses?
> 
> I heard that there was a (U)EFI firmware implementation that didn't even
> implement SetVirtualAddressMap(). It was okay because the main OS for
> that platform didn't want to call it, it thunked to physical mode for
> each runtime service call.
> 
> (This is not hearsay; I'm omitting the specifics because I'm not sure if
> I'm allowed to give any. I've heard about this stuff from a direct
> colleague who used to work on these systems.)

That's actually the way all non-x86 unix systems operate.  If you look
in the firmware mechanisms for almost every non-x86 system in the Linux
kernel architecture directories they do this if they have to access
firmware from Linux (we do it a lot on parisc to get the IODC to give us
the device inventory for instance).

I strongly suspect the origin of this weirdness is that once upon a time
windows didn't run with a separated address space and so needed a way of
accessing firmware in the same address space, hence the pointer
relocation trick, but even windows hasn't needed this for a while.

James

  reply	other threads:[~2013-08-05 22:52 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 20:54 Corrupted EFI region Borislav Petkov
2013-07-31 20:54 ` Borislav Petkov
2013-07-31 20:58 ` Matthew Garrett
2013-07-31 20:58   ` Matthew Garrett
2013-07-31 21:51   ` Borislav Petkov
2013-07-31 21:51     ` Borislav Petkov
2013-07-31 21:54     ` Matthew Garrett
2013-07-31 21:54       ` Matthew Garrett
2013-08-01 16:51       ` Borislav Petkov
2013-08-01 16:51         ` Borislav Petkov
2013-07-31 21:55 ` David Woodhouse
2013-07-31 21:55   ` David Woodhouse
2013-08-01 16:49   ` Borislav Petkov
2013-08-01 16:49     ` Borislav Petkov
2013-08-05 11:27     ` [edk2] " Laszlo Ersek
2013-08-05 11:27       ` Laszlo Ersek
2013-08-05 13:02       ` Borislav Petkov
2013-08-05 13:02         ` Borislav Petkov
2013-08-05 13:39         ` Laszlo Ersek
2013-08-05 13:39           ` Laszlo Ersek
2013-08-05 14:03           ` Borislav Petkov
2013-08-05 14:03             ` Borislav Petkov
2013-08-05 14:27             ` Laszlo Ersek
2013-08-05 14:27               ` Laszlo Ersek
2013-08-05 14:40               ` Borislav Petkov
2013-08-05 14:40                 ` Borislav Petkov
2013-08-05 15:15                 ` Laszlo Ersek
2013-08-05 15:15                   ` Laszlo Ersek
2013-08-05 15:34                   ` James Bottomley
2013-08-05 15:34                     ` James Bottomley
2013-08-05 16:27                     ` Laszlo Ersek
2013-08-05 16:27                       ` Laszlo Ersek
2013-08-05 16:12                   ` Borislav Petkov
2013-08-05 16:12                     ` Borislav Petkov
2013-08-05 16:41                     ` Laszlo Ersek
2013-08-05 16:41                       ` Laszlo Ersek
2013-08-05 16:47                       ` Borislav Petkov
2013-08-05 16:47                         ` Borislav Petkov
2013-08-05 17:00                         ` Kinney, Michael D
2013-08-05 17:00                           ` Kinney, Michael D
2013-08-05 17:09                         ` Laszlo Ersek
2013-08-05 17:09                           ` Laszlo Ersek
2013-08-05 21:26                         ` Laszlo Ersek
2013-08-05 21:26                           ` Laszlo Ersek
2013-08-05 22:08                           ` Borislav Petkov
2013-08-05 22:08                             ` Borislav Petkov
2013-08-06 14:10                             ` Borislav Petkov
2013-08-06 14:10                               ` Borislav Petkov
2013-08-06 15:31                               ` Laszlo Ersek
2013-08-06 15:31                                 ` Laszlo Ersek
2013-08-07 15:19                                 ` Borislav Petkov
2013-08-07 17:23                                   ` Andrew Fish
2013-08-07 17:23                                     ` Andrew Fish
2013-08-07 20:19                                     ` Matt Fleming
2013-08-07 20:19                                       ` Matt Fleming
2013-08-07 20:24                                       ` Matt Fleming
2013-08-07 20:24                                         ` Matt Fleming
2013-08-07 21:10                                       ` Andrew Fish
2013-08-07 21:10                                         ` Andrew Fish
2013-08-07 21:23                                         ` Matthew Garrett
2013-08-08 10:17                                         ` Matt Fleming
2013-08-08 10:17                                           ` Matt Fleming
2013-08-08 13:46                                           ` Andrew Fish
2013-08-08 13:46                                             ` Andrew Fish
2013-09-02  8:19                                             ` Matt Fleming
2013-09-02  8:19                                               ` Matt Fleming
2013-09-13 20:38                                           ` jerry.hoemann
2013-09-13 20:38                                             ` jerry.hoemann-VXdhtT5mjnY
2013-09-16 10:59                                             ` Matt Fleming
2013-09-16 10:59                                               ` Matt Fleming
2013-09-16 11:50                                               ` Laszlo Ersek
2013-09-16 11:50                                                 ` Laszlo Ersek
2013-09-16 15:57                                                 ` Josh Triplett
2013-09-16 15:57                                                   ` Josh Triplett
2013-09-16 16:25                                                   ` Laszlo Ersek
2013-09-16 16:25                                                     ` Laszlo Ersek
2013-09-16 16:27                                                     ` Matthew Garrett
2013-09-16 16:27                                                       ` Matthew Garrett
2013-09-16 16:29                                                     ` Josh Triplett
2013-09-16 16:29                                                       ` Josh Triplett
2013-09-18 19:24                                               ` jerry.hoemann
2013-09-18 19:24                                                 ` jerry.hoemann-VXdhtT5mjnY
2013-09-20  9:06                                                 ` Matt Fleming
2013-09-20  9:06                                                   ` Matt Fleming
2013-08-07 17:49                                   ` Laszlo Ersek
2013-08-07 17:49                                     ` Laszlo Ersek
2013-08-08 15:02                                     ` Borislav Petkov
2013-08-08 15:02                                       ` Borislav Petkov
2013-08-08 21:45                                       ` Brian J. Johnson
2013-08-08 21:45                                         ` Brian J. Johnson
2013-08-18  7:33                                     ` Jordan Justen
2013-08-18  7:33                                       ` Jordan Justen
2013-08-05 15:50                 ` Andrew Fish
2013-08-05 15:50                   ` Andrew Fish
2013-08-05 18:12                   ` Borislav Petkov
2013-08-05 18:12                     ` Borislav Petkov
2013-08-05 21:37                     ` H. Peter Anvin
2013-08-05 21:37                       ` H. Peter Anvin
2013-08-05 21:41                       ` Borislav Petkov
2013-08-05 21:41                         ` Borislav Petkov
2013-08-05 21:49                         ` H. Peter Anvin
2013-08-05 21:49                           ` H. Peter Anvin
2013-08-05 21:55                         ` Laszlo Ersek
2013-08-05 21:55                           ` Laszlo Ersek
2013-08-05 22:52                           ` James Bottomley [this message]
2013-08-05 22:52                             ` James Bottomley
2013-08-06  7:26                             ` Laszlo Ersek
2013-08-06  7:26                               ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375743157.18481.14.camel@dabdike.int.hansenpartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=afish@apple.com \
    --cc=bp@alien8.de \
    --cc=dwmw2@infradead.org \
    --cc=edk2-devel@lists.sourceforge.net \
    --cc=gleb@redhat.com \
    --cc=hpa@zytor.com \
    --cc=lersek@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.