From: Borislav Petkov <bp@alien8.de> To: Laszlo Ersek <lersek@redhat.com> Cc: edk2-devel@lists.sourceforge.net, David Woodhouse <dwmw2@infradead.org>, linux-efi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>, Matthew Garrett <mjg59@srcf.ucam.org> Subject: Re: [edk2] Corrupted EFI region Date: Tue, 6 Aug 2013 00:08:08 +0200 [thread overview] Message-ID: <20130805220808.GC14067@pd.tnic> (raw) In-Reply-To: <52001896.1030509@redhat.com> On Mon, Aug 05, 2013 at 11:26:46PM +0200, Laszlo Ersek wrote: > What happens if you pass "memblock=debug" on the kernel command line > (see early_memblock() in "mm/memblock.c")? > > (I just tried it in my Fedora 19 guest, and it in fact produced the message > > [ 0.000000] efi: Could not reserve boot range [0x0000800000-0x0000ffffff] Note to self: Always look for bugs in Linux' UEFI code first, before going anywhere else! Yes, very good analysis and good job Laszlo! I'll write what I see now but will doublecheck it tomorrow because I'm almost half asleep. [ 0.000000] efi: efi_reserve_boot_services: -> start: 0x7e0ad000, size: 0x1f000 [ 0.000000] efi: Could not reserve boot range [0x007e0ad000-0x007e0cbfff] And yes, this fails because memblock_is_region_reserved(start, size) returns true. And why is that: [ 0.000000] memblock_reserve: [0x000000036be000-0x000000036c3000] setup_arch+0x60e/0xa63 [ 0.000000] MEMBLOCK configuration: [ 0.000000] memory size = 0x7fef1000 reserved size = 0x1724570 [ 0.000000] memory.cnt = 0x4 [ 0.000000] memory[0x0] [0x00000000001000-0x0000000009ffff], 0x9f000 bytes [ 0.000000] memory[0x1] [0x00000000100000-0x0000007e667fff], 0x7e568000 bytes [ 0.000000] memory[0x2] [0x0000007e692000-0x0000007fb11fff], 0x1480000 bytes [ 0.000000] memory[0x3] [0x0000007fb76000-0x0000007ffdffff], 0x46a000 bytes [ 0.000000] reserved.cnt = 0x3 [ 0.000000] reserved[0x0] [0x0000000009f000-0x000000000fffff], 0x61000 bytes [ 0.000000] reserved[0x1] [0x00000002000000-0x000000036c2fff], 0x16c3000 bytes [ 0.000000] reserved[0x2] [0x0000007e0ad018-0x0000007e0ad587], 0x570 bytes ^^^^^^^^^ There are 0x570 bytes right in this region which are memblock-reserved and so we truncate it in efi_reserve_boot_services(). This makes me say words which will offend this list so I'll instead go out on the balcony and wake up the neighbors. :-) Ok, thanks again for finding it, I'll go and try to figure out the whole mess tomorrow. Good night! > BTW, regarding Michael's answer, I think this is just one of several > ways in which Linux manipulates the EFI memmap between (b) and (c). > For example it seems to merge ranges in the map. Yes, it does so in efi_enter_virtual_mode(). That was my initial suspicion, that's why I dumped the regions before the merging. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de> To: Laszlo Ersek <lersek@redhat.com> Cc: linux-efi@vger.kernel.org, Gleb Natapov <gleb@redhat.com>, edk2-devel@lists.sourceforge.net, lkml <linux-kernel@vger.kernel.org>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [edk2] Corrupted EFI region Date: Tue, 6 Aug 2013 00:08:08 +0200 [thread overview] Message-ID: <20130805220808.GC14067@pd.tnic> (raw) In-Reply-To: <52001896.1030509@redhat.com> On Mon, Aug 05, 2013 at 11:26:46PM +0200, Laszlo Ersek wrote: > What happens if you pass "memblock=debug" on the kernel command line > (see early_memblock() in "mm/memblock.c")? > > (I just tried it in my Fedora 19 guest, and it in fact produced the message > > [ 0.000000] efi: Could not reserve boot range [0x0000800000-0x0000ffffff] Note to self: Always look for bugs in Linux' UEFI code first, before going anywhere else! Yes, very good analysis and good job Laszlo! I'll write what I see now but will doublecheck it tomorrow because I'm almost half asleep. [ 0.000000] efi: efi_reserve_boot_services: -> start: 0x7e0ad000, size: 0x1f000 [ 0.000000] efi: Could not reserve boot range [0x007e0ad000-0x007e0cbfff] And yes, this fails because memblock_is_region_reserved(start, size) returns true. And why is that: [ 0.000000] memblock_reserve: [0x000000036be000-0x000000036c3000] setup_arch+0x60e/0xa63 [ 0.000000] MEMBLOCK configuration: [ 0.000000] memory size = 0x7fef1000 reserved size = 0x1724570 [ 0.000000] memory.cnt = 0x4 [ 0.000000] memory[0x0] [0x00000000001000-0x0000000009ffff], 0x9f000 bytes [ 0.000000] memory[0x1] [0x00000000100000-0x0000007e667fff], 0x7e568000 bytes [ 0.000000] memory[0x2] [0x0000007e692000-0x0000007fb11fff], 0x1480000 bytes [ 0.000000] memory[0x3] [0x0000007fb76000-0x0000007ffdffff], 0x46a000 bytes [ 0.000000] reserved.cnt = 0x3 [ 0.000000] reserved[0x0] [0x0000000009f000-0x000000000fffff], 0x61000 bytes [ 0.000000] reserved[0x1] [0x00000002000000-0x000000036c2fff], 0x16c3000 bytes [ 0.000000] reserved[0x2] [0x0000007e0ad018-0x0000007e0ad587], 0x570 bytes ^^^^^^^^^ There are 0x570 bytes right in this region which are memblock-reserved and so we truncate it in efi_reserve_boot_services(). This makes me say words which will offend this list so I'll instead go out on the balcony and wake up the neighbors. :-) Ok, thanks again for finding it, I'll go and try to figure out the whole mess tomorrow. Good night! > BTW, regarding Michael's answer, I think this is just one of several > ways in which Linux manipulates the EFI memmap between (b) and (c). > For example it seems to merge ranges in the map. Yes, it does so in efi_enter_virtual_mode(). That was my initial suspicion, that's why I dumped the regions before the merging. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
next prev parent reply other threads:[~2013-08-05 22:08 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-31 20:54 Corrupted EFI region Borislav Petkov 2013-07-31 20:54 ` Borislav Petkov 2013-07-31 20:58 ` Matthew Garrett 2013-07-31 20:58 ` Matthew Garrett 2013-07-31 21:51 ` Borislav Petkov 2013-07-31 21:51 ` Borislav Petkov 2013-07-31 21:54 ` Matthew Garrett 2013-07-31 21:54 ` Matthew Garrett 2013-08-01 16:51 ` Borislav Petkov 2013-08-01 16:51 ` Borislav Petkov 2013-07-31 21:55 ` David Woodhouse 2013-07-31 21:55 ` David Woodhouse 2013-08-01 16:49 ` Borislav Petkov 2013-08-01 16:49 ` Borislav Petkov 2013-08-05 11:27 ` [edk2] " Laszlo Ersek 2013-08-05 11:27 ` Laszlo Ersek 2013-08-05 13:02 ` Borislav Petkov 2013-08-05 13:02 ` Borislav Petkov 2013-08-05 13:39 ` Laszlo Ersek 2013-08-05 13:39 ` Laszlo Ersek 2013-08-05 14:03 ` Borislav Petkov 2013-08-05 14:03 ` Borislav Petkov 2013-08-05 14:27 ` Laszlo Ersek 2013-08-05 14:27 ` Laszlo Ersek 2013-08-05 14:40 ` Borislav Petkov 2013-08-05 14:40 ` Borislav Petkov 2013-08-05 15:15 ` Laszlo Ersek 2013-08-05 15:15 ` Laszlo Ersek 2013-08-05 15:34 ` James Bottomley 2013-08-05 15:34 ` James Bottomley 2013-08-05 16:27 ` Laszlo Ersek 2013-08-05 16:27 ` Laszlo Ersek 2013-08-05 16:12 ` Borislav Petkov 2013-08-05 16:12 ` Borislav Petkov 2013-08-05 16:41 ` Laszlo Ersek 2013-08-05 16:41 ` Laszlo Ersek 2013-08-05 16:47 ` Borislav Petkov 2013-08-05 16:47 ` Borislav Petkov 2013-08-05 17:00 ` Kinney, Michael D 2013-08-05 17:00 ` Kinney, Michael D 2013-08-05 17:09 ` Laszlo Ersek 2013-08-05 17:09 ` Laszlo Ersek 2013-08-05 21:26 ` Laszlo Ersek 2013-08-05 21:26 ` Laszlo Ersek 2013-08-05 22:08 ` Borislav Petkov [this message] 2013-08-05 22:08 ` Borislav Petkov 2013-08-06 14:10 ` Borislav Petkov 2013-08-06 14:10 ` Borislav Petkov 2013-08-06 15:31 ` Laszlo Ersek 2013-08-06 15:31 ` Laszlo Ersek 2013-08-07 15:19 ` Borislav Petkov 2013-08-07 17:23 ` Andrew Fish 2013-08-07 17:23 ` Andrew Fish 2013-08-07 20:19 ` Matt Fleming 2013-08-07 20:19 ` Matt Fleming 2013-08-07 20:24 ` Matt Fleming 2013-08-07 20:24 ` Matt Fleming 2013-08-07 21:10 ` Andrew Fish 2013-08-07 21:10 ` Andrew Fish 2013-08-07 21:23 ` Matthew Garrett 2013-08-08 10:17 ` Matt Fleming 2013-08-08 10:17 ` Matt Fleming 2013-08-08 13:46 ` Andrew Fish 2013-08-08 13:46 ` Andrew Fish 2013-09-02 8:19 ` Matt Fleming 2013-09-02 8:19 ` Matt Fleming 2013-09-13 20:38 ` jerry.hoemann 2013-09-13 20:38 ` jerry.hoemann-VXdhtT5mjnY 2013-09-16 10:59 ` Matt Fleming 2013-09-16 10:59 ` Matt Fleming 2013-09-16 11:50 ` Laszlo Ersek 2013-09-16 11:50 ` Laszlo Ersek 2013-09-16 15:57 ` Josh Triplett 2013-09-16 15:57 ` Josh Triplett 2013-09-16 16:25 ` Laszlo Ersek 2013-09-16 16:25 ` Laszlo Ersek 2013-09-16 16:27 ` Matthew Garrett 2013-09-16 16:27 ` Matthew Garrett 2013-09-16 16:29 ` Josh Triplett 2013-09-16 16:29 ` Josh Triplett 2013-09-18 19:24 ` jerry.hoemann 2013-09-18 19:24 ` jerry.hoemann-VXdhtT5mjnY 2013-09-20 9:06 ` Matt Fleming 2013-09-20 9:06 ` Matt Fleming 2013-08-07 17:49 ` Laszlo Ersek 2013-08-07 17:49 ` Laszlo Ersek 2013-08-08 15:02 ` Borislav Petkov 2013-08-08 15:02 ` Borislav Petkov 2013-08-08 21:45 ` Brian J. Johnson 2013-08-08 21:45 ` Brian J. Johnson 2013-08-18 7:33 ` Jordan Justen 2013-08-18 7:33 ` Jordan Justen 2013-08-05 15:50 ` Andrew Fish 2013-08-05 15:50 ` Andrew Fish 2013-08-05 18:12 ` Borislav Petkov 2013-08-05 18:12 ` Borislav Petkov 2013-08-05 21:37 ` H. Peter Anvin 2013-08-05 21:37 ` H. Peter Anvin 2013-08-05 21:41 ` Borislav Petkov 2013-08-05 21:41 ` Borislav Petkov 2013-08-05 21:49 ` H. Peter Anvin 2013-08-05 21:49 ` H. Peter Anvin 2013-08-05 21:55 ` Laszlo Ersek 2013-08-05 21:55 ` Laszlo Ersek 2013-08-05 22:52 ` James Bottomley 2013-08-05 22:52 ` James Bottomley 2013-08-06 7:26 ` Laszlo Ersek 2013-08-06 7:26 ` Laszlo Ersek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130805220808.GC14067@pd.tnic \ --to=bp@alien8.de \ --cc=dwmw2@infradead.org \ --cc=edk2-devel@lists.sourceforge.net \ --cc=gleb@redhat.com \ --cc=lersek@redhat.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mjg59@srcf.ucam.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.