All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: edk2-devel@lists.sourceforge.net,
	David Woodhouse <dwmw2@infradead.org>,
	linux-efi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	Gleb Natapov <gleb@redhat.com>,
	Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [edk2] Corrupted EFI region
Date: Mon, 05 Aug 2013 13:27:16 +0200	[thread overview]
Message-ID: <51FF8C14.2070405@redhat.com> (raw)
In-Reply-To: <20130801164927.GA7445@pd.tnic>

On 08/01/13 18:49, Borislav Petkov wrote:
> On Wed, Jul 31, 2013 at 10:55:27PM +0100, David Woodhouse wrote:
>> On Wed, 2013-07-31 at 22:54 +0200, Borislav Petkov wrote:
>>> so I'm seeing this funny thing where an EFI region changes when we enter
>>> efi_enter_virtual_mode when booting with edk2 on kvm. Here's the diff:
>>
>> Perhaps the edk2-devel@lists.sourceforge.net list should be in Cc?
> 
> Good idea and message repeated below.
> 
> One more thing: I'm using a self-built OVMF with top commit from March:
> 
> ------------------------------------------------------------------------
> r14165 | sfu5 | 2013-03-06 02:42:04 +0100 (Wed, 06 Mar 2013) | 4 lines
> 
> Fix a bug that IsSignatureFoundInDatabase() incorrectly computes CertCount.
> 
> ---
> 
> Hi guys,
> 
> so I'm seeing this funny thing where an EFI region changes when we enter
> efi_enter_virtual_mode when booting with edk2 on kvm. Here's the diff:
> 
> --- before      2013-07-31 22:20:52.316039492 +0200
> +++ after       2013-07-31 22:21:30.960731706 +0200
> @@ -9,7 +9,7 @@ efi: mem07: type=2, attr=0xf, range=[0x0
>  efi: mem08: type=7, attr=0xf, range=[0x0000000040000000-0x000000007c000000) (960MB)
>  efi: mem09: type=4, attr=0xf, range=[0x000000007c000000-0x000000007c020000) (0MB)
>  efi: mem10: type=7, attr=0xf, range=[0x000000007c020000-0x000000007e0ad000) (32MB)
> -efi: mem11: type=4, attr=0xf, range=[0x000000007e0ad000-0x000000007e0cc000) (0MB)
> +efi: mem11: type=4, attr=0xf, range=[0x000000007e0ad000-0x000000007e0ad000) (0MB)

(type 4 is EfiBootServicesData)

>  efi: mem12: type=7, attr=0xf, range=[0x000000007e0cc000-0x000000007e0cd000) (0MB)
>  efi: mem13: type=4, attr=0xf, range=[0x000000007e0cd000-0x000000007e55d000) (4MB)
>  efi: mem14: type=3, attr=0xf, range=[0x000000007e55d000-0x000000007e59c000) (0MB)
> 
> That second boundary of region mem11 suddenly changes *before* we merge
> the regions. edk2 bug?

I take it you mean this change (ie. appearance of the zero-sized range)
occurs when you enable KVM acceleration in qemu?

If so, please locate "gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel"
in OvmfPkg/OvmfPkgX64.dsc, and set the following bit in its value:

  # DEBUG_GCD      0x00100000 Global Coherency Database changes

Then please rebuild OVMF, and capture the debug port output of qemu
("-debugcon file:debug.log -global isa-debugcon.iobase=0x402") both with
and without KVM.

DEBUG_GCD should produce messages related to CoreAllocateSpace(), and
might help us find the spot the difference is introduced.

BTW does this have anything to do with the NX bit report of yours, or
have you noticed this independently?

(I'm not subscribed to lkml so apologies if this email doesn't end up in
those archives / doesn't reach everyone.)

Thanks
Laszlo

WARNING: multiple messages have this Message-ID (diff)
From: Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
Cc: edk2-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Gleb Natapov <gleb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
Subject: Re: [edk2] Corrupted EFI region
Date: Mon, 05 Aug 2013 13:27:16 +0200	[thread overview]
Message-ID: <51FF8C14.2070405@redhat.com> (raw)
In-Reply-To: <20130801164927.GA7445-fF5Pk5pvG8Y@public.gmane.org>

On 08/01/13 18:49, Borislav Petkov wrote:
> On Wed, Jul 31, 2013 at 10:55:27PM +0100, David Woodhouse wrote:
>> On Wed, 2013-07-31 at 22:54 +0200, Borislav Petkov wrote:
>>> so I'm seeing this funny thing where an EFI region changes when we enter
>>> efi_enter_virtual_mode when booting with edk2 on kvm. Here's the diff:
>>
>> Perhaps the edk2-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org list should be in Cc?
> 
> Good idea and message repeated below.
> 
> One more thing: I'm using a self-built OVMF with top commit from March:
> 
> ------------------------------------------------------------------------
> r14165 | sfu5 | 2013-03-06 02:42:04 +0100 (Wed, 06 Mar 2013) | 4 lines
> 
> Fix a bug that IsSignatureFoundInDatabase() incorrectly computes CertCount.
> 
> ---
> 
> Hi guys,
> 
> so I'm seeing this funny thing where an EFI region changes when we enter
> efi_enter_virtual_mode when booting with edk2 on kvm. Here's the diff:
> 
> --- before      2013-07-31 22:20:52.316039492 +0200
> +++ after       2013-07-31 22:21:30.960731706 +0200
> @@ -9,7 +9,7 @@ efi: mem07: type=2, attr=0xf, range=[0x0
>  efi: mem08: type=7, attr=0xf, range=[0x0000000040000000-0x000000007c000000) (960MB)
>  efi: mem09: type=4, attr=0xf, range=[0x000000007c000000-0x000000007c020000) (0MB)
>  efi: mem10: type=7, attr=0xf, range=[0x000000007c020000-0x000000007e0ad000) (32MB)
> -efi: mem11: type=4, attr=0xf, range=[0x000000007e0ad000-0x000000007e0cc000) (0MB)
> +efi: mem11: type=4, attr=0xf, range=[0x000000007e0ad000-0x000000007e0ad000) (0MB)

(type 4 is EfiBootServicesData)

>  efi: mem12: type=7, attr=0xf, range=[0x000000007e0cc000-0x000000007e0cd000) (0MB)
>  efi: mem13: type=4, attr=0xf, range=[0x000000007e0cd000-0x000000007e55d000) (4MB)
>  efi: mem14: type=3, attr=0xf, range=[0x000000007e55d000-0x000000007e59c000) (0MB)
> 
> That second boundary of region mem11 suddenly changes *before* we merge
> the regions. edk2 bug?

I take it you mean this change (ie. appearance of the zero-sized range)
occurs when you enable KVM acceleration in qemu?

If so, please locate "gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel"
in OvmfPkg/OvmfPkgX64.dsc, and set the following bit in its value:

  # DEBUG_GCD      0x00100000 Global Coherency Database changes

Then please rebuild OVMF, and capture the debug port output of qemu
("-debugcon file:debug.log -global isa-debugcon.iobase=0x402") both with
and without KVM.

DEBUG_GCD should produce messages related to CoreAllocateSpace(), and
might help us find the spot the difference is introduced.

BTW does this have anything to do with the NX bit report of yours, or
have you noticed this independently?

(I'm not subscribed to lkml so apologies if this email doesn't end up in
those archives / doesn't reach everyone.)

Thanks
Laszlo

  reply	other threads:[~2013-08-05 11:25 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 20:54 Corrupted EFI region Borislav Petkov
2013-07-31 20:54 ` Borislav Petkov
2013-07-31 20:58 ` Matthew Garrett
2013-07-31 20:58   ` Matthew Garrett
2013-07-31 21:51   ` Borislav Petkov
2013-07-31 21:51     ` Borislav Petkov
2013-07-31 21:54     ` Matthew Garrett
2013-07-31 21:54       ` Matthew Garrett
2013-08-01 16:51       ` Borislav Petkov
2013-08-01 16:51         ` Borislav Petkov
2013-07-31 21:55 ` David Woodhouse
2013-07-31 21:55   ` David Woodhouse
2013-08-01 16:49   ` Borislav Petkov
2013-08-01 16:49     ` Borislav Petkov
2013-08-05 11:27     ` Laszlo Ersek [this message]
2013-08-05 11:27       ` [edk2] " Laszlo Ersek
2013-08-05 13:02       ` Borislav Petkov
2013-08-05 13:02         ` Borislav Petkov
2013-08-05 13:39         ` Laszlo Ersek
2013-08-05 13:39           ` Laszlo Ersek
2013-08-05 14:03           ` Borislav Petkov
2013-08-05 14:03             ` Borislav Petkov
2013-08-05 14:27             ` Laszlo Ersek
2013-08-05 14:27               ` Laszlo Ersek
2013-08-05 14:40               ` Borislav Petkov
2013-08-05 14:40                 ` Borislav Petkov
2013-08-05 15:15                 ` Laszlo Ersek
2013-08-05 15:15                   ` Laszlo Ersek
2013-08-05 15:34                   ` James Bottomley
2013-08-05 15:34                     ` James Bottomley
2013-08-05 16:27                     ` Laszlo Ersek
2013-08-05 16:27                       ` Laszlo Ersek
2013-08-05 16:12                   ` Borislav Petkov
2013-08-05 16:12                     ` Borislav Petkov
2013-08-05 16:41                     ` Laszlo Ersek
2013-08-05 16:41                       ` Laszlo Ersek
2013-08-05 16:47                       ` Borislav Petkov
2013-08-05 16:47                         ` Borislav Petkov
2013-08-05 17:00                         ` Kinney, Michael D
2013-08-05 17:00                           ` Kinney, Michael D
2013-08-05 17:09                         ` Laszlo Ersek
2013-08-05 17:09                           ` Laszlo Ersek
2013-08-05 21:26                         ` Laszlo Ersek
2013-08-05 21:26                           ` Laszlo Ersek
2013-08-05 22:08                           ` Borislav Petkov
2013-08-05 22:08                             ` Borislav Petkov
2013-08-06 14:10                             ` Borislav Petkov
2013-08-06 14:10                               ` Borislav Petkov
2013-08-06 15:31                               ` Laszlo Ersek
2013-08-06 15:31                                 ` Laszlo Ersek
2013-08-07 15:19                                 ` Borislav Petkov
2013-08-07 17:23                                   ` Andrew Fish
2013-08-07 17:23                                     ` Andrew Fish
2013-08-07 20:19                                     ` Matt Fleming
2013-08-07 20:19                                       ` Matt Fleming
2013-08-07 20:24                                       ` Matt Fleming
2013-08-07 20:24                                         ` Matt Fleming
2013-08-07 21:10                                       ` Andrew Fish
2013-08-07 21:10                                         ` Andrew Fish
2013-08-07 21:23                                         ` Matthew Garrett
2013-08-08 10:17                                         ` Matt Fleming
2013-08-08 10:17                                           ` Matt Fleming
2013-08-08 13:46                                           ` Andrew Fish
2013-08-08 13:46                                             ` Andrew Fish
2013-09-02  8:19                                             ` Matt Fleming
2013-09-02  8:19                                               ` Matt Fleming
2013-09-13 20:38                                           ` jerry.hoemann
2013-09-13 20:38                                             ` jerry.hoemann-VXdhtT5mjnY
2013-09-16 10:59                                             ` Matt Fleming
2013-09-16 10:59                                               ` Matt Fleming
2013-09-16 11:50                                               ` Laszlo Ersek
2013-09-16 11:50                                                 ` Laszlo Ersek
2013-09-16 15:57                                                 ` Josh Triplett
2013-09-16 15:57                                                   ` Josh Triplett
2013-09-16 16:25                                                   ` Laszlo Ersek
2013-09-16 16:25                                                     ` Laszlo Ersek
2013-09-16 16:27                                                     ` Matthew Garrett
2013-09-16 16:27                                                       ` Matthew Garrett
2013-09-16 16:29                                                     ` Josh Triplett
2013-09-16 16:29                                                       ` Josh Triplett
2013-09-18 19:24                                               ` jerry.hoemann
2013-09-18 19:24                                                 ` jerry.hoemann-VXdhtT5mjnY
2013-09-20  9:06                                                 ` Matt Fleming
2013-09-20  9:06                                                   ` Matt Fleming
2013-08-07 17:49                                   ` Laszlo Ersek
2013-08-07 17:49                                     ` Laszlo Ersek
2013-08-08 15:02                                     ` Borislav Petkov
2013-08-08 15:02                                       ` Borislav Petkov
2013-08-08 21:45                                       ` Brian J. Johnson
2013-08-08 21:45                                         ` Brian J. Johnson
2013-08-18  7:33                                     ` Jordan Justen
2013-08-18  7:33                                       ` Jordan Justen
2013-08-05 15:50                 ` Andrew Fish
2013-08-05 15:50                   ` Andrew Fish
2013-08-05 18:12                   ` Borislav Petkov
2013-08-05 18:12                     ` Borislav Petkov
2013-08-05 21:37                     ` H. Peter Anvin
2013-08-05 21:37                       ` H. Peter Anvin
2013-08-05 21:41                       ` Borislav Petkov
2013-08-05 21:41                         ` Borislav Petkov
2013-08-05 21:49                         ` H. Peter Anvin
2013-08-05 21:49                           ` H. Peter Anvin
2013-08-05 21:55                         ` Laszlo Ersek
2013-08-05 21:55                           ` Laszlo Ersek
2013-08-05 22:52                           ` James Bottomley
2013-08-05 22:52                             ` James Bottomley
2013-08-06  7:26                             ` Laszlo Ersek
2013-08-06  7:26                               ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FF8C14.2070405@redhat.com \
    --to=lersek@redhat.com \
    --cc=bp@alien8.de \
    --cc=dwmw2@infradead.org \
    --cc=edk2-devel@lists.sourceforge.net \
    --cc=gleb@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.