[Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter

* [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter
@ 2016-10-31 18:06 Ashijeet Acharya
  2016-11-02 10:33 ` Kevin Wolf
  0 siblings, 1 reply; 3+ messages in thread
From: Ashijeet Acharya @ 2016-10-31 18:06 UTC (permalink / raw)
  To: kwolf; +Cc: mreitz, rjones, jcody, qemu-devel, qemu-block, Ashijeet Acharya

This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and fixes the bug.

Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
---
 block/ssh.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/ssh.c b/block/ssh.c
index ca071c5..15ed281 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -582,8 +582,7 @@ static bool ssh_process_legacy_socket_options(QDict *output_opts,
     return true;
 }
 
-static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options,
-                                     Error **errp)
+static InetSocketAddress *ssh_config(QDict *options, Error **errp)
 {
     InetSocketAddress *inet = NULL;
     QDict *addr = NULL;
@@ -661,7 +660,7 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options,
     }
 
     /* Pop the config into our state object, Exit if invalid */
-    s->inet = ssh_config(s, options, errp);
+    s->inet = ssh_config(options, errp);
     if (!s->inet) {
         ret = -EINVAL;
         goto err;
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread