* [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter
@ 2016-10-31 18:06 Ashijeet Acharya
2016-11-02 10:33 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Ashijeet Acharya @ 2016-10-31 18:06 UTC (permalink / raw)
To: kwolf; +Cc: mreitz, rjones, jcody, qemu-devel, qemu-block, Ashijeet Acharya
This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and fixes the bug.
Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
---
block/ssh.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index ca071c5..15ed281 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -582,8 +582,7 @@ static bool ssh_process_legacy_socket_options(QDict *output_opts,
return true;
}
-static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options,
- Error **errp)
+static InetSocketAddress *ssh_config(QDict *options, Error **errp)
{
InetSocketAddress *inet = NULL;
QDict *addr = NULL;
@@ -661,7 +660,7 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options,
}
/* Pop the config into our state object, Exit if invalid */
- s->inet = ssh_config(s, options, errp);
+ s->inet = ssh_config(options, errp);
if (!s->inet) {
ret = -EINVAL;
goto err;
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter
2016-10-31 18:06 [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter Ashijeet Acharya
@ 2016-11-02 10:33 ` Kevin Wolf
2016-11-02 10:35 ` Ashijeet Acharya
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2016-11-02 10:33 UTC (permalink / raw)
To: Ashijeet Acharya; +Cc: mreitz, rjones, jcody, qemu-devel, qemu-block
Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
> This patch drops the unused parameter "BDRVSSHState" being passed into
> the ssh_config() function and fixes the bug.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
The patch looks good, but why do claim that this is a bug fix rather
than just a code cleanup?
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter
2016-11-02 10:33 ` Kevin Wolf
@ 2016-11-02 10:35 ` Ashijeet Acharya
0 siblings, 0 replies; 3+ messages in thread
From: Ashijeet Acharya @ 2016-11-02 10:35 UTC (permalink / raw)
To: Kevin Wolf
Cc: Max Reitz, Richard W.M. Jones, jcody, QEMU Developers, qemu-block
On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
>> This patch drops the unused parameter "BDRVSSHState" being passed into
>> the ssh_config() function and fixes the bug.
>>
>> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
>
> The patch looks good, but why do claim that this is a bug fix rather
> than just a code cleanup?
Okay, I will change the commit message and include the commit id in
this one too.
Ashijeet
>
> Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-02 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-31 18:06 [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter Ashijeet Acharya
2016-11-02 10:33 ` Kevin Wolf
2016-11-02 10:35 ` Ashijeet Acharya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.