From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org, "Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Wed, 06 Dec 2017 12:05:06 -0800 [thread overview]
Message-ID: <1512590706.960.25.camel@perches.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1712061144310.1507-100000@iolanthe.rowland.org>
On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.
Markus' typical terrible commit message.
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
[]
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> > */
> > clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> > if (clear == NULL) {
> > - dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> > /* FIXME recover somehow ... RESET_TT? */
> > return -ENOMEM;
> > }
>
> Does the existing memory allocation error message include the
> &udev->dev device name and driver name? If it doesn't, there will be
> no way for the user to tell that the error message is related to the
> device failure.
No, but the effect is similar.
OOM does a dump_stack() so this function's call tree is shown.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org, "Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf
Date: Wed, 06 Dec 2017 20:05:06 +0000 [thread overview]
Message-ID: <1512590706.960.25.camel@perches.com> (raw)
In-Reply-To: <659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net>
On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.
Markus' typical terrible commit message.
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
[]
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> > */
> > clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> > if (clear = NULL) {
> > - dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> > /* FIXME recover somehow ... RESET_TT? */
> > return -ENOMEM;
> > }
>
> Does the existing memory allocation error message include the
> &udev->dev device name and driver name? If it doesn't, there will be
> no way for the user to tell that the error message is related to the
> device failure.
No, but the effect is similar.
OOM does a dump_stack() so this function's call tree is shown.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org, "Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Wed, 06 Dec 2017 12:05:06 -0800 [thread overview]
Message-ID: <1512590706.960.25.camel@perches.com> (raw)
On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.
Markus' typical terrible commit message.
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
[]
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> > */
> > clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> > if (clear == NULL) {
> > - dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> > /* FIXME recover somehow ... RESET_TT? */
> > return -ENOMEM;
> > }
>
> Does the existing memory allocation error message include the
> &udev->dev device name and driver name? If it doesn't, there will be
> no way for the user to tell that the error message is related to the
> device failure.
No, but the effect is similar.
OOM does a dump_stack() so this function's call tree is shown.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-06 20:05 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:13 [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 16:13 ` SF Markus Elfring
2017-12-06 16:13 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer( SF Markus Elfring
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 16:45 ` Alan Stern
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 16:57 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Greg Kroah-Hartman
2017-12-06 16:57 ` Greg Kroah-Hartman
2017-12-06 16:57 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Greg Kroah-Hartman
2017-12-06 17:27 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Geert Uytterhoeven
2017-12-06 17:27 ` Geert Uytterhoeven
2017-12-06 17:27 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Geert Uytterhoeven
2017-12-06 17:51 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 17:51 ` SF Markus Elfring
2017-12-06 17:51 ` SF Markus Elfring
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 12:00 ` USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-08 12:00 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-08 12:00 ` USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-06 20:05 ` Joe Perches [this message]
2017-12-06 20:05 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Joe Perches
2017-12-06 20:05 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Joe Perches
2017-12-06 21:18 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 21:18 ` Alan Stern
2017-12-06 21:18 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 21:33 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 22:02 ` Alan Stern
2017-12-06 22:02 ` Alan Stern
2017-12-06 22:02 ` Alan Stern
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 15:12 ` Alan Stern
2017-12-07 15:12 ` Alan Stern
2017-12-07 15:12 ` Alan Stern
2017-12-07 16:20 ` Joe Perches
2017-12-07 16:20 ` Joe Perches
2017-12-07 16:20 ` Joe Perches
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 21:26 ` Alan Stern
2017-12-07 21:26 ` Alan Stern
2017-12-07 21:26 ` Alan Stern
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 17:42 ` Alan Stern
2017-12-08 17:42 ` Alan Stern
2017-12-08 17:42 ` Alan Stern
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 13:38 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512590706.960.25.camel@perches.com \
--to=joe@perches.com \
--cc=dmitry@daynix.com \
--cc=drake@endlessm.com \
--cc=ekorenevsky@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.