From: Dan Carpenter <dan.carpenter@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
"USB list" <linux-usb@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
"Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 7 Dec 2017 12:30:25 +0300 [thread overview]
Message-ID: <20171207093025.jzrloia7ea364iob@mwanda> (raw)
In-Reply-To: <CAMuHMdUJMBS2Hwfc69MsOPk=8FxRs=45pp5TRsJdPUhQYDm+5A@mail.gmail.com>
On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote:
> >
> > Small allocations never fail in the current kernel.
>
> A few comments (this is in response to a patch from Markus, so there have
> to be lots of questions and uncertainties ;-)
> 1. In the current kernel. What about the future?
Right. No one can predict. And the small allocations don't fail rule
causes some problems.
> 2. If a small allocation cannot fail, what happens if the small memory slab
> is exhausted? A new page must be allocated, which will trigger an OOM,
> and some other part of the system will be killed and fail.
Right.
> 3. This driver uses GFP_ATOMIC, is that guaranteed to succeed? I think not.
>
Right again. I was missing the first email in the thread because of my
email filters so I didn't see this was atomic.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
"USB list" <linux-usb@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
"Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 07 Dec 2017 09:30:25 +0000 [thread overview]
Message-ID: <20171207093025.jzrloia7ea364iob@mwanda> (raw)
In-Reply-To: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net>
On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote:
> >
> > Small allocations never fail in the current kernel.
>
> A few comments (this is in response to a patch from Markus, so there have
> to be lots of questions and uncertainties ;-)
> 1. In the current kernel. What about the future?
Right. No one can predict. And the small allocations don't fail rule
causes some problems.
> 2. If a small allocation cannot fail, what happens if the small memory slab
> is exhausted? A new page must be allocated, which will trigger an OOM,
> and some other part of the system will be killed and fail.
Right.
> 3. This driver uses GFP_ATOMIC, is that guaranteed to succeed? I think not.
>
Right again. I was missing the first email in the thread because of my
email filters so I didn't see this was atomic.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
"USB list" <linux-usb@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
"Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 7 Dec 2017 12:30:25 +0300 [thread overview]
Message-ID: <20171207093025.jzrloia7ea364iob@mwanda> (raw)
On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote:
> >
> > Small allocations never fail in the current kernel.
>
> A few comments (this is in response to a patch from Markus, so there have
> to be lots of questions and uncertainties ;-)
> 1. In the current kernel. What about the future?
Right. No one can predict. And the small allocations don't fail rule
causes some problems.
> 2. If a small allocation cannot fail, what happens if the small memory slab
> is exhausted? A new page must be allocated, which will trigger an OOM,
> and some other part of the system will be killed and fail.
Right.
> 3. This driver uses GFP_ATOMIC, is that guaranteed to succeed? I think not.
>
Right again. I was missing the first email in the thread because of my
email filters so I didn't see this was atomic.
regards,
dan carpenter
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-07 9:32 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:13 [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 16:13 ` SF Markus Elfring
2017-12-06 16:13 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer( SF Markus Elfring
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 16:45 ` Alan Stern
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 16:57 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Greg Kroah-Hartman
2017-12-06 16:57 ` Greg Kroah-Hartman
2017-12-06 16:57 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Greg Kroah-Hartman
2017-12-06 17:27 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Geert Uytterhoeven
2017-12-06 17:27 ` Geert Uytterhoeven
2017-12-06 17:27 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Geert Uytterhoeven
2017-12-06 17:51 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 17:51 ` SF Markus Elfring
2017-12-06 17:51 ` SF Markus Elfring
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 12:00 ` USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-08 12:00 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-08 12:00 ` USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-06 20:05 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Joe Perches
2017-12-06 20:05 ` Joe Perches
2017-12-06 20:05 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Joe Perches
2017-12-06 21:18 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 21:18 ` Alan Stern
2017-12-06 21:18 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 21:33 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 22:02 ` Alan Stern
2017-12-06 22:02 ` Alan Stern
2017-12-06 22:02 ` Alan Stern
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:30 ` Dan Carpenter [this message]
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 15:12 ` Alan Stern
2017-12-07 15:12 ` Alan Stern
2017-12-07 15:12 ` Alan Stern
2017-12-07 16:20 ` Joe Perches
2017-12-07 16:20 ` Joe Perches
2017-12-07 16:20 ` Joe Perches
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 21:26 ` Alan Stern
2017-12-07 21:26 ` Alan Stern
2017-12-07 21:26 ` Alan Stern
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 17:42 ` Alan Stern
2017-12-08 17:42 ` Alan Stern
2017-12-08 17:42 ` Alan Stern
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 13:38 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207093025.jzrloia7ea364iob@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dmitry@daynix.com \
--cc=drake@endlessm.com \
--cc=ekorenevsky@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.