All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Cc: "Joe Perches" <joe@perches.com>,
	"Daniel Drake" <drake@endlessm.com>,
	"Dmitry Fleytman" <dmitry@daynix.com>,
	"Eugene Korenevsky" <ekorenevsky@gmail.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Günter Röck" <linux@roeck-us.net>,
	"Johan Hovold" <johan@kernel.org>,
	"Mathias Nyman" <mathias.nyman@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"Oliver Neukum" <oneukum@suse.com>,
	"Peter Chen" <peter.chen@nxp.com>
Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 7 Dec 2017 14:38:19 +0100	[thread overview]
Message-ID: <9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1712061700550.1507-100000@iolanthe.rowland.org>

>>>> OOM does a dump_stack() so this function's call tree is shown.
>>>
>>> A call stack doesn't tell you which device was being handled.
>>
>> Do you find a default Linux allocation failure report insufficient then?
>>
>> Would you like to to achieve that the requested information can be determined
>> from a backtrace?
> 
> It is not practical to do this.

I imagine that this depends on details if a backtrace could eventually
be configured for your specific needs.


> The memory allocation routines do not for what purpose
> the memory is being allocated;

Do you want an improved accounting for these purposes?


> hence when a failure occurs they cannot tell what device
> (or other part of the system) will be affected.

I know that other programs can provide dumps for function call
stacks where the parameters which were passed in previous calls
could be decoded to some degree.


> That's why we have a secondary error message.

I am curious on how the relevance of such messages will be interpreted
by other developers in this software area.

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Cc: "Joe Perches" <joe@perches.com>,
	"Daniel Drake" <drake@endlessm.com>,
	"Dmitry Fleytman" <dmitry@daynix.com>,
	"Eugene Korenevsky" <ekorenevsky@gmail.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Günter Röck" <linux@roeck-us.net>,
	"Johan Hovold" <johan@kernel.org>,
	"Mathias Nyman" <mathias.nyman@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"Oliver Neukum" <oneukum@suse.com>,
	"Peter Chen" <peter.chen@nxp.com>
Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 07 Dec 2017 13:38:19 +0000	[thread overview]
Message-ID: <9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net> (raw)
In-Reply-To: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net>

>>>> OOM does a dump_stack() so this function's call tree is shown.
>>>
>>> A call stack doesn't tell you which device was being handled.
>>
>> Do you find a default Linux allocation failure report insufficient then?
>>
>> Would you like to to achieve that the requested information can be determined
>> from a backtrace?
> 
> It is not practical to do this.

I imagine that this depends on details if a backtrace could eventually
be configured for your specific needs.


> The memory allocation routines do not for what purpose
> the memory is being allocated;

Do you want an improved accounting for these purposes?


> hence when a failure occurs they cannot tell what device
> (or other part of the system) will be affected.

I know that other programs can provide dumps for function call
stacks where the parameters which were passed in previous calls
could be decoded to some degree.


> That's why we have a secondary error message.

I am curious on how the relevance of such messages will be interpreted
by other developers in this software area.

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Cc: "Joe Perches" <joe@perches.com>,
	"Daniel Drake" <drake@endlessm.com>,
	"Dmitry Fleytman" <dmitry@daynix.com>,
	"Eugene Korenevsky" <ekorenevsky@gmail.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Günter Röck" <linux@roeck-us.net>,
	"Johan Hovold" <johan@kernel.org>,
	"Mathias Nyman" <mathias.nyman@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"Oliver Neukum" <oneukum@suse.com>,
	"Peter Chen" <peter.chen@nxp.com>
Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 7 Dec 2017 14:38:19 +0100	[thread overview]
Message-ID: <9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net> (raw)

>>>> OOM does a dump_stack() so this function's call tree is shown.
>>>
>>> A call stack doesn't tell you which device was being handled.
>>
>> Do you find a default Linux allocation failure report insufficient then?
>>
>> Would you like to to achieve that the requested information can be determined
>> from a backtrace?
> 
> It is not practical to do this.

I imagine that this depends on details if a backtrace could eventually
be configured for your specific needs.


> The memory allocation routines do not for what purpose
> the memory is being allocated;

Do you want an improved accounting for these purposes?


> hence when a failure occurs they cannot tell what device
> (or other part of the system) will be affected.

I know that other programs can provide dumps for function call
stacks where the parameters which were passed in previous calls
could be decoded to some degree.


> That's why we have a secondary error message.

I am curious on how the relevance of such messages will be interpreted
by other developers in this software area.

Regards,
Markus
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-12-07 13:40 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 16:13 [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 16:13 ` SF Markus Elfring
2017-12-06 16:13 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer( SF Markus Elfring
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 16:45   ` Alan Stern
2017-12-06 16:45   ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 16:57   ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Greg Kroah-Hartman
2017-12-06 16:57     ` Greg Kroah-Hartman
2017-12-06 16:57     ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Greg Kroah-Hartman
2017-12-06 17:27   ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Geert Uytterhoeven
2017-12-06 17:27     ` Geert Uytterhoeven
2017-12-06 17:27     ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Geert Uytterhoeven
2017-12-06 17:51     ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 17:51       ` SF Markus Elfring
2017-12-06 17:51       ` SF Markus Elfring
2017-12-06 20:20       ` Geert Uytterhoeven
2017-12-06 20:20         ` Geert Uytterhoeven
2017-12-06 20:20         ` Geert Uytterhoeven
2017-12-08 11:11         ` Dan Carpenter
2017-12-08 11:11           ` Dan Carpenter
2017-12-08 11:11           ` Dan Carpenter
2017-12-08 12:00           ` USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-08 12:00             ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-08 12:00             ` USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-06 20:05   ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Joe Perches
2017-12-06 20:05     ` Joe Perches
2017-12-06 20:05     ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Joe Perches
2017-12-06 21:18     ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 21:18       ` Alan Stern
2017-12-06 21:18       ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 21:33       ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 21:33         ` SF Markus Elfring
2017-12-06 21:33         ` SF Markus Elfring
2017-12-06 22:02         ` Alan Stern
2017-12-06 22:02           ` Alan Stern
2017-12-06 22:02           ` Alan Stern
2017-12-07  7:40           ` Geert Uytterhoeven
2017-12-07  7:40             ` Geert Uytterhoeven
2017-12-07  7:40             ` Geert Uytterhoeven
2017-12-07  8:35             ` Dan Carpenter
2017-12-07  8:35               ` Dan Carpenter
2017-12-07  8:35               ` Dan Carpenter
2017-12-07  8:45               ` Geert Uytterhoeven
2017-12-07  8:45                 ` Geert Uytterhoeven
2017-12-07  8:45                 ` Geert Uytterhoeven
2017-12-07  8:56                 ` Greg Kroah-Hartman
2017-12-07  8:56                   ` Greg Kroah-Hartman
2017-12-07  8:56                   ` Greg Kroah-Hartman
2017-12-07  9:17                   ` Oliver Neukum
2017-12-07  9:17                     ` Oliver Neukum
2017-12-07  9:17                     ` Oliver Neukum
2017-12-07  9:30                 ` Dan Carpenter
2017-12-07  9:30                   ` Dan Carpenter
2017-12-07  9:30                   ` Dan Carpenter
2017-12-07 15:12             ` Alan Stern
2017-12-07 15:12               ` Alan Stern
2017-12-07 15:12               ` Alan Stern
2017-12-07 16:20               ` Joe Perches
2017-12-07 16:20                 ` Joe Perches
2017-12-07 16:20                 ` Joe Perches
2017-12-07 20:51               ` Dan Carpenter
2017-12-07 20:51                 ` Dan Carpenter
2017-12-07 20:51                 ` Dan Carpenter
2017-12-07 21:26                 ` Alan Stern
2017-12-07 21:26                   ` Alan Stern
2017-12-07 21:26                   ` Alan Stern
2017-12-08  7:43                   ` Geert Uytterhoeven
2017-12-08  7:43                     ` Geert Uytterhoeven
2017-12-08  7:43                     ` Geert Uytterhoeven
2017-12-08 17:42                     ` Alan Stern
2017-12-08 17:42                       ` Alan Stern
2017-12-08 17:42                       ` Alan Stern
2017-12-07 13:38           ` SF Markus Elfring [this message]
2017-12-07 13:38             ` SF Markus Elfring
2017-12-07 13:38             ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=dmitry@daynix.com \
    --cc=drake@endlessm.com \
    --cc=ekorenevsky@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=johan@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mathias.nyman@linux.intel.com \
    --cc=oneukum@suse.com \
    --cc=peter.chen@nxp.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.