* [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
@ 2018-02-19 23:54 Denys Dmytriyenko
2018-02-20 0:36 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-02-19 23:54 UTC (permalink / raw)
To: openembedded-core; +Cc: Denys Dmytriyenko
From: Denys Dmytriyenko <denys@ti.com>
Explicitly depend on bison-native for deterministic builds, as it is required
for the build:
| HOSTCC scripts/basic/fixdep
| GEN ./Makefile
| HOSTCC scripts/kconfig/conf.o
| YACC scripts/kconfig/zconf.tab.c
| /bin/sh: bison: command not found
| scripts/Makefile.lib:217: recipe for target 'scripts/kconfig/zconf.tab.c' failed
In most cases, this dependency comes indirectly via toolchain dependencies,
specifically binutils-cross, which pulls bison-native. Different setups,
such as with external toolchain, would expose this problem, since correct
dependency is not marked explicitly.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
I'm seeing this now on 4.16-rc2 with external toolchain.
meta/classes/kernel.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 943938d..321c0a4 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -4,7 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel"
KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }"
PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
-DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native"
+DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
do_deploy[depends] += "depmodwrapper-cross:do_populate_sysroot"
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-19 23:54 [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds Denys Dmytriyenko
@ 2018-02-20 0:36 ` Otavio Salvador
2018-02-20 1:20 ` Denys Dmytriyenko
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2018-02-20 0:36 UTC (permalink / raw)
To: Denys Dmytriyenko
Cc: Denys Dmytriyenko, Patches and discussions about the oe-core layer
On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> From: Denys Dmytriyenko <denys@ti.com>
>
> Explicitly depend on bison-native for deterministic builds, as it is required
> for the build:
>
> | HOSTCC scripts/basic/fixdep
> | GEN ./Makefile
> | HOSTCC scripts/kconfig/conf.o
> | YACC scripts/kconfig/zconf.tab.c
> | /bin/sh: bison: command not found
> | scripts/Makefile.lib:217: recipe for target 'scripts/kconfig/zconf.tab.c' failed
>
> In most cases, this dependency comes indirectly via toolchain dependencies,
> specifically binutils-cross, which pulls bison-native. Different setups,
> such as with external toolchain, would expose this problem, since correct
> dependency is not marked explicitly.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> I'm seeing this now on 4.16-rc2 with external toolchain.
I am not against the addition but in fact, it is because 4.16 stopped
of using pre-generated files and now requires bison to be available. I
am unsure it ought to be on kernel.bbclass at this moment.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 0:36 ` Otavio Salvador
@ 2018-02-20 1:20 ` Denys Dmytriyenko
2018-02-20 10:10 ` Khem Raj
0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-02-20 1:20 UTC (permalink / raw)
To: Otavio Salvador
Cc: Denys Dmytriyenko, Patches and discussions about the oe-core layer
On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > Explicitly depend on bison-native for deterministic builds, as it is required
> > for the build:
> >
> > | HOSTCC scripts/basic/fixdep
> > | GEN ./Makefile
> > | HOSTCC scripts/kconfig/conf.o
> > | YACC scripts/kconfig/zconf.tab.c
> > | /bin/sh: bison: command not found
> > | scripts/Makefile.lib:217: recipe for target 'scripts/kconfig/zconf.tab.c' failed
> >
> > In most cases, this dependency comes indirectly via toolchain dependencies,
> > specifically binutils-cross, which pulls bison-native. Different setups,
> > such as with external toolchain, would expose this problem, since correct
> > dependency is not marked explicitly.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> > I'm seeing this now on 4.16-rc2 with external toolchain.
>
> I am not against the addition but in fact, it is because 4.16 stopped
> of using pre-generated files and now requires bison to be available.
Ok, good, I was wondering why I didn't see it before 4.16...
> I am unsure it ought to be on kernel.bbclass at this moment.
Why not? Because it's 4.16+ specific?
By default bison-native dependency gets added implicitly when built with the
toolchain from oe-core, so this doesn't add any extra dependencies, only makes
it explicit.
--
Denys
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 1:20 ` Denys Dmytriyenko
@ 2018-02-20 10:10 ` Khem Raj
2018-02-20 14:53 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2018-02-20 10:10 UTC (permalink / raw)
To: Denys Dmytriyenko, Otavio Salvador
Cc: Patches and discussions about the oe-core layer, Denys Dmytriyenko
On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:
> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org> wrote:
>>> From: Denys Dmytriyenko <denys@ti.com>
>>>
>>> Explicitly depend on bison-native for deterministic builds, as it is required
>>> for the build:
>>>
>>> | HOSTCC scripts/basic/fixdep
>>> | GEN ./Makefile
>>> | HOSTCC scripts/kconfig/conf.o
>>> | YACC scripts/kconfig/zconf.tab.c
>>> | /bin/sh: bison: command not found
>>> | scripts/Makefile.lib:217: recipe for target 'scripts/kconfig/zconf.tab.c' failed
>>>
>>> In most cases, this dependency comes indirectly via toolchain dependencies,
>>> specifically binutils-cross, which pulls bison-native. Different setups,
>>> such as with external toolchain, would expose this problem, since correct
>>> dependency is not marked explicitly.
>>>
>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>>> ---
>>> I'm seeing this now on 4.16-rc2 with external toolchain.
>>
>> I am not against the addition but in fact, it is because 4.16 stopped
>> of using pre-generated files and now requires bison to be available.
>
> Ok, good, I was wondering why I didn't see it before 4.16...
>
>
>> I am unsure it ought to be on kernel.bbclass at this moment.
>
> Why not? Because it's 4.16+ specific?
>
> By default bison-native dependency gets added implicitly when built with the
> toolchain from oe-core, so this doesn't add any extra dependencies, only makes
> it explicit.
>
it will be overcompensating for < 4.16 kernel recipes where this
dependency is not needed. it might be a legit dependency for another
component, that doesn't stage this package in kernel recipe-specific
sysroot but this change will do that. So its not completely innocent
change.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 10:10 ` Khem Raj
@ 2018-02-20 14:53 ` Otavio Salvador
2018-02-20 15:41 ` Martin Jansa
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2018-02-20 14:53 UTC (permalink / raw)
To: Khem Raj
Cc: Denys Dmytriyenko, Patches and discussions about the oe-core layer
On Tue, Feb 20, 2018 at 7:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:
>>
>> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
>>>
>>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org>
>>> wrote:
>>>>
>>>> From: Denys Dmytriyenko <denys@ti.com>
>>>>
>>>> Explicitly depend on bison-native for deterministic builds, as it is
>>>> required
>>>> for the build:
>>>>
>>>> | HOSTCC scripts/basic/fixdep
>>>> | GEN ./Makefile
>>>> | HOSTCC scripts/kconfig/conf.o
>>>> | YACC scripts/kconfig/zconf.tab.c
>>>> | /bin/sh: bison: command not found
>>>> | scripts/Makefile.lib:217: recipe for target
>>>> 'scripts/kconfig/zconf.tab.c' failed
>>>>
>>>> In most cases, this dependency comes indirectly via toolchain
>>>> dependencies,
>>>> specifically binutils-cross, which pulls bison-native. Different setups,
>>>> such as with external toolchain, would expose this problem, since
>>>> correct
>>>> dependency is not marked explicitly.
>>>>
>>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>>>> ---
>>>> I'm seeing this now on 4.16-rc2 with external toolchain.
>>>
>>>
>>> I am not against the addition but in fact, it is because 4.16 stopped
>>> of using pre-generated files and now requires bison to be available.
>>
>>
>> Ok, good, I was wondering why I didn't see it before 4.16...
>>
>>
>>> I am unsure it ought to be on kernel.bbclass at this moment.
>>
>>
>> Why not? Because it's 4.16+ specific?
>>
>> By default bison-native dependency gets added implicitly when built with
>> the
>> toolchain from oe-core, so this doesn't add any extra dependencies, only
>> makes
>> it explicit.
>>
> it will be overcompensating for < 4.16 kernel recipes where this dependency
> is not needed. it might be a legit dependency for another component, that
> doesn't stage this package in kernel recipe-specific sysroot but this change
> will do that. So its not completely innocent change.
I'd be in favor of matching the version and adding it if it is a 4.16
or newer kernel. Adding for prior versions seems wrong for me.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 14:53 ` Otavio Salvador
@ 2018-02-20 15:41 ` Martin Jansa
2018-02-20 16:08 ` Khem Raj
0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2018-02-20 15:41 UTC (permalink / raw)
To: Otavio Salvador
Cc: Patches and discussions about the oe-core layer, Denys Dmytriyenko
[-- Attachment #1: Type: text/plain, Size: 3436 bytes --]
I'm OK with adding bison-native for all versions.
When we added bc-native 2+ years ago:
commit c067e52cffe002de3b39aa1bced308dd532859c1
Author: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Date: Thu Oct 2 15:33:23 2014 -0500
kernel: Added bc-native as DEPENDS
The makefile checks for bc during for compilation
it was also needed only for the latest kernel and we didn't make it
conditional on the kernel version. Now with RSS it's even less dangerous as
the bison-native will appear only in kernel's RSS and as Denys said it's
quite common dependency so many components pull it into RSS anyway.
On Tue, Feb 20, 2018 at 3:53 PM, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:
> On Tue, Feb 20, 2018 at 7:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
> > On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:
> >>
> >> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
> >>>
> >>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org>
> >>> wrote:
> >>>>
> >>>> From: Denys Dmytriyenko <denys@ti.com>
> >>>>
> >>>> Explicitly depend on bison-native for deterministic builds, as it is
> >>>> required
> >>>> for the build:
> >>>>
> >>>> | HOSTCC scripts/basic/fixdep
> >>>> | GEN ./Makefile
> >>>> | HOSTCC scripts/kconfig/conf.o
> >>>> | YACC scripts/kconfig/zconf.tab.c
> >>>> | /bin/sh: bison: command not found
> >>>> | scripts/Makefile.lib:217: recipe for target
> >>>> 'scripts/kconfig/zconf.tab.c' failed
> >>>>
> >>>> In most cases, this dependency comes indirectly via toolchain
> >>>> dependencies,
> >>>> specifically binutils-cross, which pulls bison-native. Different
> setups,
> >>>> such as with external toolchain, would expose this problem, since
> >>>> correct
> >>>> dependency is not marked explicitly.
> >>>>
> >>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >>>> ---
> >>>> I'm seeing this now on 4.16-rc2 with external toolchain.
> >>>
> >>>
> >>> I am not against the addition but in fact, it is because 4.16 stopped
> >>> of using pre-generated files and now requires bison to be available.
> >>
> >>
> >> Ok, good, I was wondering why I didn't see it before 4.16...
> >>
> >>
> >>> I am unsure it ought to be on kernel.bbclass at this moment.
> >>
> >>
> >> Why not? Because it's 4.16+ specific?
> >>
> >> By default bison-native dependency gets added implicitly when built with
> >> the
> >> toolchain from oe-core, so this doesn't add any extra dependencies, only
> >> makes
> >> it explicit.
> >>
> > it will be overcompensating for < 4.16 kernel recipes where this
> dependency
> > is not needed. it might be a legit dependency for another component, that
> > doesn't stage this package in kernel recipe-specific sysroot but this
> change
> > will do that. So its not completely innocent change.
>
> I'd be in favor of matching the version and adding it if it is a 4.16
> or newer kernel. Adding for prior versions seems wrong for me.
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 5421 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 15:41 ` Martin Jansa
@ 2018-02-20 16:08 ` Khem Raj
2018-02-20 16:17 ` Denys Dmytriyenko
0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2018-02-20 16:08 UTC (permalink / raw)
To: Martin Jansa
Cc: Patches and discussions about the oe-core layer, Otavio Salvador,
Denys Dmytriyenko
[-- Attachment #1: Type: text/plain, Size: 3725 bytes --]
On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> I'm OK with adding bison-native for all versions.
>
As long we know that there are no side effects of this dep in kernel builds
>
> When we added bc-native 2+ years ago:
> commit c067e52cffe002de3b39aa1bced308dd532859c1
> Author: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> Date: Thu Oct 2 15:33:23 2014 -0500
>
> kernel: Added bc-native as DEPENDS
>
> The makefile checks for bc during for compilation
>
> it was also needed only for the latest kernel and we didn't make it
> conditional on the kernel version. Now with RSS it's even less dangerous as
> the bison-native will appear only in kernel's RSS and as Denys said it's
> quite common dependency so many components pull it into RSS anyway.
>
> On Tue, Feb 20, 2018 at 3:53 PM, Otavio Salvador <
> otavio.salvador@ossystems.com.br> wrote:
>
>> On Tue, Feb 20, 2018 at 7:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> > On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:
>> >>
>> >> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
>> >>>
>> >>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org>
>> >>> wrote:
>> >>>>
>> >>>> From: Denys Dmytriyenko <denys@ti.com>
>> >>>>
>> >>>> Explicitly depend on bison-native for deterministic builds, as it is
>> >>>> required
>> >>>> for the build:
>> >>>>
>> >>>> | HOSTCC scripts/basic/fixdep
>> >>>> | GEN ./Makefile
>> >>>> | HOSTCC scripts/kconfig/conf.o
>> >>>> | YACC scripts/kconfig/zconf.tab.c
>> >>>> | /bin/sh: bison: command not found
>> >>>> | scripts/Makefile.lib:217: recipe for target
>> >>>> 'scripts/kconfig/zconf.tab.c' failed
>> >>>>
>> >>>> In most cases, this dependency comes indirectly via toolchain
>> >>>> dependencies,
>> >>>> specifically binutils-cross, which pulls bison-native. Different
>> setups,
>> >>>> such as with external toolchain, would expose this problem, since
>> >>>> correct
>> >>>> dependency is not marked explicitly.
>> >>>>
>> >>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> >>>> ---
>> >>>> I'm seeing this now on 4.16-rc2 with external toolchain.
>> >>>
>> >>>
>> >>> I am not against the addition but in fact, it is because 4.16 stopped
>> >>> of using pre-generated files and now requires bison to be available.
>> >>
>> >>
>> >> Ok, good, I was wondering why I didn't see it before 4.16...
>> >>
>> >>
>> >>> I am unsure it ought to be on kernel.bbclass at this moment.
>> >>
>> >>
>> >> Why not? Because it's 4.16+ specific?
>> >>
>> >> By default bison-native dependency gets added implicitly when built
>> with
>> >> the
>> >> toolchain from oe-core, so this doesn't add any extra dependencies,
>> only
>> >> makes
>> >> it explicit.
>> >>
>> > it will be overcompensating for < 4.16 kernel recipes where this
>> dependency
>> > is not needed. it might be a legit dependency for another component,
>> that
>> > doesn't stage this package in kernel recipe-specific sysroot but this
>> change
>> > will do that. So its not completely innocent change.
>>
>> I'd be in favor of matching the version and adding it if it is a 4.16
>> or newer kernel. Adding for prior versions seems wrong for me.
>>
>> --
>> Otavio Salvador O.S. Systems
>> http://www.ossystems.com.br http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
>>
> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
[-- Attachment #2: Type: text/html, Size: 6522 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 16:08 ` Khem Raj
@ 2018-02-20 16:17 ` Denys Dmytriyenko
2018-02-20 18:28 ` Khem Raj
0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-02-20 16:17 UTC (permalink / raw)
To: Khem Raj
Cc: Denys Dmytriyenko, Otavio Salvador,
Patches and discussions about the oe-core layer
On Tue, Feb 20, 2018 at 04:08:06PM +0000, Khem Raj wrote:
> On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> > I'm OK with adding bison-native for all versions.
>
> As long we know that there are no side effects of this dep in kernel builds
You do realize that when you build with oe-core toolchain, every package gets
bison-native dependency automatically? Regardless whether it was requested or
not. If there were side effects, we would have seen it long time ago...
> > When we added bc-native 2+ years ago:
> > commit c067e52cffe002de3b39aa1bced308dd532859c1
> > Author: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> > Date: Thu Oct 2 15:33:23 2014 -0500
> >
> > kernel: Added bc-native as DEPENDS
> >
> > The makefile checks for bc during for compilation
> >
> > it was also needed only for the latest kernel and we didn't make it
> > conditional on the kernel version. Now with RSS it's even less dangerous as
> > the bison-native will appear only in kernel's RSS and as Denys said it's
> > quite common dependency so many components pull it into RSS anyway.
> >
> > On Tue, Feb 20, 2018 at 3:53 PM, Otavio Salvador <
> > otavio.salvador@ossystems.com.br> wrote:
> >
> >> On Tue, Feb 20, 2018 at 7:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
> >> > On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:
> >> >>
> >> >> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
> >> >>>
> >> >>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org>
> >> >>> wrote:
> >> >>>>
> >> >>>> From: Denys Dmytriyenko <denys@ti.com>
> >> >>>>
> >> >>>> Explicitly depend on bison-native for deterministic builds, as it is
> >> >>>> required
> >> >>>> for the build:
> >> >>>>
> >> >>>> | HOSTCC scripts/basic/fixdep
> >> >>>> | GEN ./Makefile
> >> >>>> | HOSTCC scripts/kconfig/conf.o
> >> >>>> | YACC scripts/kconfig/zconf.tab.c
> >> >>>> | /bin/sh: bison: command not found
> >> >>>> | scripts/Makefile.lib:217: recipe for target
> >> >>>> 'scripts/kconfig/zconf.tab.c' failed
> >> >>>>
> >> >>>> In most cases, this dependency comes indirectly via toolchain
> >> >>>> dependencies,
> >> >>>> specifically binutils-cross, which pulls bison-native. Different
> >> setups,
> >> >>>> such as with external toolchain, would expose this problem, since
> >> >>>> correct
> >> >>>> dependency is not marked explicitly.
> >> >>>>
> >> >>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >> >>>> ---
> >> >>>> I'm seeing this now on 4.16-rc2 with external toolchain.
> >> >>>
> >> >>>
> >> >>> I am not against the addition but in fact, it is because 4.16 stopped
> >> >>> of using pre-generated files and now requires bison to be available.
> >> >>
> >> >>
> >> >> Ok, good, I was wondering why I didn't see it before 4.16...
> >> >>
> >> >>
> >> >>> I am unsure it ought to be on kernel.bbclass at this moment.
> >> >>
> >> >>
> >> >> Why not? Because it's 4.16+ specific?
> >> >>
> >> >> By default bison-native dependency gets added implicitly when built
> >> with
> >> >> the
> >> >> toolchain from oe-core, so this doesn't add any extra dependencies,
> >> only
> >> >> makes
> >> >> it explicit.
> >> >>
> >> > it will be overcompensating for < 4.16 kernel recipes where this
> >> dependency
> >> > is not needed. it might be a legit dependency for another component,
> >> that
> >> > doesn't stage this package in kernel recipe-specific sysroot but this
> >> change
> >> > will do that. So its not completely innocent change.
> >>
> >> I'd be in favor of matching the version and adding it if it is a 4.16
> >> or newer kernel. Adding for prior versions seems wrong for me.
> >>
> >> --
> >> Otavio Salvador O.S. Systems
> >> http://www.ossystems.com.br http://code.ossystems.com.br
> >> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
> >>
> > --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 16:17 ` Denys Dmytriyenko
@ 2018-02-20 18:28 ` Khem Raj
2018-02-20 19:33 ` Denys Dmytriyenko
0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2018-02-20 18:28 UTC (permalink / raw)
To: Denys Dmytriyenko
Cc: Denys Dmytriyenko, Otavio Salvador,
Patches and discussions about the oe-core layer
On Tue, Feb 20, 2018 at 8:17 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Tue, Feb 20, 2018 at 04:08:06PM +0000, Khem Raj wrote:
>> On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>>
>> > I'm OK with adding bison-native for all versions.
>>
>> As long we know that there are no side effects of this dep in kernel builds
>
> You do realize that when you build with oe-core toolchain, every package gets
> bison-native dependency automatically? Regardless whether it was requested or
> not. If there were side effects, we would have seen it long time ago...
Yes I see it seems to be pulled in by toolchain regardless, so for this
patch we might just be adding to determinism. but I think it raises question
on why toolchain is adding this everywhere, I think we should remove it
from toolchain default deps. It will make metadata more consistent
across internal/external toolchains
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
2018-02-20 18:28 ` Khem Raj
@ 2018-02-20 19:33 ` Denys Dmytriyenko
0 siblings, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-02-20 19:33 UTC (permalink / raw)
To: Khem Raj
Cc: Denys Dmytriyenko, Otavio Salvador,
Patches and discussions about the oe-core layer
On Tue, Feb 20, 2018 at 10:28:47AM -0800, Khem Raj wrote:
> On Tue, Feb 20, 2018 at 8:17 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> > On Tue, Feb 20, 2018 at 04:08:06PM +0000, Khem Raj wrote:
> >> On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> >>
> >> > I'm OK with adding bison-native for all versions.
> >>
> >> As long we know that there are no side effects of this dep in kernel builds
> >
> > You do realize that when you build with oe-core toolchain, every package gets
> > bison-native dependency automatically? Regardless whether it was requested or
> > not. If there were side effects, we would have seen it long time ago...
>
> Yes I see it seems to be pulled in by toolchain regardless, so for this
> patch we might just be adding to determinism. but I think it raises question
> on why toolchain is adding this everywhere, I think we should remove it
> from toolchain default deps. It will make metadata more consistent
> across internal/external toolchains
There were several similar patches I submitted last month for different
components to add flex-native and/or bison-native. Most of them got accepted
and we had a follow up discussion with Richard in gcc thread:
http://lists.openembedded.org/pipermail/openembedded-core/2018-January/146295.html
He also submitted this patch to prevent indirect flex/bison-native
dependencies, but I don't believe it got merged yet:
http://lists.openembedded.org/pipermail/openembedded-core/2018-January/146324.html
Richard, do you have any comments?
--
Denys
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-02-20 19:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-19 23:54 [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds Denys Dmytriyenko
2018-02-20 0:36 ` Otavio Salvador
2018-02-20 1:20 ` Denys Dmytriyenko
2018-02-20 10:10 ` Khem Raj
2018-02-20 14:53 ` Otavio Salvador
2018-02-20 15:41 ` Martin Jansa
2018-02-20 16:08 ` Khem Raj
2018-02-20 16:17 ` Denys Dmytriyenko
2018-02-20 18:28 ` Khem Raj
2018-02-20 19:33 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.