All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
Date: Fri, 15 Nov 2019 13:51:34 +0000	[thread overview]
Message-ID: <157382589422.11997.1129540577222685173@skylake-alporthouse-com> (raw)
In-Reply-To: <20191115114549.23716-2-abdiel.janulgue@linux.intel.com>

Quoting Abdiel Janulgue (2019-11-15 11:45:47)
> +i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data,
> +                          struct drm_file *file)
>  {
> -       struct drm_i915_gem_mmap_gtt *args = data;
> +       struct drm_i915_private *i915 = to_i915(dev);
> +       struct drm_i915_gem_mmap_offset *args = data;
> +       enum i915_mmap_type type;
> +
> +       switch (args->flags) {
> +       case I915_MMAP_OFFSET_GTT:
> +               if (!i915_ggtt_has_aperture(&i915->ggtt))
> +                       return -ENODEV;
> +               type = I915_MMAP_TYPE_GTT;
> +               break;
> +
> +       case I915_MMAP_OFFSET_WC:
> +               if (!boot_cpu_has(X86_FEATURE_PAT))
> +                       return -ENODEV;
> +               type = I915_MMAP_TYPE_WC;
> +               break;
> +
> +       case I915_MMAP_OFFSET_WB:
> +               type = I915_MMAP_TYPE_WB;
> +               break;
> +
> +       case I915_MMAP_OFFSET_UC:
> +               if (!boot_cpu_has(X86_FEATURE_PAT))
> +                       return -ENODEV;
> +               type = I915_MMAP_TYPE_UC;
> +               break;
> +
> +       default:
> +               return -EINVAL;
> +       }
>  
>         return __assign_gem_object_mmap_data(file, args->handle,
>                                              I915_MMAP_TYPE_GTT,

s/TYPE_GTT/type/?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
Date: Fri, 15 Nov 2019 13:51:34 +0000	[thread overview]
Message-ID: <157382589422.11997.1129540577222685173@skylake-alporthouse-com> (raw)
Message-ID: <20191115135134.QgE9tUzdKozxJHofGhq8gtxIBNmvQfNXYPWuQiSLkMI@z> (raw)
In-Reply-To: <20191115114549.23716-2-abdiel.janulgue@linux.intel.com>

Quoting Abdiel Janulgue (2019-11-15 11:45:47)
> +i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data,
> +                          struct drm_file *file)
>  {
> -       struct drm_i915_gem_mmap_gtt *args = data;
> +       struct drm_i915_private *i915 = to_i915(dev);
> +       struct drm_i915_gem_mmap_offset *args = data;
> +       enum i915_mmap_type type;
> +
> +       switch (args->flags) {
> +       case I915_MMAP_OFFSET_GTT:
> +               if (!i915_ggtt_has_aperture(&i915->ggtt))
> +                       return -ENODEV;
> +               type = I915_MMAP_TYPE_GTT;
> +               break;
> +
> +       case I915_MMAP_OFFSET_WC:
> +               if (!boot_cpu_has(X86_FEATURE_PAT))
> +                       return -ENODEV;
> +               type = I915_MMAP_TYPE_WC;
> +               break;
> +
> +       case I915_MMAP_OFFSET_WB:
> +               type = I915_MMAP_TYPE_WB;
> +               break;
> +
> +       case I915_MMAP_OFFSET_UC:
> +               if (!boot_cpu_has(X86_FEATURE_PAT))
> +                       return -ENODEV;
> +               type = I915_MMAP_TYPE_UC;
> +               break;
> +
> +       default:
> +               return -EINVAL;
> +       }
>  
>         return __assign_gem_object_mmap_data(file, args->handle,
>                                              I915_MMAP_TYPE_GTT,

s/TYPE_GTT/type/?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-11-15 13:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 11:45 [PATCH 1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue
2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue
2019-11-15 11:45 ` [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue
2019-11-15 11:45   ` [Intel-gfx] " Abdiel Janulgue
2019-11-15 13:51   ` Chris Wilson [this message]
2019-11-15 13:51     ` Chris Wilson
2019-11-15 14:31   ` Chris Wilson
2019-11-15 14:31     ` [Intel-gfx] " Chris Wilson
2019-11-15 11:45 ` [PATCH 3/4] drm/i915: cpu-map based dumb buffers Abdiel Janulgue
2019-11-15 11:45   ` [Intel-gfx] " Abdiel Janulgue
2019-11-15 13:54   ` Chris Wilson
2019-11-15 13:54     ` [Intel-gfx] " Chris Wilson
2019-11-15 14:26     ` Chris Wilson
2019-11-15 14:26       ` [Intel-gfx] " Chris Wilson
2019-11-15 11:45 ` [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue
2019-11-15 11:45   ` [Intel-gfx] " Abdiel Janulgue
2019-11-15 13:58   ` Chris Wilson
2019-11-15 13:58     ` [Intel-gfx] " Chris Wilson
2019-11-15 13:56 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Patchwork
2019-11-15 13:56   ` [Intel-gfx] " Patchwork
2019-11-15 13:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-11-15 13:57   ` [Intel-gfx] " Patchwork
2019-11-15 14:17 ` [PATCH 1/4] " Chris Wilson
2019-11-15 14:17   ` [Intel-gfx] " Chris Wilson
2019-11-15 14:23 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] " Patchwork
2019-11-15 14:23   ` [Intel-gfx] " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-11-19 11:37 [PATCH 1/4] " Abdiel Janulgue
2019-11-19 11:37 ` [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue
2019-11-19 11:40   ` Abdiel Janulgue
2019-11-22 18:49   ` Ville Syrjälä
2019-11-14 19:09 [PATCH 1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue
2019-11-14 19:09 ` [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue
2019-11-14 23:54   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157382589422.11997.1129540577222685173@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=abdiel.janulgue@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.