From: Chris Wilson <chris@chris-wilson.co.uk> To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>, intel-gfx@lists.freedesktop.org Cc: Matthew Auld <matthew.auld@intel.com> Subject: Re: [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Date: Fri, 15 Nov 2019 13:58:24 +0000 [thread overview] Message-ID: <157382630489.11997.11206031084793990170@skylake-alporthouse-com> (raw) In-Reply-To: <20191115114549.23716-4-abdiel.janulgue@linux.intel.com> Quoting Abdiel Janulgue (2019-11-15 11:45:49) > +static vm_fault_t i915_gem_fault_cpu(struct vm_fault *vmf) > +{ > + struct vm_area_struct *area = vmf->vma; > + struct i915_mmap_offset *priv = area->vm_private_data; > + struct drm_i915_gem_object *obj = priv->obj; > + vm_fault_t vmf_ret; > + unsigned long i, size = area->vm_end - area->vm_start; > + bool write = area->vm_flags & VM_WRITE; > + int ret; > + > + if (!i915_gem_object_has_struct_page(obj)) > + return VM_FAULT_SIGBUS; > + > + /* Sanity check that we allow writing into this object */ > + if (i915_gem_object_is_readonly(obj) && write) > + return VM_FAULT_SIGBUS; > + > + ret = i915_gem_object_pin_pages(obj); > + if (ret) > + return i915_error_to_vmf_fault(ret); > + It is probably a good idea to mention here how we revoke the PTE. /* PTEs are revoked in obj->ops->put_pages() */ > + for (i = 0; i < size >> PAGE_SHIFT; i++) { > + struct page *page = i915_gem_object_get_page(obj, i); > + > + vmf_ret = vmf_insert_pfn(area, > + (unsigned long)area->vm_start + i * PAGE_SIZE, > + page_to_pfn(page)); > + if (vmf_ret != VM_FAULT_NOPAGE) > + break; > + } > + > + i915_gem_object_unpin_pages(obj); > + > + return vmf_ret; With the revoke + selftests in place, this looks correct. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> There might be room for fine tuning (not pin/mapping the whole object), but that has been a concern for a long time and remains a concern :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk> To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>, intel-gfx@lists.freedesktop.org Cc: Matthew Auld <matthew.auld@intel.com> Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Date: Fri, 15 Nov 2019 13:58:24 +0000 [thread overview] Message-ID: <157382630489.11997.11206031084793990170@skylake-alporthouse-com> (raw) Message-ID: <20191115135824.mwqpjaCh-du25npOqjfQPtbCBlH3XI0BHHvtTxIezwA@z> (raw) In-Reply-To: <20191115114549.23716-4-abdiel.janulgue@linux.intel.com> Quoting Abdiel Janulgue (2019-11-15 11:45:49) > +static vm_fault_t i915_gem_fault_cpu(struct vm_fault *vmf) > +{ > + struct vm_area_struct *area = vmf->vma; > + struct i915_mmap_offset *priv = area->vm_private_data; > + struct drm_i915_gem_object *obj = priv->obj; > + vm_fault_t vmf_ret; > + unsigned long i, size = area->vm_end - area->vm_start; > + bool write = area->vm_flags & VM_WRITE; > + int ret; > + > + if (!i915_gem_object_has_struct_page(obj)) > + return VM_FAULT_SIGBUS; > + > + /* Sanity check that we allow writing into this object */ > + if (i915_gem_object_is_readonly(obj) && write) > + return VM_FAULT_SIGBUS; > + > + ret = i915_gem_object_pin_pages(obj); > + if (ret) > + return i915_error_to_vmf_fault(ret); > + It is probably a good idea to mention here how we revoke the PTE. /* PTEs are revoked in obj->ops->put_pages() */ > + for (i = 0; i < size >> PAGE_SHIFT; i++) { > + struct page *page = i915_gem_object_get_page(obj, i); > + > + vmf_ret = vmf_insert_pfn(area, > + (unsigned long)area->vm_start + i * PAGE_SIZE, > + page_to_pfn(page)); > + if (vmf_ret != VM_FAULT_NOPAGE) > + break; > + } > + > + i915_gem_object_unpin_pages(obj); > + > + return vmf_ret; With the revoke + selftests in place, this looks correct. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> There might be room for fine tuning (not pin/mapping the whole object), but that has been a concern for a long time and remains a concern :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-15 13:58 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-15 11:45 [PATCH 1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 11:45 ` [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 13:51 ` Chris Wilson 2019-11-15 13:51 ` [Intel-gfx] " Chris Wilson 2019-11-15 14:31 ` Chris Wilson 2019-11-15 14:31 ` [Intel-gfx] " Chris Wilson 2019-11-15 11:45 ` [PATCH 3/4] drm/i915: cpu-map based dumb buffers Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 13:54 ` Chris Wilson 2019-11-15 13:54 ` [Intel-gfx] " Chris Wilson 2019-11-15 14:26 ` Chris Wilson 2019-11-15 14:26 ` [Intel-gfx] " Chris Wilson 2019-11-15 11:45 ` [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 13:58 ` Chris Wilson [this message] 2019-11-15 13:58 ` Chris Wilson 2019-11-15 13:56 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Patchwork 2019-11-15 13:56 ` [Intel-gfx] " Patchwork 2019-11-15 13:57 ` ✗ Fi.CI.SPARSE: " Patchwork 2019-11-15 13:57 ` [Intel-gfx] " Patchwork 2019-11-15 14:17 ` [PATCH 1/4] " Chris Wilson 2019-11-15 14:17 ` [Intel-gfx] " Chris Wilson 2019-11-15 14:23 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] " Patchwork 2019-11-15 14:23 ` [Intel-gfx] " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2019-11-19 11:37 [PATCH 1/4] " Abdiel Janulgue 2019-11-19 11:37 ` [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue 2019-11-28 11:08 ` Chris Wilson 2019-11-28 11:22 ` Chris Wilson 2019-11-14 19:09 [PATCH 1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue 2019-11-14 19:09 ` [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=157382630489.11997.11206031084793990170@skylake-alporthouse-com \ --to=chris@chris-wilson.co.uk \ --cc=abdiel.janulgue@linux.intel.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.auld@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.