From: Patchwork <patchwork@emeril.freedesktop.org> To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Date: Fri, 15 Nov 2019 13:56:34 -0000 [thread overview] Message-ID: <157382619478.3301.7151389380682338500@emeril.freedesktop.org> (raw) In-Reply-To: <20191115114549.23716-1-abdiel.janulgue@linux.intel.com> == Series Details == Series: series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core URL : https://patchwork.freedesktop.org/series/69522/ State : warning == Summary == $ dim checkpatch origin/drm-tip a0ff7bbb56ea drm/i915: Allow i915 to manage the vma offset nodes instead of drm core -:368: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #368: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:646: + + } -:399: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #399: new file mode 100644 -:404: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #404: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:1: +/* -:405: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #405: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:2: + * SPDX-License-Identifier: MIT -:600: CHECK:LINE_SPACING: Please don't use multiple blank lines #600: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:580: + -:747: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #747: FILE: drivers/gpu/drm/i915/i915_getparam.c:2: * SPDX-License-Identifier: MIT total: 0 errors, 4 warnings, 2 checks, 648 lines checked bb6e6f21d2f9 drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:187: WARNING:LONG_LINE: line over 100 characters #187: FILE: include/uapi/drm/i915_drm.h:398: +#define DRM_IOCTL_I915_GEM_MMAP_OFFSET DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_GTT, struct drm_i915_gem_mmap_offset) total: 0 errors, 1 warnings, 0 checks, 153 lines checked 52a0eee7cfa2 drm/i915: cpu-map based dumb buffers -:22: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #22: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:545: +i915_gem_mmap_dumb(struct drm_file *file, + struct drm_device *dev, -:32: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #32: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:555: + return -ENODEV; + else -:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #50: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:28: +int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev, + u32 handle, u64 *offset); total: 0 errors, 1 warnings, 2 checks, 39 lines checked 27a373a960f1 drm/i915: Add cpu fault handler for mmap_offset _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Patchwork <patchwork@emeril.freedesktop.org> To: "Abdiel Janulgue" <abdiel.janulgue@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Date: Fri, 15 Nov 2019 13:56:34 -0000 [thread overview] Message-ID: <157382619478.3301.7151389380682338500@emeril.freedesktop.org> (raw) Message-ID: <20191115135634.yiww-zwddRQj_TjrITyCFdq_eZbispOJaayhebTJxcQ@z> (raw) In-Reply-To: <20191115114549.23716-1-abdiel.janulgue@linux.intel.com> == Series Details == Series: series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core URL : https://patchwork.freedesktop.org/series/69522/ State : warning == Summary == $ dim checkpatch origin/drm-tip a0ff7bbb56ea drm/i915: Allow i915 to manage the vma offset nodes instead of drm core -:368: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #368: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:646: + + } -:399: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #399: new file mode 100644 -:404: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #404: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:1: +/* -:405: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #405: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:2: + * SPDX-License-Identifier: MIT -:600: CHECK:LINE_SPACING: Please don't use multiple blank lines #600: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:580: + -:747: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #747: FILE: drivers/gpu/drm/i915/i915_getparam.c:2: * SPDX-License-Identifier: MIT total: 0 errors, 4 warnings, 2 checks, 648 lines checked bb6e6f21d2f9 drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:187: WARNING:LONG_LINE: line over 100 characters #187: FILE: include/uapi/drm/i915_drm.h:398: +#define DRM_IOCTL_I915_GEM_MMAP_OFFSET DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_GTT, struct drm_i915_gem_mmap_offset) total: 0 errors, 1 warnings, 0 checks, 153 lines checked 52a0eee7cfa2 drm/i915: cpu-map based dumb buffers -:22: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #22: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:545: +i915_gem_mmap_dumb(struct drm_file *file, + struct drm_device *dev, -:32: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #32: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:555: + return -ENODEV; + else -:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #50: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:28: +int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev, + u32 handle, u64 *offset); total: 0 errors, 1 warnings, 2 checks, 39 lines checked 27a373a960f1 drm/i915: Add cpu fault handler for mmap_offset _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-15 13:56 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-15 11:45 [PATCH 1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 11:45 ` [PATCH 2/4] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 13:51 ` Chris Wilson 2019-11-15 13:51 ` [Intel-gfx] " Chris Wilson 2019-11-15 14:31 ` Chris Wilson 2019-11-15 14:31 ` [Intel-gfx] " Chris Wilson 2019-11-15 11:45 ` [PATCH 3/4] drm/i915: cpu-map based dumb buffers Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 13:54 ` Chris Wilson 2019-11-15 13:54 ` [Intel-gfx] " Chris Wilson 2019-11-15 14:26 ` Chris Wilson 2019-11-15 14:26 ` [Intel-gfx] " Chris Wilson 2019-11-15 11:45 ` [PATCH 4/4] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue 2019-11-15 11:45 ` [Intel-gfx] " Abdiel Janulgue 2019-11-15 13:58 ` Chris Wilson 2019-11-15 13:58 ` [Intel-gfx] " Chris Wilson 2019-11-15 13:56 ` Patchwork [this message] 2019-11-15 13:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Patchwork 2019-11-15 13:57 ` ✗ Fi.CI.SPARSE: " Patchwork 2019-11-15 13:57 ` [Intel-gfx] " Patchwork 2019-11-15 14:17 ` [PATCH 1/4] " Chris Wilson 2019-11-15 14:17 ` [Intel-gfx] " Chris Wilson 2019-11-15 14:23 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] " Patchwork 2019-11-15 14:23 ` [Intel-gfx] " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2019-11-19 11:37 [PATCH 1/4] " Abdiel Janulgue 2019-11-19 12:46 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork 2019-11-14 19:09 [PATCH 1/4] " Abdiel Janulgue 2019-11-14 20:11 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=157382619478.3301.7151389380682338500@emeril.freedesktop.org \ --to=patchwork@emeril.freedesktop.org \ --cc=abdiel.janulgue@linux.intel.com \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.