From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: krzk@kernel.org, kgene@kernel.org, thomas.ab@samsung.com,
myungjoo.ham@samsung.com, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/6] mfd: max8997: Initialize max8997 register map
Date: Mon, 7 Nov 2016 11:22:42 -0300 [thread overview]
Message-ID: <1b150578-b766-3470-475c-fe494bcc8c54@osg.samsung.com> (raw)
In-Reply-To: <1478513376-14307-2-git-send-email-pankaj.dubey@samsung.com>
Hello Pankaj,
On 11/07/2016 07:09 AM, Pankaj Dubey wrote:
> This patch add regmap initialization to use register map
> in max8997-clk device driver
>
> CC: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Patch looks good to me. Now that the driver uses regmap, I think you should
be able to get rid of drivers/mfd/max8997-irq.c and use the regmap IRQ chip
like is done in most Maxim PMIC MFD drivers.
That can be done as a follow-up of this series though.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] mfd: max8997: Initialize max8997 register map
Date: Mon, 7 Nov 2016 11:22:42 -0300 [thread overview]
Message-ID: <1b150578-b766-3470-475c-fe494bcc8c54@osg.samsung.com> (raw)
In-Reply-To: <1478513376-14307-2-git-send-email-pankaj.dubey@samsung.com>
Hello Pankaj,
On 11/07/2016 07:09 AM, Pankaj Dubey wrote:
> This patch add regmap initialization to use register map
> in max8997-clk device driver
>
> CC: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Patch looks good to me. Now that the driver uses regmap, I think you should
be able to get rid of drivers/mfd/max8997-irq.c and use the regmap IRQ chip
like is done in most Maxim PMIC MFD drivers.
That can be done as a follow-up of this series though.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-11-07 14:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 10:09 [PATCH 0/6] Add support for MAX8997 Clock Driver Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 10:09 ` [PATCH 1/6] mfd: max8997: Initialize max8997 register map Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 14:22 ` Javier Martinez Canillas [this message]
2016-11-07 14:22 ` Javier Martinez Canillas
2016-11-07 17:12 ` Pankaj Dubey
2016-11-07 17:12 ` Pankaj Dubey
2016-11-07 10:09 ` [PATCH 5/6] mfd: max8997: Add max8997-clk name in mfd_cell Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 15:08 ` Javier Martinez Canillas
2016-11-07 15:08 ` Javier Martinez Canillas
[not found] ` <1478513376-14307-1-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-11-07 10:09 ` [PATCH 2/6] dt-bindings: clk: max8997: Add DT binding documentation Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 14:47 ` Javier Martinez Canillas
2016-11-07 14:47 ` Javier Martinez Canillas
2016-11-14 16:15 ` Rob Herring
2016-11-14 16:15 ` Rob Herring
2016-11-17 2:17 ` pankaj.dubey
2016-11-17 2:17 ` pankaj.dubey
2016-11-07 10:09 ` [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 15:01 ` Javier Martinez Canillas
2016-11-07 15:01 ` Javier Martinez Canillas
2016-11-07 15:01 ` Javier Martinez Canillas
[not found] ` <63750c2f-35cb-91ab-276b-c788f51081cb-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-11-07 17:20 ` Pankaj Dubey
2016-11-07 17:20 ` Pankaj Dubey
2016-11-07 17:20 ` Pankaj Dubey
2016-11-07 17:41 ` Krzysztof Kozlowski
2016-11-07 17:41 ` Krzysztof Kozlowski
2016-11-07 10:09 ` [PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
[not found] ` <1478513376-14307-5-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-11-07 15:07 ` Javier Martinez Canillas
2016-11-07 15:07 ` Javier Martinez Canillas
2016-11-07 10:09 ` [PATCH 6/6] ARM: dts: Extend the S3C RTC node with rtc_src clock Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 15:09 ` Javier Martinez Canillas
2016-11-07 15:09 ` Javier Martinez Canillas
2016-11-07 17:44 ` Krzysztof Kozlowski
2016-11-07 17:44 ` Krzysztof Kozlowski
2016-11-07 17:27 ` [PATCH 0/6] Add support for MAX8997 Clock Driver Krzysztof Kozlowski
2016-11-07 17:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b150578-b766-3470-475c-fe494bcc8c54@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.