All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	krzk@kernel.org, Kukjin Kim <kgene@kernel.org>,
	"thomas.ab@samsung.com" <thomas.ab@samsung.com>,
	myungjoo.ham@samsung.com, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/6] mfd: max8997: Initialize max8997 register map
Date: Mon, 7 Nov 2016 22:42:34 +0530	[thread overview]
Message-ID: <CAGcde9FvWWW4Yc08s9BzPsKrcqvWCj+kOPGp9pN__ssQC0V4tg@mail.gmail.com> (raw)
In-Reply-To: <1b150578-b766-3470-475c-fe494bcc8c54@osg.samsung.com>

Hi Javier,

On 7 November 2016 at 19:52, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> Hello Pankaj,
>
> On 11/07/2016 07:09 AM, Pankaj Dubey wrote:
>> This patch add regmap initialization to use register map
>> in max8997-clk device driver
>>
>> CC: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>
> Patch looks good to me. Now that the driver uses regmap, I think you should
> be able to get rid of drivers/mfd/max8997-irq.c and use the regmap IRQ chip
> like is done in most Maxim PMIC MFD drivers.
>
> That can be done as a follow-up of this series though.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>

Thanks for review.
You are right, that we can get rid of max8997-irq.c by using regmap
IRQ chip, but I would like to take that as a separate follow-up
series.

Thanks,
Pankaj Dubey

> Best regards,
> --
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: pankaj.dubey@samsung.com (Pankaj Dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] mfd: max8997: Initialize max8997 register map
Date: Mon, 7 Nov 2016 22:42:34 +0530	[thread overview]
Message-ID: <CAGcde9FvWWW4Yc08s9BzPsKrcqvWCj+kOPGp9pN__ssQC0V4tg@mail.gmail.com> (raw)
In-Reply-To: <1b150578-b766-3470-475c-fe494bcc8c54@osg.samsung.com>

Hi Javier,

On 7 November 2016 at 19:52, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> Hello Pankaj,
>
> On 11/07/2016 07:09 AM, Pankaj Dubey wrote:
>> This patch add regmap initialization to use register map
>> in max8997-clk device driver
>>
>> CC: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>
> Patch looks good to me. Now that the driver uses regmap, I think you should
> be able to get rid of drivers/mfd/max8997-irq.c and use the regmap IRQ chip
> like is done in most Maxim PMIC MFD drivers.
>
> That can be done as a follow-up of this series though.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>

Thanks for review.
You are right, that we can get rid of max8997-irq.c by using regmap
IRQ chip, but I would like to take that as a separate follow-up
series.

Thanks,
Pankaj Dubey

> Best regards,
> --
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-11-07 17:13 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 10:09 [PATCH 0/6] Add support for MAX8997 Clock Driver Pankaj Dubey
2016-11-07 10:09 ` Pankaj Dubey
2016-11-07 10:09 ` [PATCH 1/6] mfd: max8997: Initialize max8997 register map Pankaj Dubey
2016-11-07 10:09   ` Pankaj Dubey
2016-11-07 14:22   ` Javier Martinez Canillas
2016-11-07 14:22     ` Javier Martinez Canillas
2016-11-07 17:12     ` Pankaj Dubey [this message]
2016-11-07 17:12       ` Pankaj Dubey
2016-11-07 10:09 ` [PATCH 5/6] mfd: max8997: Add max8997-clk name in mfd_cell Pankaj Dubey
2016-11-07 10:09   ` Pankaj Dubey
2016-11-07 15:08   ` Javier Martinez Canillas
2016-11-07 15:08     ` Javier Martinez Canillas
     [not found] ` <1478513376-14307-1-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-11-07 10:09   ` [PATCH 2/6] dt-bindings: clk: max8997: Add DT binding documentation Pankaj Dubey
2016-11-07 10:09     ` Pankaj Dubey
2016-11-07 10:09     ` Pankaj Dubey
2016-11-07 14:47     ` Javier Martinez Canillas
2016-11-07 14:47       ` Javier Martinez Canillas
2016-11-14 16:15     ` Rob Herring
2016-11-14 16:15       ` Rob Herring
2016-11-17  2:17       ` pankaj.dubey
2016-11-17  2:17         ` pankaj.dubey
2016-11-07 10:09   ` [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks Pankaj Dubey
2016-11-07 10:09     ` Pankaj Dubey
2016-11-07 10:09     ` Pankaj Dubey
2016-11-07 15:01     ` Javier Martinez Canillas
2016-11-07 15:01       ` Javier Martinez Canillas
2016-11-07 15:01       ` Javier Martinez Canillas
     [not found]       ` <63750c2f-35cb-91ab-276b-c788f51081cb-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-11-07 17:20         ` Pankaj Dubey
2016-11-07 17:20           ` Pankaj Dubey
2016-11-07 17:20           ` Pankaj Dubey
2016-11-07 17:41     ` Krzysztof Kozlowski
2016-11-07 17:41       ` Krzysztof Kozlowski
2016-11-07 10:09   ` [PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node Pankaj Dubey
2016-11-07 10:09     ` Pankaj Dubey
     [not found]     ` <1478513376-14307-5-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-11-07 15:07       ` Javier Martinez Canillas
2016-11-07 15:07         ` Javier Martinez Canillas
2016-11-07 10:09   ` [PATCH 6/6] ARM: dts: Extend the S3C RTC node with rtc_src clock Pankaj Dubey
2016-11-07 10:09     ` Pankaj Dubey
2016-11-07 15:09     ` Javier Martinez Canillas
2016-11-07 15:09       ` Javier Martinez Canillas
2016-11-07 17:44     ` Krzysztof Kozlowski
2016-11-07 17:44       ` Krzysztof Kozlowski
2016-11-07 17:27 ` [PATCH 0/6] Add support for MAX8997 Clock Driver Krzysztof Kozlowski
2016-11-07 17:27   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGcde9FvWWW4Yc08s9BzPsKrcqvWCj+kOPGp9pN__ssQC0V4tg@mail.gmail.com \
    --to=pankaj.dubey@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.