From: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> To: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node Date: Mon, 7 Nov 2016 12:07:32 -0300 [thread overview] Message-ID: <ef27992b-87a0-6d18-35cc-83360e6d677a@osg.samsung.com> (raw) In-Reply-To: <1478513376-14307-5-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > This patch adds a label and #clock-cells property to device node of > max8997 PMIC to allow using it as a clock provider. > > CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > arch/arm/boot/dts/exynos4210-origen.dts | 3 ++- > arch/arm/boot/dts/exynos4210-trats.dts | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts > index cb3a255..6c7ef4e 100644 > --- a/arch/arm/boot/dts/exynos4210-origen.dts > +++ b/arch/arm/boot/dts/exynos4210-origen.dts > @@ -147,11 +147,12 @@ > pinctrl-0 = <&i2c0_bus>; > pinctrl-names = "default"; > > - max8997_pmic@66 { > + max8997: max8997_pmic@66 { The ePAPR says that the node name should be "somewhat generic, reflecting the function of the device and not its precise programming model". So I think this should be instead: max8997: pmic@66 { [...] > - max8997_pmic@66 { > + max8997: max8997_pmic@66 { Same here. The rest looks good to me. Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node Date: Mon, 7 Nov 2016 12:07:32 -0300 [thread overview] Message-ID: <ef27992b-87a0-6d18-35cc-83360e6d677a@osg.samsung.com> (raw) In-Reply-To: <1478513376-14307-5-git-send-email-pankaj.dubey@samsung.com> Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > This patch adds a label and #clock-cells property to device node of > max8997 PMIC to allow using it as a clock provider. > > CC: Rob Herring <robh+dt@kernel.org> > CC: devicetree at vger.kernel.org > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > arch/arm/boot/dts/exynos4210-origen.dts | 3 ++- > arch/arm/boot/dts/exynos4210-trats.dts | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts > index cb3a255..6c7ef4e 100644 > --- a/arch/arm/boot/dts/exynos4210-origen.dts > +++ b/arch/arm/boot/dts/exynos4210-origen.dts > @@ -147,11 +147,12 @@ > pinctrl-0 = <&i2c0_bus>; > pinctrl-names = "default"; > > - max8997_pmic at 66 { > + max8997: max8997_pmic at 66 { The ePAPR says that the node name should be "somewhat generic, reflecting the function of the device and not its precise programming model". So I think this should be instead: max8997: pmic at 66 { [...] > - max8997_pmic at 66 { > + max8997: max8997_pmic at 66 { Same here. The rest looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
next prev parent reply other threads:[~2016-11-07 15:07 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-07 10:09 [PATCH 0/6] Add support for MAX8997 Clock Driver Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 10:09 ` [PATCH 1/6] mfd: max8997: Initialize max8997 register map Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 14:22 ` Javier Martinez Canillas 2016-11-07 14:22 ` Javier Martinez Canillas 2016-11-07 17:12 ` Pankaj Dubey 2016-11-07 17:12 ` Pankaj Dubey 2016-11-07 10:09 ` [PATCH 5/6] mfd: max8997: Add max8997-clk name in mfd_cell Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 15:08 ` Javier Martinez Canillas 2016-11-07 15:08 ` Javier Martinez Canillas [not found] ` <1478513376-14307-1-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2016-11-07 10:09 ` [PATCH 2/6] dt-bindings: clk: max8997: Add DT binding documentation Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 14:47 ` Javier Martinez Canillas 2016-11-07 14:47 ` Javier Martinez Canillas 2016-11-14 16:15 ` Rob Herring 2016-11-14 16:15 ` Rob Herring 2016-11-17 2:17 ` pankaj.dubey 2016-11-17 2:17 ` pankaj.dubey 2016-11-07 10:09 ` [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 15:01 ` Javier Martinez Canillas 2016-11-07 15:01 ` Javier Martinez Canillas 2016-11-07 15:01 ` Javier Martinez Canillas [not found] ` <63750c2f-35cb-91ab-276b-c788f51081cb-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 2016-11-07 17:20 ` Pankaj Dubey 2016-11-07 17:20 ` Pankaj Dubey 2016-11-07 17:20 ` Pankaj Dubey 2016-11-07 17:41 ` Krzysztof Kozlowski 2016-11-07 17:41 ` Krzysztof Kozlowski 2016-11-07 10:09 ` [PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey [not found] ` <1478513376-14307-5-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2016-11-07 15:07 ` Javier Martinez Canillas [this message] 2016-11-07 15:07 ` Javier Martinez Canillas 2016-11-07 10:09 ` [PATCH 6/6] ARM: dts: Extend the S3C RTC node with rtc_src clock Pankaj Dubey 2016-11-07 10:09 ` Pankaj Dubey 2016-11-07 15:09 ` Javier Martinez Canillas 2016-11-07 15:09 ` Javier Martinez Canillas 2016-11-07 17:44 ` Krzysztof Kozlowski 2016-11-07 17:44 ` Krzysztof Kozlowski 2016-11-07 17:27 ` [PATCH 0/6] Add support for MAX8997 Clock Driver Krzysztof Kozlowski 2016-11-07 17:27 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ef27992b-87a0-6d18-35cc-83360e6d677a@osg.samsung.com \ --to=javier-jph+aebz4p+uejcrhfaqsw@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.