From: Grant Grundler <iod00d@hp.com> To: Matthew Wilcox <matthew@wil.cx> Cc: Jesse Barnes <jbarnes@engr.sgi.com>, "Luck, Tony" <tony.luck@intel.com>, Pat Gefre <pfg@sgi.com>, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization Date: Tue, 5 Oct 2004 12:10:08 -0700 [thread overview] Message-ID: <20041005191008.GG18567@cup.hp.com> (raw) In-Reply-To: <20041005174558.GZ16153@parcelfarce.linux.theplanet.co.uk> On Tue, Oct 05, 2004 at 06:45:58PM +0100, Matthew Wilcox wrote: > On Tue, Oct 05, 2004 at 09:22:01AM -0700, Grant Grundler wrote: > > pci_root_ops should be static. It's only intended for ACPI. > > What I had intended when I wrote this code was that platforms that didn't > want to use the generic SAL code (and why not? It doesn't seem like it > should be the hardest thing in the world to move your hacks into SAL) > was that people should override > > struct pci_raw_ops *raw_pci_ops = &pci_sal_ops; ah ok. > by just assigning raw_pci_ops in their own code. I haven't looked at > the SGI code yet, but this is how arch/i386/pci/direct.c (for example) > works. > > > Maybe rename pci_root_ops to "acpi_pci_ops" would make that clearer. > > No. Don't rename it to anything ACPI specific. It isn't. I understand raw_pci_ops is not ACPI specific. But pci_root_ops is only used by pci_acpi_scan_root(). grundler@gsyprf3:/usr/src/linux-2.6.8.1$ fgrep pci_acpi_scan_root include/*/* include/acpi/acpi_drivers.h:struct pci_bus *pci_acpi_scan_root(struct acpi_device *device, int domain, int bus); and ./drivers/acpi/pci_root.c: root->bus = pci_acpi_scan_root(device, root->id.segment, root->id.bus); The rename still seems appropriate to me. thanks, grant
WARNING: multiple messages have this Message-ID (diff)
From: Grant Grundler <iod00d@hp.com> To: Matthew Wilcox <matthew@wil.cx> Cc: Jesse Barnes <jbarnes@engr.sgi.com>, "Luck, Tony" <tony.luck@intel.com>, Pat Gefre <pfg@sgi.com>, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization Date: Tue, 05 Oct 2004 19:10:08 +0000 [thread overview] Message-ID: <20041005191008.GG18567@cup.hp.com> (raw) In-Reply-To: <20041005174558.GZ16153@parcelfarce.linux.theplanet.co.uk> On Tue, Oct 05, 2004 at 06:45:58PM +0100, Matthew Wilcox wrote: > On Tue, Oct 05, 2004 at 09:22:01AM -0700, Grant Grundler wrote: > > pci_root_ops should be static. It's only intended for ACPI. > > What I had intended when I wrote this code was that platforms that didn't > want to use the generic SAL code (and why not? It doesn't seem like it > should be the hardest thing in the world to move your hacks into SAL) > was that people should override > > struct pci_raw_ops *raw_pci_ops = &pci_sal_ops; ah ok. > by just assigning raw_pci_ops in their own code. I haven't looked at > the SGI code yet, but this is how arch/i386/pci/direct.c (for example) > works. > > > Maybe rename pci_root_ops to "acpi_pci_ops" would make that clearer. > > No. Don't rename it to anything ACPI specific. It isn't. I understand raw_pci_ops is not ACPI specific. But pci_root_ops is only used by pci_acpi_scan_root(). grundler@gsyprf3:/usr/src/linux-2.6.8.1$ fgrep pci_acpi_scan_root include/*/* include/acpi/acpi_drivers.h:struct pci_bus *pci_acpi_scan_root(struct acpi_device *device, int domain, int bus); and ./drivers/acpi/pci_root.c: root->bus = pci_acpi_scan_root(device, root->id.segment, root->id.bus); The rename still seems appropriate to me. thanks, grant
next prev parent reply other threads:[~2004-10-05 19:10 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-10-05 5:13 [PATCH] 2.6 SGI Altix I/O code reorganization Luck, Tony 2004-10-05 5:13 ` Luck, Tony 2004-10-05 15:43 ` Jesse Barnes 2004-10-05 15:43 ` Jesse Barnes 2004-10-05 16:22 ` Grant Grundler 2004-10-05 16:22 ` Grant Grundler 2004-10-05 17:45 ` Matthew Wilcox 2004-10-05 17:45 ` Matthew Wilcox 2004-10-05 19:00 ` Colin Ngam 2004-10-05 19:00 ` Colin Ngam 2004-10-05 19:10 ` Grant Grundler [this message] 2004-10-05 19:10 ` Grant Grundler 2004-10-05 19:15 ` Matthew Wilcox 2004-10-05 19:15 ` Matthew Wilcox 2004-10-05 18:20 ` Patrick Gefre 2004-10-05 18:20 ` Patrick Gefre 2004-10-05 18:34 ` Jesse Barnes 2004-10-05 18:34 ` Jesse Barnes -- strict thread matches above, loose matches on Subject: below -- 2004-10-11 20:49 Luck, Tony 2004-10-11 20:49 ` Luck, Tony 2004-10-07 17:06 Luck, Tony 2004-10-07 17:06 ` Luck, Tony 2004-10-07 17:22 ` Jesse Barnes 2004-10-07 17:22 ` Jesse Barnes 2004-10-07 18:59 ` Jes Sorensen 2004-10-07 18:59 ` Jes Sorensen 2004-10-05 20:34 Luck, Tony 2004-10-05 20:34 ` Luck, Tony 2004-10-06 15:32 ` Patrick Gefre 2004-10-06 15:32 ` Patrick Gefre 2004-10-06 18:57 ` Grant Grundler 2004-10-06 18:57 ` Grant Grundler 2004-10-06 19:09 ` Colin Ngam 2004-10-06 19:09 ` Colin Ngam 2004-10-06 19:54 ` Grant Grundler 2004-10-06 19:54 ` Grant Grundler 2004-10-06 19:54 ` Colin Ngam 2004-10-06 19:54 ` Colin Ngam 2004-10-06 20:10 ` Patrick Gefre 2004-10-06 20:10 ` Patrick Gefre 2004-10-06 20:44 ` Jesse Barnes 2004-10-06 20:44 ` Jesse Barnes 2004-10-07 15:02 ` Patrick Gefre 2004-10-07 15:02 ` Patrick Gefre 2004-10-07 16:52 ` Jesse Barnes 2004-10-07 16:52 ` Jesse Barnes 2004-10-06 20:27 ` Jesse Barnes 2004-10-06 20:27 ` Jesse Barnes 2004-10-06 20:21 ` Colin Ngam 2004-10-06 20:21 ` Colin Ngam 2004-10-06 20:33 ` Matthew Wilcox 2004-10-06 20:33 ` Matthew Wilcox 2004-10-06 20:48 ` Grant Grundler 2004-10-06 20:48 ` Grant Grundler 2004-10-06 21:05 ` Matthew Wilcox 2004-10-06 21:05 ` Matthew Wilcox 2004-10-06 20:55 ` Colin Ngam 2004-10-06 20:55 ` Colin Ngam 2004-10-08 15:16 ` Colin Ngam 2004-10-08 15:16 ` Colin Ngam 2004-10-08 16:37 ` Jesse Barnes 2004-10-08 16:37 ` Jesse Barnes 2004-10-09 22:20 ` Grant Grundler 2004-10-09 22:20 ` Grant Grundler [not found] ` <4169A508.84FB19C7@sgi.com> 2004-10-11 14:03 ` Patrick Gefre 2004-10-11 14:03 ` Patrick Gefre 2004-10-08 22:37 ` Colin Ngam 2004-10-08 22:37 ` Colin Ngam 2004-10-05 19:16 Luck, Tony 2004-10-05 19:16 ` Luck, Tony 2004-10-05 19:35 ` Patrick Gefre 2004-10-05 19:35 ` Patrick Gefre 2004-10-04 21:57 Pat Gefre 2004-10-04 21:57 ` Pat Gefre 2004-10-05 15:48 ` Christoph Hellwig 2004-10-05 15:48 ` Christoph Hellwig 2004-10-05 18:26 ` Patrick Gefre 2004-10-05 18:26 ` Patrick Gefre 2004-10-05 23:30 ` Patrick Gefre 2004-10-05 23:30 ` Patrick Gefre 2004-10-05 15:50 ` Christoph Hellwig 2004-10-05 15:50 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20041005191008.GG18567@cup.hp.com \ --to=iod00d@hp.com \ --cc=jbarnes@engr.sgi.com \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matthew@wil.cx \ --cc=pfg@sgi.com \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.