From: Jesse Barnes <jbarnes@engr.sgi.com>
To: cngam@sgi.com
Cc: Matthew Wilcox <matthew@wil.cx>, Grant Grundler <iod00d@hp.com>,
"Luck, Tony" <tony.luck@intel.com>, Patrick Gefre <pfg@sgi.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization
Date: Fri, 8 Oct 2004 09:37:33 -0700 [thread overview]
Message-ID: <200410080937.33631.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <4166AF3D.9080808@sgi.com>
On Friday, October 8, 2004 8:16 am, Colin Ngam wrote:
> Now, if we can remove the static from pci_root_ops, I can use it in
> io_init.c, that would be cleanest and that was what we started with.
> This is what the patch would look like ontop of the 002_add* patch:
Yep, this looks good to me Colin.
> +extern struct pci_ops pci_root_ops;
> +
> +extern struct pci_ops pci_root_ops;
> +
...but of course you don't need to extern it twice :)
> We need a resolution so that Tony can proceed. Silence is not going to
> help.
You've got my vote.
Jesse
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: cngam@sgi.com
Cc: Matthew Wilcox <matthew@wil.cx>, Grant Grundler <iod00d@hp.com>,
"Luck, Tony" <tony.luck@intel.com>, Patrick Gefre <pfg@sgi.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization
Date: Fri, 08 Oct 2004 16:37:33 +0000 [thread overview]
Message-ID: <200410080937.33631.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <4166AF3D.9080808@sgi.com>
On Friday, October 8, 2004 8:16 am, Colin Ngam wrote:
> Now, if we can remove the static from pci_root_ops, I can use it in
> io_init.c, that would be cleanest and that was what we started with.
> This is what the patch would look like ontop of the 002_add* patch:
Yep, this looks good to me Colin.
> +extern struct pci_ops pci_root_ops;
> +
> +extern struct pci_ops pci_root_ops;
> +
...but of course you don't need to extern it twice :)
> We need a resolution so that Tony can proceed. Silence is not going to
> help.
You've got my vote.
Jesse
next prev parent reply other threads:[~2004-10-08 16:40 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 20:34 [PATCH] 2.6 SGI Altix I/O code reorganization Luck, Tony
2004-10-05 20:34 ` Luck, Tony
2004-10-06 15:32 ` Patrick Gefre
2004-10-06 15:32 ` Patrick Gefre
2004-10-06 18:57 ` Grant Grundler
2004-10-06 18:57 ` Grant Grundler
2004-10-06 19:09 ` Colin Ngam
2004-10-06 19:09 ` Colin Ngam
2004-10-06 19:54 ` Grant Grundler
2004-10-06 19:54 ` Grant Grundler
2004-10-06 19:54 ` Colin Ngam
2004-10-06 19:54 ` Colin Ngam
2004-10-06 20:10 ` Patrick Gefre
2004-10-06 20:10 ` Patrick Gefre
2004-10-06 20:44 ` Jesse Barnes
2004-10-06 20:44 ` Jesse Barnes
2004-10-07 15:02 ` Patrick Gefre
2004-10-07 15:02 ` Patrick Gefre
2004-10-07 16:52 ` Jesse Barnes
2004-10-07 16:52 ` Jesse Barnes
2004-10-06 20:27 ` Jesse Barnes
2004-10-06 20:27 ` Jesse Barnes
2004-10-06 20:21 ` Colin Ngam
2004-10-06 20:21 ` Colin Ngam
2004-10-06 20:33 ` Matthew Wilcox
2004-10-06 20:33 ` Matthew Wilcox
2004-10-06 20:48 ` Grant Grundler
2004-10-06 20:48 ` Grant Grundler
2004-10-06 21:05 ` Matthew Wilcox
2004-10-06 21:05 ` Matthew Wilcox
2004-10-06 20:55 ` Colin Ngam
2004-10-06 20:55 ` Colin Ngam
2004-10-08 15:16 ` Colin Ngam
2004-10-08 15:16 ` Colin Ngam
2004-10-08 16:37 ` Jesse Barnes [this message]
2004-10-08 16:37 ` Jesse Barnes
2004-10-09 22:20 ` Grant Grundler
2004-10-09 22:20 ` Grant Grundler
[not found] ` <4169A508.84FB19C7@sgi.com>
2004-10-11 14:03 ` Patrick Gefre
2004-10-11 14:03 ` Patrick Gefre
2004-10-08 22:37 ` Colin Ngam
2004-10-08 22:37 ` Colin Ngam
-- strict thread matches above, loose matches on Subject: below --
2004-10-11 20:49 Luck, Tony
2004-10-11 20:49 ` Luck, Tony
2004-10-07 17:06 Luck, Tony
2004-10-07 17:06 ` Luck, Tony
2004-10-07 17:22 ` Jesse Barnes
2004-10-07 17:22 ` Jesse Barnes
2004-10-07 18:59 ` Jes Sorensen
2004-10-07 18:59 ` Jes Sorensen
2004-10-05 19:16 Luck, Tony
2004-10-05 19:16 ` Luck, Tony
2004-10-05 19:35 ` Patrick Gefre
2004-10-05 19:35 ` Patrick Gefre
2004-10-05 5:13 Luck, Tony
2004-10-05 5:13 ` Luck, Tony
2004-10-05 15:43 ` Jesse Barnes
2004-10-05 15:43 ` Jesse Barnes
2004-10-05 16:22 ` Grant Grundler
2004-10-05 16:22 ` Grant Grundler
2004-10-05 17:45 ` Matthew Wilcox
2004-10-05 17:45 ` Matthew Wilcox
2004-10-05 19:00 ` Colin Ngam
2004-10-05 19:00 ` Colin Ngam
2004-10-05 19:10 ` Grant Grundler
2004-10-05 19:10 ` Grant Grundler
2004-10-05 19:15 ` Matthew Wilcox
2004-10-05 19:15 ` Matthew Wilcox
2004-10-05 18:20 ` Patrick Gefre
2004-10-05 18:20 ` Patrick Gefre
2004-10-05 18:34 ` Jesse Barnes
2004-10-05 18:34 ` Jesse Barnes
2004-10-04 21:57 Pat Gefre
2004-10-04 21:57 ` Pat Gefre
2004-10-05 15:48 ` Christoph Hellwig
2004-10-05 15:48 ` Christoph Hellwig
2004-10-05 18:26 ` Patrick Gefre
2004-10-05 18:26 ` Patrick Gefre
2004-10-05 23:30 ` Patrick Gefre
2004-10-05 23:30 ` Patrick Gefre
2004-10-05 15:50 ` Christoph Hellwig
2004-10-05 15:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410080937.33631.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=cngam@sgi.com \
--cc=iod00d@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=pfg@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.