All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Adrian Bunk <bunk@stusta.de>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 19:53:14 +0000	[thread overview]
Message-ID: <20051213195314.GB24094@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.62.0512131837380.17990@pademelon.sonytel.be>

On Tue, Dec 13, 2005 at 06:38:36PM +0100, Geert Uytterhoeven wrote:
> On Tue, 13 Dec 2005, Russell King wrote:
> > If, in order to have a working platform configuration, they deem that
>                          ^^^^^^^
> > CONFIG_BROKEN must be enabled, then that's the way it is.
>          ^^^^^^
> Still funny...
> 
> So either one of them is lying...

They might be broken in other situations.  However, if you look at
the latest build at:

 http://armlinux.simtec.co.uk/kautobuild/

you'll notice that all, even the ones with CONFIG_BROKEN build
successfully.  Without any bug reports to the contary, we must
assume that the configuration files supplied by the folk who
developed the support for the platform are correct and working.

Therefore, CONFIG_BROKEN may have been added to configuration
options which don't work for some particular small corner cases.

This brings on to another subject.  If we mark something broken
we should say _why_ we're doing so, especially if it is non-obvious.
That seems to be the case here - if these drivers are broken, it's
non-obvious why they're broken.

So, all in all, CONFIG_BROKEN is a broken idea in itself!

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2005-12-13 19:53 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-11 18:52 [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Adrian Bunk
2005-12-11 18:52 ` Adrian Bunk
2005-12-11 18:52 ` Adrian Bunk
2005-12-11 19:21 ` Russell King
2005-12-11 19:21   ` Russell King
2005-12-11 19:31   ` Adrian Bunk
2005-12-11 19:31     ` Adrian Bunk
2005-12-11 19:44     ` Russell King
2005-12-11 19:44       ` Russell King
2005-12-13  0:10       ` Adrian Bunk
2005-12-13  0:10         ` Adrian Bunk
2005-12-13  0:10         ` Adrian Bunk
2005-12-13 13:34         ` Simon Richter
2005-12-13 13:34           ` Simon Richter
2005-12-13 13:34           ` Simon Richter
2005-12-13 14:00           ` Adrian Bunk
2005-12-13 14:00             ` Adrian Bunk
2005-12-13 14:00             ` Adrian Bunk
2005-12-13 14:00             ` Adrian Bunk
2005-12-13 17:31             ` Russell King
2005-12-13 17:31               ` Russell King
2005-12-13 17:31               ` Russell King
2005-12-13 17:38               ` Geert Uytterhoeven
2005-12-13 19:53                 ` Russell King [this message]
2005-12-13 20:09                   ` Adrian Bunk
2005-12-13 18:05               ` [2.6 patch] don't allow users to " Adrian Bunk
2005-12-13 18:05                 ` Adrian Bunk
2005-12-13 18:05                 ` Adrian Bunk
2005-12-13 18:28                 ` Geert Uytterhoeven
2005-12-13 18:28                   ` Geert Uytterhoeven
2005-12-13 18:28                   ` Geert Uytterhoeven
2005-12-13 18:28                   ` Geert Uytterhoeven
2005-12-13 18:51                   ` Adrian Bunk
2005-12-13 18:51                     ` Adrian Bunk
2005-12-13 18:51                     ` Adrian Bunk
2005-12-13 18:51                     ` Adrian Bunk
2005-12-13 18:59                   ` Jesper Juhl
2005-12-13 18:59                     ` Jesper Juhl
2005-12-13 18:59                     ` Jesper Juhl
2005-12-13 18:59                     ` Jesper Juhl
2005-12-13 20:01                 ` Russell King
2005-12-13 20:01                   ` Russell King
2005-12-13 20:01                   ` Russell King
2005-12-13 20:19                   ` Adrian Bunk
2005-12-13 20:19                     ` Adrian Bunk
2005-12-13 20:19                     ` Adrian Bunk
2005-12-13 22:01                     ` Russell King
2005-12-13 22:01                       ` Russell King
2005-12-13 22:01                       ` Russell King
2005-12-12  9:38     ` [2.6 patch] defconfig's shouldn't " David Woodhouse
2005-12-12  9:38       ` David Woodhouse
2005-12-12  9:38       ` David Woodhouse
2005-12-13  0:05       ` [RFC: 2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2005-12-13  0:06         ` Adrian Bunk
2005-12-14 11:50       ` [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051213195314.GB24094@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=bunk@stusta.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.