From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, matthew@wil.cx,
grundler@parisc-linux.org, parisc-linux@parisc-linux.org,
paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org,
kkojima@rr.iij4u.or.jp, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 01:10:28 +0100 [thread overview]
Message-ID: <20051213001028.GS23349@stusta.de> (raw)
In-Reply-To: <20051211194437.GB22537@flint.arm.linux.org.uk>
On Sun, Dec 11, 2005 at 07:44:37PM +0000, Russell King wrote:
> On Sun, Dec 11, 2005 at 08:31:18PM +0100, Adrian Bunk wrote:
> > On Sun, Dec 11, 2005 at 07:21:10PM +0000, Russell King wrote:
> > > On Sun, Dec 11, 2005 at 07:52:12PM +0100, Adrian Bunk wrote:
> > > > defconfig's shouldn't set CONFIG_BROKEN=y.
> > >
> > > NACK. This changes other configuration options in addition, for example
> > > in collie_defconfig:
> > >
> > > -CONFIG_MTD_OBSOLETE_CHIPS=y
> > > -# CONFIG_MTD_AMDSTD is not set
> > > -CONFIG_MTD_SHARP=y
> > > -# CONFIG_MTD_JEDEC is not set
> >
> > That's not a problem introduced by my patch.
>
> It's a problem introduced by your patch because the resulting defconfig
> file becomes _wrong_ by your change, and other changes in the defconfig
> are thereby hidden.
>...
No, CONFIG_BROKEN=y in a defconfig file is a bug.
Either the defconfig doesn't use BROKEN code in which case it's simply
wrong, or it's a wrong workaround (as in the CONFIG_MTD_SHARP case) for
a wrong BROKEN dependency.
And it's a dangerous workaround:
Consider e.g. that "both marked as obsolete and BROKEN" are the best
candidates for "remove obsolete code" cleanups - and there goes your
driver to /dev/null ...
> Russell King
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, matthew@wil.cx,
grundler@parisc-linux.org, parisc-linux@parisc-linux.org,
paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org,
kkojima@rr.iij4u.or.jp, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 01:10:28 +0100 [thread overview]
Message-ID: <20051213001028.GS23349@stusta.de> (raw)
In-Reply-To: <20051211194437.GB22537@flint.arm.linux.org.uk>
On Sun, Dec 11, 2005 at 07:44:37PM +0000, Russell King wrote:
> On Sun, Dec 11, 2005 at 08:31:18PM +0100, Adrian Bunk wrote:
> > On Sun, Dec 11, 2005 at 07:21:10PM +0000, Russell King wrote:
> > > On Sun, Dec 11, 2005 at 07:52:12PM +0100, Adrian Bunk wrote:
> > > > defconfig's shouldn't set CONFIG_BROKEN=y.
> > >
> > > NACK. This changes other configuration options in addition, for example
> > > in collie_defconfig:
> > >
> > > -CONFIG_MTD_OBSOLETE_CHIPS=y
> > > -# CONFIG_MTD_AMDSTD is not set
> > > -CONFIG_MTD_SHARP=y
> > > -# CONFIG_MTD_JEDEC is not set
> >
> > That's not a problem introduced by my patch.
>
> It's a problem introduced by your patch because the resulting defconfig
> file becomes _wrong_ by your change, and other changes in the defconfig
> are thereby hidden.
>...
No, CONFIG_BROKEN=y in a defconfig file is a bug.
Either the defconfig doesn't use BROKEN code in which case it's simply
wrong, or it's a wrong workaround (as in the CONFIG_MTD_SHARP case) for
a wrong BROKEN dependency.
And it's a dangerous workaround:
Consider e.g. that "both marked as obsolete and BROKEN" are the best
candidates for "remove obsolete code" cleanups - and there goes your
driver to /dev/null ...
> Russell King
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, matthew@wil.cx,
grundler@parisc-linux.org, parisc-linux@parisc-linux.org,
paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org,
kkojima@rr.iij4u.or.jp, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
Date: Tue, 13 Dec 2005 00:10:28 +0000 [thread overview]
Message-ID: <20051213001028.GS23349@stusta.de> (raw)
In-Reply-To: <20051211194437.GB22537@flint.arm.linux.org.uk>
On Sun, Dec 11, 2005 at 07:44:37PM +0000, Russell King wrote:
> On Sun, Dec 11, 2005 at 08:31:18PM +0100, Adrian Bunk wrote:
> > On Sun, Dec 11, 2005 at 07:21:10PM +0000, Russell King wrote:
> > > On Sun, Dec 11, 2005 at 07:52:12PM +0100, Adrian Bunk wrote:
> > > > defconfig's shouldn't set CONFIG_BROKEN=y.
> > >
> > > NACK. This changes other configuration options in addition, for example
> > > in collie_defconfig:
> > >
> > > -CONFIG_MTD_OBSOLETE_CHIPS=y
> > > -# CONFIG_MTD_AMDSTD is not set
> > > -CONFIG_MTD_SHARP=y
> > > -# CONFIG_MTD_JEDEC is not set
> >
> > That's not a problem introduced by my patch.
>
> It's a problem introduced by your patch because the resulting defconfig
> file becomes _wrong_ by your change, and other changes in the defconfig
> are thereby hidden.
>...
No, CONFIG_BROKEN=y in a defconfig file is a bug.
Either the defconfig doesn't use BROKEN code in which case it's simply
wrong, or it's a wrong workaround (as in the CONFIG_MTD_SHARP case) for
a wrong BROKEN dependency.
And it's a dangerous workaround:
Consider e.g. that "both marked as obsolete and BROKEN" are the best
candidates for "remove obsolete code" cleanups - and there goes your
driver to /dev/null ...
> Russell King
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-12-13 0:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-11 18:52 [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Adrian Bunk
2005-12-11 18:52 ` Adrian Bunk
2005-12-11 18:52 ` Adrian Bunk
2005-12-11 19:21 ` Russell King
2005-12-11 19:21 ` Russell King
2005-12-11 19:31 ` Adrian Bunk
2005-12-11 19:31 ` Adrian Bunk
2005-12-11 19:44 ` Russell King
2005-12-11 19:44 ` Russell King
2005-12-13 0:10 ` Adrian Bunk [this message]
2005-12-13 0:10 ` Adrian Bunk
2005-12-13 0:10 ` Adrian Bunk
2005-12-13 13:34 ` Simon Richter
2005-12-13 13:34 ` Simon Richter
2005-12-13 13:34 ` Simon Richter
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 14:00 ` Adrian Bunk
2005-12-13 17:31 ` Russell King
2005-12-13 17:31 ` Russell King
2005-12-13 17:31 ` Russell King
2005-12-13 17:38 ` Geert Uytterhoeven
2005-12-13 19:53 ` Russell King
2005-12-13 20:09 ` Adrian Bunk
2005-12-13 18:05 ` [2.6 patch] don't allow users to " Adrian Bunk
2005-12-13 18:05 ` Adrian Bunk
2005-12-13 18:05 ` Adrian Bunk
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:28 ` Geert Uytterhoeven
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:51 ` Adrian Bunk
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 18:59 ` Jesper Juhl
2005-12-13 20:01 ` Russell King
2005-12-13 20:01 ` Russell King
2005-12-13 20:01 ` Russell King
2005-12-13 20:19 ` Adrian Bunk
2005-12-13 20:19 ` Adrian Bunk
2005-12-13 20:19 ` Adrian Bunk
2005-12-13 22:01 ` Russell King
2005-12-13 22:01 ` Russell King
2005-12-13 22:01 ` Russell King
2005-12-12 9:38 ` [2.6 patch] defconfig's shouldn't " David Woodhouse
2005-12-12 9:38 ` David Woodhouse
2005-12-12 9:38 ` David Woodhouse
2005-12-13 0:05 ` [RFC: 2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2005-12-13 0:06 ` Adrian Bunk
2005-12-14 11:50 ` [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213001028.GS23349@stusta.de \
--to=bunk@stusta.de \
--cc=dwmw2@infradead.org \
--cc=grundler@parisc-linux.org \
--cc=kkojima@rr.iij4u.or.jp \
--cc=lethal@linux-sh.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew@wil.cx \
--cc=parisc-linux@parisc-linux.org \
--cc=paulus@samba.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.